[Lldb-commits] [PATCH] D115308: [LLDB][DWARF] Fix duplicate TypeSP in type list

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3f0e1ea3ef8: [LLDB][DWARF] Fix duplicate TypeSP in type list (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115308/new/ https://revi

[Lldb-commits] [lldb] c3f0e1e - [LLDB][DWARF] Fix duplicate TypeSP in type list

Author: Zequan Wu Date: 2021-12-22T16:36:56-08:00 New Revision: c3f0e1ea3ef802059e0c2bd60227ea2d83a910ac URL: https://github.com/llvm/llvm-project/commit/c3f0e1ea3ef802059e0c2bd60227ea2d83a910ac DIFF: https://github.com/llvm/llvm-project/commit/c3f0e1ea3ef802059e0c2bd60227ea2d83a910ac.diff LOG

[Lldb-commits] [PATCH] D116195: [LLDB] Allows overwriting the existing line entry at given file address when inserting

zequanwu created this revision. zequanwu added reviewers: labath, clayborg. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It seems like that line entries in line table are assumed to always have distinct file address. This allows

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

ljmf00 added a comment. In D116136#3206294 , @labath wrote: > I guess you'll want to use this type for your language plugin, but it seems a > bit weird to have a value with no uses. Should we maybe also make c++ > `char8_t` map to this type? Yes, that

[Lldb-commits] [PATCH] D116005: [lldb] [Process/FreeBSDKernel] Introduce libkvm support

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb785877a95d: [lldb] [Process/FreeBSDKernel] Introduce libkvm support (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [lldb] fb78587 - [lldb] [Process/FreeBSDKernel] Introduce libkvm support

Author: Michał Górny Date: 2021-12-22T16:14:03+01:00 New Revision: fb785877a95d5d51e802df618b22187b624a2b23 URL: https://github.com/llvm/llvm-project/commit/fb785877a95d5d51e802df618b22187b624a2b23 DIFF: https://github.com/llvm/llvm-project/commit/fb785877a95d5d51e802df618b22187b624a2b23.diff

[Lldb-commits] [PATCH] D116165: [lldb] Make ProcessLauncherPosixFork (mostly) async-signal-safe

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I don't see anything obviously wrong here. I presume you've tested it, so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116165/new/ https:

[Lldb-commits] [PATCH] D116165: [lldb] Make ProcessLauncherPosixFork (mostly) async-signal-safe

labath created this revision. labath added reviewers: DavidSpickett, mgorny. Herald added a subscriber: krytarowski. labath requested review of this revision. Herald added a project: LLDB. Multithreaded applications using fork(2) need to be extra careful about what they do in the fork child. Witho

[Lldb-commits] [PATCH] D116005: [lldb] [Process/FreeBSDKernel] Introduce libkvm support

mgorny updated this revision to Diff 395850. mgorny marked an inline comment as done. mgorny added a comment. Implemented requested changed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116005/new/ https://reviews.llvm.org/D116005 Files: lldb/source/Plugins/Process/FreeBSDKernel/CMa

[Lldb-commits] [PATCH] D116005: [lldb] [Process/FreeBSDKernel] Introduce libkvm support

mgorny marked 3 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp:86 +#if defined(__FreeBSD__) +kvm_t *kvm = +kvm_open2(executable->GetFileSpec().GetPath().c_str(), l

[Lldb-commits] [PATCH] D116162: [lldb/python] Fix dangling Event and CommandReturnObject references

labath created this revision. labath added reviewers: JDevlieghere, mib. labath requested review of this revision. Herald added a project: LLDB. Unlike the rest of our SB objects, SBEvent and SBCommandReturnObject have the ability to hold non-owning pointers to their non-SB counterparts. This make

[Lldb-commits] [PATCH] D116028: [lldb] Use GetSupportedArchitectures on darwin platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7c48f3cd5eb: [lldb] Use GetSupportedArchitectures on darwin platforms (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116028/new/ https

[Lldb-commits] [lldb] e7c48f3 - [lldb] Use GetSupportedArchitectures on darwin platforms

Author: Pavel Labath Date: 2021-12-22T13:47:33+01:00 New Revision: e7c48f3cd5eb51b3bb9b928b3bde5da28da68e39 URL: https://github.com/llvm/llvm-project/commit/e7c48f3cd5eb51b3bb9b928b3bde5da28da68e39 DIFF: https://github.com/llvm/llvm-project/commit/e7c48f3cd5eb51b3bb9b928b3bde5da28da68e39.diff

[Lldb-commits] [PATCH] D116028: [lldb] Use GetSupportedArchitectures on darwin platforms

labath added a comment. Don't worry, there's still plenty of improvement opportunities around there. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116028/new/ https://reviews.llvm.org/D116028 ___ lldb

[Lldb-commits] [lldb] 2efc689 - [lldb/python] Avoid more dangling pointers in python glue code

Author: Pavel Labath Date: 2021-12-22T13:47:06+01:00 New Revision: 2efc6892d89dc15c1697c411e0031d126385a5f1 URL: https://github.com/llvm/llvm-project/commit/2efc6892d89dc15c1697c411e0031d126385a5f1 DIFF: https://github.com/llvm/llvm-project/commit/2efc6892d89dc15c1697c411e0031d126385a5f1.diff

[Lldb-commits] [PATCH] D115062: [LLDB][Clang] add AccessSpecDecl for methods and fields in RecordType

labath added a comment. This dropped off my radar, but i think it generally looks good. Shafik, do you have anything to add? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115062/new/ https://reviews.llvm.org/D115062 __

[Lldb-commits] [PATCH] D115308: [LLDB][DWARF] Fix duplicate TypeSP in type list

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Since you're simply removing code, I don't think that we need to insist on new test cases -- not breaking existing ones should suffice. That said, if you know of a way to test this via the `im

[Lldb-commits] [PATCH] D116005: [lldb] [Process/FreeBSDKernel] Introduce libkvm support

labath added a comment. Just a couple of quick comments. In D116005#3203077 , @mgorny wrote: > In D116005#3202721 , @labath wrote: > >> How about factoring the two implementations into subclasses. If the classes

[Lldb-commits] [PATCH] D112564: [lldb] Add support for UTF-8 unicode formatting

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine. Thanks for tracking this down. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112564/new/ https://reviews.llvm.org/D112564 ___

[Lldb-commits] [PATCH] D116136: [lldb] Add UTF-8 char basic type

labath added a comment. I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ `char8_t` map to this type? Comment at: lldb/include/lldb/lldb-enumerations.h:750 eBasicTypeUnsignedW

[Lldb-commits] [PATCH] D116094: Add support for a version 2 of "main bin spec" Mach-O LC_NOTE in corefiles, handle specifications with a slide value

This revision was automatically updated to reflect the committed changes. Closed by commit rG682532ca575b: Support v2 of 'main bin spec' Mach-O LC_NOTE in corefiles (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116094/new/

[Lldb-commits] [lldb] 682532c - Support v2 of 'main bin spec' Mach-O LC_NOTE in corefiles

Author: Jason Molenda Date: 2021-12-22T00:02:27-08:00 New Revision: 682532ca575b8b6c4d3e2104a7526743ff9446a9 URL: https://github.com/llvm/llvm-project/commit/682532ca575b8b6c4d3e2104a7526743ff9446a9 DIFF: https://github.com/llvm/llvm-project/commit/682532ca575b8b6c4d3e2104a7526743ff9446a9.diff