labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Since you're simply removing code, I don't think that we need to insist on new test cases -- not breaking existing ones should suffice. That said, if you know of a way to test this via the `image dump symfile` command, I would definitely encourage you to do so. And yes, we need to figure out what to do with lldb-test. Maybe we should just rewrite `ParseTypes` (used only in tests) to do the parsing in a different way... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115308/new/ https://reviews.llvm.org/D115308 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
