[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added a comment. In D115324#3198913 , @stella.stamenova wrote: > The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It > looks like the deletion of the executable is failing due to permissions and > other similar tests ar

[Lldb-commits] [lldb] 59f1d0e - Fix windows buildbots after https://reviews.llvm.org/D115324

Author: Greg Clayton Date: 2021-12-16T16:13:58-08:00 New Revision: 59f1d0eed58ce0f23c3a5a324d122a99f9757228 URL: https://github.com/llvm/llvm-project/commit/59f1d0eed58ce0f23c3a5a324d122a99f9757228 DIFF: https://github.com/llvm/llvm-project/commit/59f1d0eed58ce0f23c3a5a324d122a99f9757228.diff

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

stella.stamenova added a comment. The new test (TestModuleCacheSimple) is failing on the windows lldb bot. It looks like the deletion of the executable is failing due to permissions and other similar tests are skipped on windows for that reason. I haven't looked at the test in more detail to se

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. The substance is fine, you kept the common cases fast and then added fallback for the others with the regex. That test seems like an object lesson in what not to do in an inline test, but t

[Lldb-commits] [lldb] da816ca - Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

Author: Greg Clayton Date: 2021-12-16T09:59:55-08:00 New Revision: da816ca0cb3b1367fe90b3e6fb73439c93ed80df URL: https://github.com/llvm/llvm-project/commit/da816ca0cb3b1367fe90b3e6fb73439c93ed80df DIFF: https://github.com/llvm/llvm-project/commit/da816ca0cb3b1367fe90b3e6fb73439c93ed80df.diff

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda816ca0cb3b: Added the ability to cache the finalized symbol tables subsequent debug… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D115882: [lldb] Silence CMake warnings about missing FindFBSDVMCore

This revision was automatically updated to reflect the committed changes. Closed by commit rG209ec8e2eebb: [lldb] Silence CMake warnings about missing FindFBSDVMCore (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [lldb] 209ec8e - [lldb] Silence CMake warnings about missing FindFBSDVMCore

Author: Michał Górny Date: 2021-12-16T18:01:51+01:00 New Revision: 209ec8e2eebbd2612ed8f7ee394a6dc043624ab4 URL: https://github.com/llvm/llvm-project/commit/209ec8e2eebbd2612ed8f7ee394a6dc043624ab4 DIFF: https://github.com/llvm/llvm-project/commit/209ec8e2eebbd2612ed8f7ee394a6dc043624ab4.diff

[Lldb-commits] [PATCH] D115882: [lldb] Silence CMake warnings about missing FindFBSDVMCore

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Pass QUIET to find_package() in order to quiet the warning about missing FindFBSDVMCore.cmake. FBSDVMCore always provides native CMake config files, therefore providing a f

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath added a comment. @jingham, @shafik, do you see any issues with this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112709/new/ https://reviews.llvm.org/D112709 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG427f6e11e68a: [lldb][docs] Update instructions for building libc++ (authored by torarnv, committed by sylvestre.ledru). Repository: rG LLVM Github

[Lldb-commits] [lldb] 427f6e1 - [lldb][docs] Update instructions for building libc++

Author: Tor Arne Vestbø Date: 2021-12-16T16:50:42+01:00 New Revision: 427f6e11e68a2c57c12fe9049a939752d76860be URL: https://github.com/llvm/llvm-project/commit/427f6e11e68a2c57c12fe9049a939752d76860be DIFF: https://github.com/llvm/llvm-project/commit/427f6e11e68a2c57c12fe9049a939752d76860be.dif

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

torarnv added a comment. Thanks :) You can use `Tor Arne Vestbø ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115877/new/ https://reviews.llvm.org/D115877 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

sylvestre.ledru added a comment. I will push it for you. What do you want to use as full name + email ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115877/new/ https://reviews.llvm.org/D115877 ___ lldb

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

torarnv added a comment. Thanks! Do I do something now or does it land automatically? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115877/new/ https://reviews.llvm.org/D115877 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115877/new/ https://reviews.llvm.org/D115877

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

torarnv updated this revision to Diff 394869. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115877/new/ https://reviews.llvm.org/D115877 Files: lldb/docs/resources/build.rst Index: lldb/docs/resources/build.rst ==

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

torarnv added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/docs/resources/build.rst:307 -On macOS the LLDB test suite requires libc++. Either add ``libcxx`` to -``LLVM_ENABLE_PROJECTS`` or disable the test suite with +On macOS the LLDB test suite r

[Lldb-commits] [PATCH] D115877: [lldb][docs] Update instructions for building libc++

torarnv created this revision. torarnv added a reviewer: sylvestre.ledru. torarnv requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D115877 Files: lldb/docs/resources/build.rs

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. Polite ping to get this committed. I have rebased against main today and run the test, it still passes and the patch applies cleanly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D115736: [lldb] (Semi-automatically) format .swig files

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d5e37ed8c3d: [lldb] (Semi-automatically) format .swig files (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115736/new/ https://reviews

[Lldb-commits] [lldb] 9d5e37e - [lldb] (Semi-automatically) format .swig files

Author: Pavel Labath Date: 2021-12-16T13:58:37+01:00 New Revision: 9d5e37ed8c3d8124be7a4022868e961045c618d5 URL: https://github.com/llvm/llvm-project/commit/9d5e37ed8c3d8124be7a4022868e961045c618d5 DIFF: https://github.com/llvm/llvm-project/commit/9d5e37ed8c3d8124be7a4022868e961045c618d5.diff

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. > That looks really good, could help a lot to understand tagging related > issues. Looking forward for that patch :) https://reviews.llvm.org/D107140 is the end of the series for that if you want to see it. The test cases show various corner cases too. Repositor

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

danielkiss accepted this revision. danielkiss added a comment. In D103626#2824083 , @DavidSpickett wrote: >> Maybe this is something worth considering for LLDB memory dumps? > > I'm working on that at the moment, it's on my github branch. This is what it

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett updated this revision to Diff 394805. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add release note for this change. Closer to release I'll see if it makes more sense to make a list of commands that have had the same changes,

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. Since we're so close to the end of the year I'm going to give this more time and ping early next year in case of any more feedback. Though I'm feeling confident in the direction so far. While working on this I realised that the API calls should also remove the no

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

DavidSpickett updated this revision to Diff 394800. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added a release note for the feture of handling non-address bits in input. Including the change to the last memory region, which could conceivea

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

DavidSpickett updated this revision to Diff 394797. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added a release note for the new option/feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is in a pretty good shape now. Thanks for your patience. Comment at: lldb/source/Symbol/Symbol.cpp:649 +/// The only tricky thing in this encoding is encoding al