[Lldb-commits] [lldb] 1ab9a29 - [lldb] Fix C2360: initialization of 'identifier' is skipped by 'case' label

Author: Jonas Devlieghere Date: 2021-11-05T23:09:35-07:00 New Revision: 1ab9a2906e19cca87cafac25cc31231a36de4843 URL: https://github.com/llvm/llvm-project/commit/1ab9a2906e19cca87cafac25cc31231a36de4843 DIFF: https://github.com/llvm/llvm-project/commit/1ab9a2906e19cca87cafac25cc31231a36de4843.d

[Lldb-commits] [PATCH] D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd7a2bf94b69: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D113159?vs=384624

[Lldb-commits] [lldb] cd7a2bf - [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex

Author: Jonas Devlieghere Date: 2021-11-05T22:52:28-07:00 New Revision: cd7a2bf94b69e613ce64327839b831610c4eea14 URL: https://github.com/llvm/llvm-project/commit/cd7a2bf94b69e613ce64327839b831610c4eea14 DIFF: https://github.com/llvm/llvm-project/commit/cd7a2bf94b69e613ce64327839b831610c4eea14.d

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:316 +Declaration callsite(callsite_file, record->CallSiteLineNum); +block_sp->SetInlinedFunctionInfo(name.str().c_str(), nullptr, nullptr, +

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG05fbe758906e: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed p

[Lldb-commits] [lldb] ef2efd2 - [lldb] Remove 'result' variable which is set but not used (NFC)

Author: Jonas Devlieghere Date: 2021-11-05T21:12:00-07:00 New Revision: ef2efd2553e00bc98c73843da9792d90e4231d30 URL: https://github.com/llvm/llvm-project/commit/ef2efd2553e00bc98c73843da9792d90e4231d30 DIFF: https://github.com/llvm/llvm-project/commit/ef2efd2553e00bc98c73843da9792d90e4231d30.d

[Lldb-commits] [lldb] 05fbe75 - [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

Author: Jonas Devlieghere Date: 2021-11-05T21:12:00-07:00 New Revision: 05fbe758906ea27344391bd27817b19788bbce91 URL: https://github.com/llvm/llvm-project/commit/05fbe758906ea27344391bd27817b19788bbce91 DIFF: https://github.com/llvm/llvm-project/commit/05fbe758906ea27344391bd27817b19788bbce91.d

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Teach LLDB to understand INLINE and INLINE_ORIGIN records in breakpad.

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:558 +struct CompatibleArchs { + const char **archs = nullptr; labath wrote: > Is this any different from an `A

[Lldb-commits] [PATCH] D113314: [lldb] Use std::string instead of llvm::Twine

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG6d48e2505c7a: [lldb] Use std::string instead of llvm::Twine in GDBRemoteCommunicationClient (authored by JDevlieghere). Herald added a project: LLDB. Changed

[Lldb-commits] [lldb] 10eb32f - [lldb] Improve 'lang objc tagged-pointer info' command

Author: Jonas Devlieghere Date: 2021-11-05T13:19:00-07:00 New Revision: 10eb32f45d40e180a229590f57dd0a61f97f1bc9 URL: https://github.com/llvm/llvm-project/commit/10eb32f45d40e180a229590f57dd0a61f97f1bc9 DIFF: https://github.com/llvm/llvm-project/commit/10eb32f45d40e180a229590f57dd0a61f97f1bc9.d

[Lldb-commits] [lldb] 6d48e25 - [lldb] Use std::string instead of llvm::Twine in GDBRemoteCommunicationClient

Author: Jonas Devlieghere Date: 2021-11-05T13:19:00-07:00 New Revision: 6d48e2505c7a68a470e75b61ad504d51db0f8a36 URL: https://github.com/llvm/llvm-project/commit/6d48e2505c7a68a470e75b61ad504d51db0f8a36 DIFF: https://github.com/llvm/llvm-project/commit/6d48e2505c7a68a470e75b61ad504d51db0f8a36.d

[Lldb-commits] [PATCH] D113314: [lldb] Use std::string instead of llvm::Twine

JDevlieghere marked an inline comment as done. JDevlieghere added a subscriber: david. JDevlieghere added a comment. @David: Yes, I considered it, but I think this is slightly more readable. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:11

[Lldb-commits] [PATCH] D113314: [lldb] Use std::string instead of llvm::Twine

mgorny accepted this revision. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1113 +std::string packet = +"QEnableCompression:type:" + std::string(avail_name) + ";"; +if (SendPacketAndWaitForRespo

[Lldb-commits] [PATCH] D113314: [lldb] Use std::string instead of llvm::Twine

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me. Alternatively the string concatenation could be inlined, then the Twine usage would be correct - but would still need an explicit "str()", like this: SendPacketAndWait

[Lldb-commits] [PATCH] D113314: [lldb] Use std::string instead of llvm::Twine

JDevlieghere created this revision. JDevlieghere added a reviewer: mgorny. JDevlieghere requested review of this revision. >From the documentation: > A Twine is not intended for use directly and should not be stored, its > implementation relies on the ability to store pointers to temporary stack

[Lldb-commits] [PATCH] D113255: [lldb] Use is_style_posix() for path style checks

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c9cf4c7697: [lldb] Use is_style_posix() for path style checks (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113255/new/ https://re

[Lldb-commits] [lldb] a2c9cf4 - [lldb] Use is_style_posix() for path style checks

Author: Martin Storsjö Date: 2021-11-05T21:50:45+02:00 New Revision: a2c9cf4c76974086a206c86a172085162a57de9b URL: https://github.com/llvm/llvm-project/commit/a2c9cf4c76974086a206c86a172085162a57de9b DIFF: https://github.com/llvm/llvm-project/commit/a2c9cf4c76974086a206c86a172085162a57de9b.diff

[Lldb-commits] [PATCH] D113174: [lldb] Summary provider for char flexible array members

shafik added a comment. In D113174#3109664 , @jingham wrote: > Regex Type summary matching happens after the ConstString matching. Enrico > did it that way because the ConstString matching is so much quicker, so if we > can find a match there we'll get

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu updated this revision to Diff 385109. zequanwu added a comment. Add FindFunctions. Remove the loop that adds FUNC to symtab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 Files: lldb/source/P

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392 for (llvm::StringRef line : lines(Record::Func)) { if (auto record = FuncRecord::parse(line)) add_symbol(record->Address, record->Size, record->Name);

[Lldb-commits] [PATCH] D113255: [lldb] Use is_style_posix() for path style checks

mstorsjo created this revision. mstorsjo added reviewers: labath, dexonsmith. mstorsjo requested review of this revision. Herald added a project: LLDB. Since a8b54834a186f5570b49b614e31b961a9cf1cbfe , there are two distinct Win