[Lldb-commits] [PATCH] D107407: [rfc] target stats

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:302-305 + virtual llvm::Optional> GetSymbolLoadingTime() { +return llvm::None; + } + --

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Expression/IRExecutionUnit.cpp:785 + auto get_external_load_address = + [target, &symbol_was_missing_weak]( + lldb::addr_t &load_address, lldb::addr_t &best_i

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

JDevlieghere updated this revision to Diff 363908. JDevlieghere added a comment. Convert lambda into a stateful class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107206/new/ https://reviews.llvm.org/D107206 Files: lldb/source/Expression/IRExecutionUnit.cpp Index: lldb/source/Expr

[Lldb-commits] [PATCH] D107407: [rfc] target stats

wallace created this revision. wallace added reviewers: clayborg, jingham. Herald added subscribers: dang, arphaman, mgorny. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D45547 added a while ago

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9139acb85a4: Fix expression evaluation result expansion in lldb-v

[Lldb-commits] [lldb] b9139ac - Fix expression evaluation result expansion in lldb-vscode

Author: Jeffrey Tan Date: 2021-08-03T15:24:44-07:00 New Revision: b9139acb85a4e5203364838e47b2e1ee90055ad3 URL: https://github.com/llvm/llvm-project/commit/b9139acb85a4e5203364838e47b2e1ee90055ad3 DIFF: https://github.com/llvm/llvm-project/commit/b9139acb85a4e5203364838e47b2e1ee90055ad3.diff L

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

jj10306 added a comment. In D105741#2920588 , @vsk wrote: > Hey @jj10306, thanks for working on this. > > @wallace @clayborg -- It seems like there are a ton of logic changes > introduced in this patch that are tested at too coarse a level. I'm not > co

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

JDevlieghere updated this revision to Diff 363887. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107295/new/ https://reviews.llvm.org/D107295 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Core/ModuleList.h lldb/source/API/SBModule.cpp lldb/source/API/SBTarget.cpp lld

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf3383501fef: [lldb] Get rid of HAVE_SYS_TYPES_H (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107338/new/ https://reviews.llvm.org/D1

[Lldb-commits] [lldb] bf33835 - [lldb] Get rid of HAVE_SYS_TYPES_H

Author: Nico Weber Date: 2021-08-03T22:14:56+02:00 New Revision: bf3383501fefc6cfe0d8f313a2814f7fa34d4492 URL: https://github.com/llvm/llvm-project/commit/bf3383501fefc6cfe0d8f313a2814f7fa34d4492 DIFF: https://github.com/llvm/llvm-project/commit/bf3383501fefc6cfe0d8f313a2814f7fa34d4492.diff LO

[Lldb-commits] [PATCH] D107341: [lldb] Move comment about noindex next to line it refers to

This revision was automatically updated to reflect the committed changes. Closed by commit rG4367cbab4cf2: [lldb] Move comment about noindex next to line it refers to (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107341/new/ ht

[Lldb-commits] [lldb] 4367cba - [lldb] Move comment about noindex next to line it refers to

Author: Nico Weber Date: 2021-08-03T22:14:12+02:00 New Revision: 4367cbab4cf2cbf8f81a24bdcc2dc0612b932aa5 URL: https://github.com/llvm/llvm-project/commit/4367cbab4cf2cbf8f81a24bdcc2dc0612b932aa5 DIFF: https://github.com/llvm/llvm-project/commit/4367cbab4cf2cbf8f81a24bdcc2dc0612b932aa5.diff LO

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

g and disabling breakpoints. Since the window doesn't delegate key handing to the items, this will have to be implemented first. F18327498: 20210803-28.png <https://reviews.llvm.org/F18327498> F18327497: 20210803-211059.png <https://reviews.llvm.org/F18327497> Reposi

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a breakpoints window that lists all breakpoints an

[Lldb-commits] [lldb] d2b2ab4 - [lldb] Further constrain a test that fails without python enabled

Author: Alex Langford Date: 2021-08-03T11:50:36-07:00 New Revision: d2b2ab4e1c347161b622b9dc2553de04f9f82f04 URL: https://github.com/llvm/llvm-project/commit/d2b2ab4e1c347161b622b9dc2553de04f9f82f04 DIFF: https://github.com/llvm/llvm-project/commit/d2b2ab4e1c347161b622b9dc2553de04f9f82f04.diff

[Lldb-commits] [PATCH] D106466: [llvm+lldb] 2/2: Fix#2 of DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

ikudrin added a comment. As far as I understand it, you need a specially constructed `llvm::DWARFDebugRnglistTable` object so that `DWARFUnit::FindRnglistFromOffset()` can call its `findList()` method and get a list of records located at a specific offset. It looks like a newly created `llvm::

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

compnerd added inline comments. Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html" +set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/${project}

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a3bf2953a92: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor)… (authored by akhuang). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. yep, should be good now - I'll commit it soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

MaskRay added a comment. I remember that we even converted some `*.md` to `*.rst` to remove the number of supported documentation formats, so I agree that adding support the even less used `*.docx` may not be the proper direction. Thanks for splitting this off. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie accepted this revision. dblaikie added a comment. Sounds like this is good for Google and Sony, and Apple doesn't use `-fno-standalone-debug`/`-flimit-debug-info` anyway, so probably about ready to move forward, then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

t-tye added a comment. In D106339#2890258 , @ldionne wrote: > What's the benefit of having docx documentation? We generate HTML > documentation, which ends up in the website, and that seems strictly superior > to generating docx. What do you need it for

[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

t-tye updated this revision to Diff 361407. t-tye added a comment. Factor out documentation and CMake file changes unrelated to adding DOCX support to D106736 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106339/

[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

t-tye updated this revision to Diff 361402. t-tye added a comment. Split change for clang makefile to elimnate Sphinx warnings of missing .rst fies when building man pages into D106734 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie added a comment. In D106084#2897515 , @jmorse wrote: > David wrote: > >> think what I'm missing here: If -fno-standalone-debug is already in use/the >> default and is causing missing types because parts of the program are bulit >> without debug

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. In D106084#2897515 , @jmorse wrote: > David wrote: > >> think what I'm missing here: If -fno-standalone-debug is already in use/the >> default and is causing missing types because parts of the program are bulit >> without debug

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang updated this revision to Diff 360918. akhuang added a comment. Remove fno-use-ctor-homing flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 Files: clang/include/clang/Basic/DebugInfoOptions.h

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse added a comment. David wrote: > think what I'm missing here: If -fno-standalone-debug is already in use/the > default and is causing missing types because parts of the program are bulit > without debug info, then I'm not sure what the rationale is for slicing > -fstandalone-debug into a

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1636 +if (Opts.getDebugInfo() == codegenoptions::DebugInfoConstructor) + Opts.setDebugInfo(codegenoptions::LimitedDebugInfo); probinson wrote: > No... you want to chec

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

probinson added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1636 +if (Opts.getDebugInfo() == codegenoptions::DebugInfoConstructor) + Opts.setDebugInfo(codegenoptions::LimitedDebugInfo); No... you want to check both options in

[Lldb-commits] [PATCH] D107341: [lldb] Move comment about noindex next to line it refers to

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks, lgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107341/new/ https://reviews.llvm.org/D107341 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D107341: [lldb] Move comment about noindex next to line it refers to

thakis created this revision. thakis added a reviewer: JDevlieghere. thakis added a project: LLDB. Herald added subscribers: arphaman, mgorny. thakis requested review of this revision. The comment was originally added in 34769d80d. Then D44526 removed the flag ad

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks! This LGTM itself, but I would prefer if we could remove that define in this commit and remove the redundant Config.h includes in another (so, the first version of this patch LGTM

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

thakis added a comment. In LLVM, this was removed in 37f69de11b8c1810e29851430da317db5c1350a9. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107338/new/ https://reviews.llvm.org/D107338 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

thakis updated this revision to Diff 363685. thakis added a comment. Remove Config.h include from driver/Platform.h. Platform.h only gets included in 5 files, and I checked that none of those need Config.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107338/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

thakis created this revision. thakis added a reviewer: JDevlieghere. thakis added a project: LLDB. Herald added a subscriber: mgorny. thakis requested review of this revision. LLVM includes this header unconditionally on all platforms (including Windows), so this define should no longer be necessa

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

foad added inline comments. Comment at: lldb/docs/htr.rst:13 + + **Instruction Layer:** Composed of the oad addresses of the instructions in the trace. In an effort to save space, + metadata is only stored for instructions that are of interest, not every instruction in the tra