akhuang added inline comments.
================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1636 + if (Opts.getDebugInfo() == codegenoptions::DebugInfoConstructor) + Opts.setDebugInfo(codegenoptions::LimitedDebugInfo); ---------------- probinson wrote: > No... you want to check both options in one call, otherwise > `-fno-use-ctor-homing -fuse-ctor-homing` will prefer the `no` version instead > of last-one-wins. > > I suggest fiddling the options should be done separately. > Also if you want to make it a clang option, the option name should have > `debug` in it; pretty sure all the -f options related to debug info do that, > and in any case it's a good idea. ah, right. I'll move this to a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
