[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid created this revision. nealsid added a reviewer: LLDB. nealsid added a project: LLDB. Herald added subscribers: JDevlieghere, mgorny. nealsid requested review of this revision. Herald added a subscriber: lldb-commits. This change moves to using narrow character types and libedit APIs, beca

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace dump ctf -f ` command

jj10306 marked 6 inline comments as done. jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:3 +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. clayborg wrote: > Maybe add a definition

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:402-403 case DW_AT_type: - type = form_value; + if (!type.IsValid()) +type = form_value; break; JDevlieghere wrote: > What's the p

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

omjavaid added a comment. In D105630#2876615 , @DavidSpickett wrote: > All the follow ups are now based on this change. I didn't need to make an > updates to this particular patch after all. This looks good but the test fails on arm 32 bit.

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 358773. shafik marked 8 inline comments as done. shafik added a comment. - Removed virtual from `FindTypeForAutoReturnForDIE` - Added missing nullptr checks - Modernized the code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/ https://revie

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2425 +return true; + } + clayborg wrote: > Should be easy to verify if it is needed or not. If it is, we will need to > add it back. Looks like it is actually needed. I

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358766. OmarEmaraDev marked an inline comment as done. OmarEmaraDev added a comment. - Manually continue if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105655/new/ https://reviews.llvm.org/D10565

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace dump ctf -f ` command

wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:29 +/// Metadata is initially populated in Layer 1 and merged as blocks are merged +class HTRBlockMetadata { +public: This is a very expensive structure if you are going to have for La

[Lldb-commits] [PATCH] D105914: [lldb] Make TargetList iterable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde448c0a9e50: [lldb] Make TargetList iterable (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D106004: [lldb] Always call DestroyImpl from Process::Finalize

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4a417ee639: [lldb] Always call DestroyImpl from Process::Finalize (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] de448c0 - [lldb] Make TargetList iterable (NFC)

Author: Jonas Devlieghere Date: 2021-07-14T13:35:54-07:00 New Revision: de448c0a9e5088979526e2e67152fe547ae4ccf0 URL: https://github.com/llvm/llvm-project/commit/de448c0a9e5088979526e2e67152fe547ae4ccf0 DIFF: https://github.com/llvm/llvm-project/commit/de448c0a9e5088979526e2e67152fe547ae4ccf0.d

[Lldb-commits] [lldb] 1e4a417 - [lldb] Always call DestroyImpl from Process::Finalize

Author: Jonas Devlieghere Date: 2021-07-14T13:35:53-07:00 New Revision: 1e4a417ee639b867b783e52949d22c1965ab25d0 URL: https://github.com/llvm/llvm-project/commit/1e4a417ee639b867b783e52949d22c1965ab25d0 DIFF: https://github.com/llvm/llvm-project/commit/1e4a417ee639b867b783e52949d22c1965ab25d0.d

[Lldb-commits] [PATCH] D105914: [lldb] Make TargetList iterable

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM, these Iterables make the code so much easier to read. Plus, though it's highly unlikely to happen, we shouldn't let another thread muck with the target list while we're Destroying its

[Lldb-commits] [PATCH] D105914: [lldb] Make TargetList iterable

JDevlieghere updated this revision to Diff 358720. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105914/new/ https://reviews.llvm.org/D105914 Files: lldb/include/lldb/Target/TargetList.h lldb/source/Core/Debugger.cpp Index: lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D106004: [lldb] Always call DestroyImpl from Process::Finalize

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This seems better to me. It's a little odd that the Process was short-cutting DoDestroy for these states. How can it know that one of the plugins might not need to handle that case? As a

[Lldb-commits] [PATCH] D106004: [lldb] Always call DestroyImpl from Process::Finalize

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. JDevlieghere requested review of this revision. Always destroy the process, regardless of its private state. This will call the virtual function DoDestroy under the hood, giving our derived class a chance to do the neces

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:5504-5513 + WatchpointList &wps = GetTarget().GetWatchpointList(); + size_t wp_count = wps.GetSize(); + for (size_t i = 0; i < wp_count; ++i) { +WatchpointSP wp = w

[Lldb-commits] [PATCH] D105998: Create synthetic symbol names on demand to improve memory consumption and startup times.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Greg! Assuming this passes on the bot this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105998/new/ https://reviews.ll

[Lldb-commits] [PATCH] D105998: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/Symbol.h:158 + bool IsSyntheticWithAutoGeneratedName() const; + @JDevlieghere this was added to fix the failing tests that caused some bots to fail. Prior to this we were not adding any synt

[Lldb-commits] [PATCH] D105998: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg created this revision. clayborg added reviewers: JDevlieghere, wallace. Herald added subscribers: kristof.beyls, emaste. clayborg requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: LLDB. This is a resubmission of https://reviews.llvm.org/D105160

[Lldb-commits] [PATCH] D103744: [lldb][docs] Remove mention of subversion. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7d931ac373f: [lldb][docs] Remove mention of subversion. NFC. (authored by brucem, committed by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] f7d931a - [lldb][docs] Remove mention of subversion. NFC.

Author: Bruce Mitchener Date: 2021-07-14T11:04:07Z New Revision: f7d931ac373fc23f5f4493300ecf7f3fe08b9d67 URL: https://github.com/llvm/llvm-project/commit/f7d931ac373fc23f5f4493300ecf7f3fe08b9d67 DIFF: https://github.com/llvm/llvm-project/commit/f7d931ac373fc23f5f4493300ecf7f3fe08b9d67.diff LO

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

DavidSpickett added a comment. > I am trying to run test_qmemtags_packets but the test hangs while waiting for > lldb-server to terminate. Do you have any more detail than that? I presume it runs the test then hangs during the cleanup. Without this patch do you see the same thing? I'm using Ke

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

DavidSpickett added a comment. All the follow ups are now based on this change. I didn't need to make an updates to this particular patch after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105630/new/ https://reviews.llvm.org/D105630 __

[Lldb-commits] [PATCH] D105183: [lldb] Add "memory tag write" --end-addr option

DavidSpickett updated this revision to Diff 358546. DavidSpickett added a comment. Rebase after refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105183/new/ https://reviews.llvm.org/D105183 Files: lldb/source/Commands/CommandObjectMemo

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

DavidSpickett updated this revision to Diff 358544. DavidSpickett added a comment. Now that ranges are handled in the tag manager, the command uses MakeTaggedRange. With some extra steps to get slightly different alignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

DavidSpickett updated this revision to Diff 358541. DavidSpickett added a comment. Rebase onto the earlier refactoring patch. Now GetMemoryTagManager just deals with the manager, no range handling. So this patch just adds WriteMemoryTags. "memory tag write" will use MakeTaggedRange from the memo

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

DavidSpickett updated this revision to Diff 358539. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105180/new/ https://reviews.llvm.org/D105180 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h l

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1517 + + llvm::Expected> repeated_tags_or_err = + details->manager->RepeatTagsForRange(*unpacked_tags_or_err, range); omjavaid wrote: > We unpack, repe