clayborg added inline comments.
================
Comment at: lldb/include/lldb/Symbol/Symbol.h:158
+ bool IsSyntheticWithAutoGeneratedName() const;
+
----------------
@JDevlieghere this was added to fix the failing tests that caused some bots to
fail. Prior to this we were not adding any synthetic symbols to the name lookup
tables, even if they didn't have names that started with
"___lldb_unnamed_symbol"
================
Comment at: lldb/source/Symbol/Symtab.cpp:306
+ // name lookups.
+ if (symbol->IsTrampoline() || symbol->IsSyntheticWithAutoGeneratedName())
continue;
----------------
@JDevlieghere this was added to fix the failing tests that caused some bots to
fail. Prior to this we were not adding any synthetic symbols to the name lookup
tables, even if they didn't have names that started with
"___lldb_unnamed_symbol". This code used to be:
```
if (symbol->IsTrampoline() || symbol->IsSynthetic())
```
And it would leave out synthetic symbols with valid names, like form the dyld
trie
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105998/new/
https://reviews.llvm.org/D105998
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
