[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d891d44f33f: [WebAssembly] Rename event to tag (authored by aheejin). Changed prior to commit: https://reviews.llvm.org/D104423?vs=352903&id=3529

[Lldb-commits] [lldb] 1d891d4 - [WebAssembly] Rename event to tag

Author: Heejin Ahn Date: 2021-06-17T20:34:19-07:00 New Revision: 1d891d44f33f99c55e779acaeac4628e4ac9aaaf URL: https://github.com/llvm/llvm-project/commit/1d891d44f33f99c55e779acaeac4628e4ac9aaaf DIFF: https://github.com/llvm/llvm-project/commit/1d891d44f33f99c55e779acaeac4628e4ac9aaaf.diff LO

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin updated this revision to Diff 352903. aheejin edited the summary of this revision. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423 Files: lld/include/ll

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace updated this revision to Diff 352872. wallace marked 2 inline comments as done. wallace added a comment. Herald added a subscriber: mgorny. address comments: - now simply pointing to the last instruction of the trace by default - removed the GetInstructionSize, as it's really not needed -

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace marked 11 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:39-40 +/// +/// The Trace initially points to a dummy invalid instruction error signaling +/// the end of a trace, similar to a C++ collections' end iter

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

wallace added a comment. lgtm I wonder if it's lldb's style to rename m_mangled to m_mangled_do_not_use (or something like that) to prevent people from using it in the future. Comment at: lldb/source/Symbol/Symtab.cpp:625 + // with a prefix and end with a the symbol UserID,

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf9f21a28be1: [trace][intel-pt] Create basic SB API (authored by W

[Lldb-commits] [lldb] bf9f21a - [trace][intel-pt] Create basic SB API

Author: Walter Erquinigo Date: 2021-06-17T15:14:47-07:00 New Revision: bf9f21a28be171dc500cc68b4cb1fcd3fc33f229 URL: https://github.com/llvm/llvm-project/commit/bf9f21a28be171dc500cc68b4cb1fcd3fc33f229 DIFF: https://github.com/llvm/llvm-project/commit/bf9f21a28be171dc500cc68b4cb1fcd3fc33f229.di

[Lldb-commits] [lldb] c1360fd - [lldb-vscode] remove failed test

Author: Walter Erquinigo Date: 2021-06-17T15:13:16-07:00 New Revision: c1360fd5fced42ea45ce1eacbf1c5e1ed54fcac5 URL: https://github.com/llvm/llvm-project/commit/c1360fd5fced42ea45ce1eacbf1c5e1ed54fcac5 DIFF: https://github.com/llvm/llvm-project/commit/c1360fd5fced42ea45ce1eacbf1c5e1ed54fcac5.di

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere, jingham, wallace. Herald added subscribers: kristof.beyls, emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. This fix was create

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

clayborg accepted this revision. clayborg added a comment. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103500/new/ https://reviews.llvm.org/D103500 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

wallace updated this revision to Diff 352835. wallace marked 2 inline comments as done. wallace added a comment. address comments: - use llvm::ArrayRef where needed - improved documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103500/new/

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid added a comment. Ah, my grep/find skills clearly failed me :) Yeah, those tests are exactly the same scenarios. However, if I understand correctly, don't they use the API? I wanted to add some coverage for the shell because I'm making changes to the Editline wrapper, and the existing t

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4685c0fb3a: [lldb-vscode] only report long running progress events (authored by wallace, committed by Walter Erquinigo ). Reposit

[Lldb-commits] [lldb] aa4685c - [lldb-vscode] only report long running progress events

Author: Walter Erquinigo Date: 2021-06-17T12:01:27-07:00 New Revision: aa4685c0fb3aab5acb90be5fd3eb5ba8bf1e3211 URL: https://github.com/llvm/llvm-project/commit/aa4685c0fb3aab5acb90be5fd3eb5ba8bf1e3211 DIFF: https://github.com/llvm/llvm-project/commit/aa4685c0fb3aab5acb90be5fd3eb5ba8bf1e3211.di

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 352778. OmarEmaraDev added a comment. - Always scroll left on removing a character Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395 Files: lldb/source/Core/IOHa

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

dblaikie added a comment. This might be a case of an overly reduced patch - this patch alone I'd expect to be observable in some way, and tested. If the "instring.empty()" condition never fires, then I'd expect to change that to an assert, rather than changing the semantics of it in an unobserv

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1108 + window.AttributeOn(A_REVERSE); +window.PutChar(m_content ? 'X' : ' '); +if (is_active) clayborg wrote: > We could use ACS_DIAMOND or ACS_BULLET? Check it o

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 352761. OmarEmaraDev added a comment. - Remove PutCStringTruncatedWidth, use a character limit instead. - Handle review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 352741. DavidSpickett added a comment. Rebase. Remove `result.SetStatus(eReturnStatusFailed)` which is now implicitly done when you add an error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97285/new/ h

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 352739. DavidSpickett added a comment. Rebase, now ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https://reviews.llvm.org/D95602 Files: lldb/include/lldb/Core/Architecture.h

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 352736. DavidSpickett added a comment. Rebase, this is now ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 Files: lldb/include/lldb/Host/common/N

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

DavidSpickett updated this revision to Diff 352722. DavidSpickett added a comment. Rebase, this is good to land as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97282/new/ https://reviews.llvm.org/D97282 Files: lldb/include/lldb/Host/common/

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett added a comment. @omjavaid As it stands, RemoveNonAddressBits here removes the top byte unconditionally. You asked for pointer signatures to be removed as well, which would be neatly solved by using the ABI plugin. Ok to land this as is, then write a follow up to migrate to using

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett updated this revision to Diff 352720. DavidSpickett added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/new/ https://reviews.llvm.org/D97281 Files: lldb/include/lldb/Target/MemoryTagManager.h ll

[Lldb-commits] [PATCH] D104448: [lldb] Remove redundant calls to set eReturnStatusFailed

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM now, just a small nit about the redundant "error: " string. Comment at: lldb/source/Commands/CommandObjectWatchpoint.cpp:879 if (command.GetArgumentCount() <=

[Lldb-commits] [PATCH] D104448: [lldb] Remove redundant calls to set eReturnStatusFailed

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. There are two places where this isn't redundant (see inline comments) but otherwise this LGTM. Thanks! Comment at: lldb/source/Commands/CommandObjectWatchpoi

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a580f3c28cf: [lldb] Remove redundant calls to set eReturnStatusFailed (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104379/new/

[Lldb-commits] [lldb] 7a580f3 - [lldb] Remove redundant calls to set eReturnStatusFailed

Author: David Spickett Date: 2021-06-17T12:21:54+01:00 New Revision: 7a580f3c28cf47a7e489faa1fc1ab7b88d9a5dbd URL: https://github.com/llvm/llvm-project/commit/7a580f3c28cf47a7e489faa1fc1ab7b88d9a5dbd DIFF: https://github.com/llvm/llvm-project/commit/7a580f3c28cf47a7e489faa1fc1ab7b88d9a5dbd.diff

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG983ed1b58ef9: [lldb] Set return object failed status even if error string is empty (authored by DavidSpickett). Repository: rG LLVM Github Monorep

[Lldb-commits] [lldb] 983ed1b - [lldb] Set return object failed status even if error string is empty

Author: David Spickett Date: 2021-06-17T12:20:52+01:00 New Revision: 983ed1b58ef9d0f97c9cec2876f631e47609d437 URL: https://github.com/llvm/llvm-project/commit/983ed1b58ef9d0f97c9cec2876f631e47609d437 DIFF: https://github.com/llvm/llvm-project/commit/983ed1b58ef9d0f97c9cec2876f631e47609d437.diff

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. > did you consider implementing each field as a Window? My first implementation was actually done completely with fields as sub windows. However, two things deterred me from taking that approach. - While sub-windows in ncurses are mostly sub-spaces with their own lo

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

teemperor added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.h:117 +// (CU, (DIE)nullptr) == (nullptr, nullptr) -> true +if (!m_die.IsValid() && !it.m_die.IsValid()) + return true; shafik wrote: > I think: > > ``` > boo

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

teemperor updated this revision to Diff 352666. teemperor added a comment. Herald added a subscriber: mgorny. - Added a unit test (thanks Shafik!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103172/new/ https://reviews.llvm.org/D103172 Files: lldb/source/Plugins/SymbolFile/DWARF/DW

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

DavidSpickett added a comment. I am going to go over them this afternoon. I'm about to land some lldb patches that allow some easy refactoring, and your ABI patch might be useable too. If using the ABI method is better as a follow up then we can get started landing them. Repository: rG LLVM

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid added a comment. @DavidSpickett Do you have any further plans for this and other patches in the series. I was wondering if there is nothing to add we can go ahead and merge this series. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett added a comment. > Maybe this is something worth considering for LLDB memory dumps? I'm working on that at the moment, it's on my github branch. This is what it looks like with the right options: (others look weird at the moment due to ordering issues) (lldb) memory read mte_bu

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for writing tests, it's really appreciated! FWIW, I think that you can just check in new tests without having to go through a full review (unless you do want feedback fo

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added inline comments. Comment at: lldb/source/Target/Process.cpp:5854 + if (auto abi = GetABI()) { +// TODO: can we always assume data addresses here? +load_addr = abi->FixDataAddress(load_addr); omjavaid wrote: > Yes this is ok for now as

[Lldb-commits] [lldb] 25fa678 - [lldb] Skip variant/optional libc++ tests for Clang 5/6

Author: Raphael Isemann Date: 2021-06-17T09:52:09+02:00 New Revision: 25fa67868b36c99d2704bd291b3b495737f16f0e URL: https://github.com/llvm/llvm-project/commit/25fa67868b36c99d2704bd291b3b495737f16f0e DIFF: https://github.com/llvm/llvm-project/commit/25fa67868b36c99d2704bd291b3b495737f16f0e.dif