[Lldb-commits] [lldb] 732534e - [lldb] s/TARGET_OS_EMBEDDED/TARGET_OS_IPHONE/

Author: Jonas Devlieghere Date: 2021-02-11T20:40:59-08:00 New Revision: 732534ed64284b7ec6dde98e7b0ff779fce6b3d4 URL: https://github.com/llvm/llvm-project/commit/732534ed64284b7ec6dde98e7b0ff779fce6b3d4 DIFF: https://github.com/llvm/llvm-project/commit/732534ed64284b7ec6dde98e7b0ff779fce6b3d4.d

[Lldb-commits] [lldb] 4d3a061 - [lldb] Fix 'r' and 'run' aliases on Apple Silicon

Author: Jonas Devlieghere Date: 2021-02-11T20:23:53-08:00 New Revision: 4d3a061c32ee5c4fb88be389a4dd7fd71fc9fa9c URL: https://github.com/llvm/llvm-project/commit/4d3a061c32ee5c4fb88be389a4dd7fd71fc9fa9c DIFF: https://github.com/llvm/llvm-project/commit/4d3a061c32ee5c4fb88be389a4dd7fd71fc9fa9c.d

[Lldb-commits] [PATCH] D96549: Support dereferencing a DWARF scalar stack value

JDevlieghere added a comment. I think this makes sense. From a DWARF perspective this is sound, all the standard says is that the popped value must have an integral type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96549/new/ https://reviews.llvm.org/D96549 _

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

shafik added inline comments. Comment at: lldb/source/Core/Value.cpp:321 + case ValueType::Invalid: +break; + case ValueType::Scalar: { Would it make sense to also do an `error.SetErrorString(...`? Comment at: lldb/source/Core/Value.cpp:

[Lldb-commits] [PATCH] D96549: Support dereferencing a DWARF scalar stack value

vsk added a comment. The logic change seems reasonable to me. Any chance we can provide a mock memory in the DwarfExpression unit test, or check in assembly for a program that uses such an entry value expression? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96549/new/ https://reviews

[Lldb-commits] [PATCH] D96558: [lldb] [Process/FreeBSDRemote] Ensure that errors are always handled

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Ensure that the llvm::Error instances are always considered handled by moving the respective code out of LLDB_LOG. Apparently the latter may result in the error not being p

[Lldb-commits] [PATCH] D96557: [lldb] Rename FreeBSDRemote to FreeBSD (NFC)

mgorny created this revision. mgorny added reviewers: emaste, krytarowski, labath. Herald added subscribers: atanasyan, nemanjai. mgorny requested review of this revision. https://reviews.llvm.org/D96557 Files: lldb/source/Plugins/Process/CMakeLists.txt lldb/source/Plugins/Process/FreeBSD/CMa

[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

mgorny added a comment. @labath, any clue if I'm missing some no-longer-necessary code? I feel like I was supposed to also remove something responsible for launching/attaching processes in the old mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96555/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

aprantl updated this revision to Diff 323176. aprantl added a comment. Upload the correct patch this time!? Hopefully? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96537/new/ https://reviews.llvm.org/D96537 Files: lldb/include/lldb/Core/Value.h lldb/include/lldb/Expression/Express

[Lldb-commits] [PATCH] D93438: ObjectFileELF: Test whether reloc_header is non-null instead of asserting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc314f5ede824: ObjectFileELF: Test whether reloc_header is non-null instead of asserting. (authored by pcc). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [lldb] c314f5e - ObjectFileELF: Test whether reloc_header is non-null instead of asserting.

Author: Peter Collingbourne Date: 2021-02-11T15:05:18-08:00 New Revision: c314f5ede8249ef20fff1de45c2c31156b1950d4 URL: https://github.com/llvm/llvm-project/commit/c314f5ede8249ef20fff1de45c2c31156b1950d4 DIFF: https://github.com/llvm/llvm-project/commit/c314f5ede8249ef20fff1de45c2c31156b1950d4

[Lldb-commits] [PATCH] D96539: [lldb] Add step target to ThreadPlanStepInRange constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5ab1dc4ad2c: [lldb] Add step target to ThreadPlanStepInRange constructor (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] a5ab1dc - [lldb] Add step target to ThreadPlanStepInRange constructor

Author: Dave Lee Date: 2021-02-11T14:57:20-08:00 New Revision: a5ab1dc4ad2c02510e363b4dd3c267f9eaf11516 URL: https://github.com/llvm/llvm-project/commit/a5ab1dc4ad2c02510e363b4dd3c267f9eaf11516 DIFF: https://github.com/llvm/llvm-project/commit/a5ab1dc4ad2c02510e363b4dd3c267f9eaf11516.diff LOG:

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

jgorbe updated this revision to Diff 323166. jgorbe added a comment. Moved index handling to DWARFUnit.cpp as suggested by Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96194/new/ https://reviews.llvm.org/D96194 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp

[Lldb-commits] [PATCH] D96539: [lldb] Add step target to ThreadPlanStepInRange constructor

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I must have thought there would be a case where you wouldn't be able to figure out the target right when you made the plan, but since that possibility never arose, this simplification is fin

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support [WIP]

mgorny updated this revision to Diff 323150. mgorny added a comment. Move `NumSupportedHardwareBreakpoints` and `NumSupportedHardwareWatchpoints` into the shared code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96548/new/ https://reviews.llvm.org/D96548 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D96550: Fix LLDB_LOG calls to use correct formatting

shafik created this revision. shafik added a reviewer: teemperor. shafik requested review of this revision. It looks like a previous change switched these from `LLDB_LOGF` but did not update the format strings. https://reviews.llvm.org/D96550 Files: lldb/source/Plugins/ExpressionParser/Clang

[Lldb-commits] [PATCH] D96549: Support dereferencing a DWARF scalar stack value

aprantl created this revision. aprantl added reviewers: vsk, JDevlieghere, jasonmolenda. Herald added a subscriber: lxfind. aprantl requested review of this revision. Swift async functions receive function arguments inside a heap-allocated data structure, similar to how ObjC block captures or C++

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support [WIP]

mgorny added a comment. @labath, the Linux/common part is working here. FreeBSD is still pending further kernel changes, so I'm not going to commit it until all the kernel patches are committed, and then I'll add appropriate `#if`s. In the meantime, please review the utility part. This is rough

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

teemperor added a comment. This LGTM module the unrelated changes in that one file. A third pair of eyes probably won't hurt, so I'll give the others a change to look over this before I accept, but otherwise I'll just accept tomorrow. (Btw, if you intend to cherry-pick this into swift/main for

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support [WIP]

mgorny created this revision. mgorny added reviewers: krytarowski, emaste, labath. Herald added subscribers: omjavaid, danielkiss, kristof.beyls, arichardson. mgorny requested review of this revision. Split out the common base of Linux hardware breakpoint/watchpoint support for AArch64 into a Util

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

aprantl updated this revision to Diff 323135. aprantl added a comment. Found two more uncovered cases. Drive-by fix of two error messages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96537/new/ https://reviews.llvm.org/D96537 Files: lldb/include/lldb/Core/Value.h lldb/include/lld

[Lldb-commits] [PATCH] D96539: [lldb] Add step target to ThreadPlanStepInRange constructor

kastiglione updated this revision to Diff 323127. kastiglione added a comment. Herald added a subscriber: JDevlieghere. Improved wording in summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96539/new/ https://reviews.llvm.org/D96539 Files: l

[Lldb-commits] [lldb] 876e771 - [lldb] Disable x86-multithread-write.test with reproducers

Author: Jonas Devlieghere Date: 2021-02-11T13:17:30-08:00 New Revision: 876e7714dc73e651c5841af1b38b54fa350b6331 URL: https://github.com/llvm/llvm-project/commit/876e7714dc73e651c5841af1b38b54fa350b6331 DIFF: https://github.com/llvm/llvm-project/commit/876e7714dc73e651c5841af1b38b54fa350b6331.d

[Lldb-commits] [PATCH] D96539: [lldb] Add step target to ThreadPlanStepInRange constructor

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `QueueThreadPlanForStepInRange` accepts a `step_into_target`, but the constructor for `ThreadPlanStepInRa

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

aprantl updated this revision to Diff 323120. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96537/new/ https://reviews.llvm.org/D96537 Files: lldb/include/lldb/Core/Value.h lldb/include/lldb/Expression/ExpressionVariable.h lldb/source/Core/Value.cpp lldb/source/Core/ValueObject.c

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

aprantl updated this revision to Diff 323119. aprantl added a comment. Phabricator got really confused by the diff context. Reposting without context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96537/new/ https://reviews.llvm.org/D96537 Files: lldb/include/lldb/Core/Value.h lldb

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

aprantl created this revision. aprantl added reviewers: JDevlieghere, teemperor, shafik. Herald added a subscriber: emaste. aprantl requested review of this revision. The comment for ValueType claims that all values <1 are errors, but not all switch statements take this into account. This patch i

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:9 + +#if !defined(WIN32) +#include mstorsjo wrote: > stella.stamenova wrote: > > Also, this is no good. It works if you are targeting windows on windows, > > but not if you

[Lldb-commits] [lldb] 3cad308 - Revert "[lldb/test] Automatically find debug servers to test"

Author: Pavel Labath Date: 2021-02-11T20:26:05+01:00 New Revision: 3cad308ce5d9eb2cc52f43ccef68f3d2b12f2a32 URL: https://github.com/llvm/llvm-project/commit/3cad308ce5d9eb2cc52f43ccef68f3d2b12f2a32 DIFF: https://github.com/llvm/llvm-project/commit/3cad308ce5d9eb2cc52f43ccef68f3d2b12f2a32.diff

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

labath added a comment. In D96202#2557365 , @stella.stamenova wrote: > It looks like this change resulted in a failing test on the Windows LLDB bot: > > http://lab.llvm.org:8011/#/builders/83/builds/3602 > > It seems like one of the tests is trying to re-

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

jgorbe added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:808-809 + if (cu_index && (header.m_unit_type == llvm::dwarf::DW_UT_compile || + header.m_unit_type == llvm::dwarf::DW_UT_split_compile)) { +header.m_index_entry

[Lldb-commits] [lldb] ed98676 - Support multi-configuration generators correctly in several config files

Author: Stella Stamenova Date: 2021-02-11T09:32:20-08:00 New Revision: ed98676fa4833bb80632fc7c9db10c3328d78485 URL: https://github.com/llvm/llvm-project/commit/ed98676fa4833bb80632fc7c9db10c3328d78485 DIFF: https://github.com/llvm/llvm-project/commit/ed98676fa4833bb80632fc7c9db10c3328d78485.di

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

stella.stamenova added a comment. It looks like this change resulted in a failing test on the Windows LLDB bot: http://lab.llvm.org:8011/#/builders/83/builds/3602 It seems like one of the tests is trying to re-use the same log names within a single run and they are still being used by the previ

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:35 + +p_value_bytes = ['0xff', '0x55', '0x11', '0x01', '0x00'] +for i in ran

[Lldb-commits] [PATCH] D91723: [lldb] Fix that running a top level expression without a process fails with a cryptic error

This revision was automatically updated to reflect the committed changes. Closed by commit rG71536fd03108: [lldb] Fix that running a top level expression without a process fails with a… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: r

[Lldb-commits] [lldb] 71536fd - [lldb] Fix that running a top level expression without a process fails with a cryptic error

Author: Raphael Isemann Date: 2021-02-11T17:07:11+01:00 New Revision: 71536fd031084b25ffc9ad0a26c8471a68f5ad7c URL: https://github.com/llvm/llvm-project/commit/71536fd031084b25ffc9ad0a26c8471a68f5ad7c DIFF: https://github.com/llvm/llvm-project/commit/71536fd031084b25ffc9ad0a26c8471a68f5ad7c.dif

[Lldb-commits] [PATCH] D94307: [lldb] Don't emit a warning when using Objective-C getters in expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG19b4d3ce27d5: [lldb] Don't emit a warning when using Objective-C getters in expressions (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to com

[Lldb-commits] [lldb] 19b4d3c - [lldb] Don't emit a warning when using Objective-C getters in expressions

Author: Raphael Isemann Date: 2021-02-11T16:48:41+01:00 New Revision: 19b4d3ce27d5c8ed19bf08cdceb4c03608d2c66d URL: https://github.com/llvm/llvm-project/commit/19b4d3ce27d5c8ed19bf08cdceb4c03608d2c66d DIFF: https://github.com/llvm/llvm-project/commit/19b4d3ce27d5c8ed19bf08cdceb4c03608d2c66d.dif

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:104 + + return 0; +} Do I understand correctly that this will be filled in in a further patch? So right now it's only returning 0 because it

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:454 bool NativeRegisterContextLinux_arm64::IsSVE(unsigned reg) const { - if (GetRegisterInfo().GetRegisterSetFromRegisterIndex(reg) == - RegisterInfoPOS

[Lldb-commits] [lldb] e87b8e4 - [lldb] Log the actual expression result in UserExpression::Evaluate

Author: Raphael Isemann Date: 2021-02-11T16:15:01+01:00 New Revision: e87b8e4498df3bc1fcb751dfa24816ecf1ac02bd URL: https://github.com/llvm/llvm-project/commit/e87b8e4498df3bc1fcb751dfa24816ecf1ac02bd DIFF: https://github.com/llvm/llvm-project/commit/e87b8e4498df3bc1fcb751dfa24816ecf1ac02bd.dif

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib updated this revision to Diff 322997. mib marked 4 inline comments as done. mib added a comment. Herald added a subscriber: mgorny. Address @JDevlieghere feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

mib updated this revision to Diff 322995. mib marked 2 inline comments as done. mib added a comment. Address @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95710/new/ https://reviews.llvm.org/D95710 Files: lldb/include/lld

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:79 + m_mte_ctrl_reg = 0; + Should m_pac_mask also be initialised or is it already? Comment at: lldb/source/Plugins/Proc

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

This revision was automatically updated to reflect the committed changes. Closed by commit rG7df4eaaa9373: [lldb/test] Automatically find debug servers to test (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96202/new/ https://re

[Lldb-commits] [lldb] 7df4eaa - [lldb/test] Automatically find debug servers to test

Author: Pavel Labath Date: 2021-02-11T14:43:53+01:00 New Revision: 7df4eaaa937332c0617aa665080533966e2c98a0 URL: https://github.com/llvm/llvm-project/commit/7df4eaaa937332c0617aa665080533966e2c98a0 DIFF: https://github.com/llvm/llvm-project/commit/7df4eaaa937332c0617aa665080533966e2c98a0.diff

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:75-79 -if "LLDB_DEBUGSERVER_PATH" in os.environ: -return os.environ["LLDB_DEBUGSERVER_PATH"] -return _get_debug_monitor_from_lldb( -lld