teemperor added a comment. This LGTM module the unrelated changes in that one file. A third pair of eyes probably won't hurt, so I'll give the others a change to look over this before I accept, but otherwise I'll just accept tomorrow.
(Btw, if you intend to cherry-pick this into swift/main for some reason then please let me know as this probably will cause a bunch of conflicts with the temporarily reverted patch from Pavel). ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:38 #include "Plugins/ExpressionParser/Clang/ClangUtil.h" -#include "Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h" #include "Plugins/TypeSystem/Clang/TypeSystemClang.h" ---------------- The changes in this whole file seem like an accidental commit slipped in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96537/new/ https://reviews.llvm.org/D96537 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
