[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

2021-02-05 Thread Jorge Gorbe Moya via Phabricator via lldb-commits
jgorbe created this revision. jgorbe added reviewers: dblaikie, labath. Herald added a subscriber: arphaman. jgorbe requested review of this revision. Herald added a project: LLDB. In DWARF v4 compile units go in .debug_info and type units go in .debug_types. However, in v5 both kinds of units are

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

2021-02-05 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. See inlined comment about the packet name issue and let me know what you think Comment at: lldb/include/lldb/Target/Process.h:182-183 m_wait_for_launch = false; +m_wait_for_launch_interval = llvm::Optional(); +m_wait_for_launch_duration =

[Lldb-commits] [lldb] 28c6b1e - [lldb] Re-enable TestExprsChar on arm64

2021-02-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-02-05T15:21:24-08:00 New Revision: 28c6b1e5522f2beeac48ccf359e423cb31160c8d URL: https://github.com/llvm/llvm-project/commit/28c6b1e5522f2beeac48ccf359e423cb31160c8d DIFF: https://github.com/llvm/llvm-project/commit/28c6b1e5522f2beeac48ccf359e423cb31160c8d.d

[Lldb-commits] [lldb] ac1242b - [debugserver] Fix more warnings in DNBArchImplARM64

2021-02-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-02-05T15:21:24-08:00 New Revision: ac1242bce3657754768928cac36a6d1b1090a857 URL: https://github.com/llvm/llvm-project/commit/ac1242bce3657754768928cac36a6d1b1090a857 DIFF: https://github.com/llvm/llvm-project/commit/ac1242bce3657754768928cac36a6d1b1090a857.d

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

2021-02-05 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 added a comment. Herald added a subscriber: JDevlieghere. As discussed in the vAttachWait patch (https://reviews.llvm.org/D93895), I've implemented a jAttachWait packet with supports two additional parameters (polling interval and polling duration) when attaching to a process by name

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

2021-02-05 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 created this revision. augusto2112 added reviewers: labath, clayborg, jasonmolenda. Herald added a subscriber: dang. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jAttachWait provides the same functionality as vAtt

[Lldb-commits] [PATCH] D96096: [lldb] Emit type annotation in SWIG generated Python code.

2021-02-05 Thread Nathan Lanza via Phabricator via lldb-commits
lanza added a comment. Thanks, Jonas! What's the status for your downstream repos? This generates bindings but they aren't entirely functional as it generates type annotations like `"lldb::SBDebugger"` which Python LSPs can't figure out. I ended up adding `-py3` and then running some sed post-p

[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

2021-02-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: lldb/include/lldb/Host/ProcessLaunchInfo.h:187 lldb::ListenerSP m_hijack_listener_sp; + std::string m_scripted_process_class

[Lldb-commits] [PATCH] D96096: [lldb] Emit type annotation in SWIG generated Python code.

2021-02-05 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe5228ef556e5: [lldb] Emit type annotation in SWIG generated Python code. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [lldb] e5228ef - [lldb] Emit type annotation in SWIG generated Python code.

2021-02-05 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-02-05T08:51:22-08:00 New Revision: e5228ef556e5a4cb40c6c7936aada636e1b7be10 URL: https://github.com/llvm/llvm-project/commit/e5228ef556e5a4cb40c6c7936aada636e1b7be10 DIFF: https://github.com/llvm/llvm-project/commit/e5228ef556e5a4cb40c6c7936aada636e1b7be10.d

[Lldb-commits] [lldb] 6e1afd8 - [lldb][NFC] Minor comment and inlining fixes for Args

2021-02-05 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-02-05T10:17:16+01:00 New Revision: 6e1afd858757256afdb619665befb790c76418bb URL: https://github.com/llvm/llvm-project/commit/6e1afd858757256afdb619665befb790c76418bb DIFF: https://github.com/llvm/llvm-project/commit/6e1afd858757256afdb619665befb790c76418bb.dif

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

2021-02-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/utils/lldb-dotest/CMakeLists.txt:29 string(REPLACE ${LLVM_RUNTIME_OUTPUT_INTDIR} ${config_runtime_output_dir} LLDB_TEST_DSYMUTIL_CONFIGURED "${LLDB_TEST_DSYMUTIL}") -string(REPLACE ${LLVM_RUNTIME_OUTPUT_INTDIR} ${config_run

[Lldb-commits] [PATCH] D96034: [lldb/cmake] Reduce duplication in generation lldb-dotest

2021-02-05 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb90c4907ae81: [lldb/cmake] Reduce duplication in generation lldb-dotest (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96034/new/ https

[Lldb-commits] [PATCH] D95261: [lldb/test] Reduce API test tools configuration boilerplate

2021-02-05 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG98d9f2dcaca0: [lldb/test] Reduce API test tools configuration boilerplate (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95261/new/ htt

[Lldb-commits] [lldb] b90c490 - [lldb/cmake] Reduce duplication in generation lldb-dotest

2021-02-05 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2021-02-05T08:44:10+01:00 New Revision: b90c4907ae81e13ff3ce8a56b698e92b36a62d61 URL: https://github.com/llvm/llvm-project/commit/b90c4907ae81e13ff3ce8a56b698e92b36a62d61 DIFF: https://github.com/llvm/llvm-project/commit/b90c4907ae81e13ff3ce8a56b698e92b36a62d61.diff

[Lldb-commits] [lldb] 98d9f2d - [lldb/test] Reduce API test tools configuration boilerplate

2021-02-05 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2021-02-05T08:44:08+01:00 New Revision: 98d9f2dcaca0c9fe64616fcca882e45473cf6dd1 URL: https://github.com/llvm/llvm-project/commit/98d9f2dcaca0c9fe64616fcca882e45473cf6dd1 DIFF: https://github.com/llvm/llvm-project/commit/98d9f2dcaca0c9fe64616fcca882e45473cf6dd1.diff