JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
LGTM with a few nits. ================ Comment at: lldb/include/lldb/Host/ProcessLaunchInfo.h:187 lldb::ListenerSP m_hijack_listener_sp; + std::string m_scripted_process_class_name; + StructuredData::DictionarySP m_scripted_process_dictionary_sp; ---------------- Can you add a Doxygen comment explaining what they're used for? ================ Comment at: lldb/source/Host/common/ProcessLaunchInfo.cpp:176 m_hijack_listener_sp.reset(); + m_scripted_process_class_name = ""; + m_scripted_process_dictionary_sp.reset(); ---------------- Let's call `clear` for consistency with `m_plugin_name` which is also a string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95710/new/ https://reviews.llvm.org/D95710 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
