[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 320287. mib edited the summary of this revision. mib added a comment. - Set Process PID in `ScriptedProcess::DidLaunch` - Updated `ScriptedProcess::DoReadMemory` implementation. - Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib updated this revision to Diff 320285. mib added a comment. Add implementation for `ScriptedProcess_{GetNumMemoryRegions,GetNumThreads,GetProcessID,IsAlive,CanDebug,ReadMemoryAtAddress}` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/

[Lldb-commits] [PATCH] D95696: [lldb] [Process/FreeBSDRemote] Introduce arm (32-bit) support

clayborg added a comment. Is this for lldb-server or for the ProcessFreeBSD.cpp? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95696/new/ https://reviews.llvm.org/D95696 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support

clayborg added a comment. Is this code used by lldb-server or the native Free BSD plug-in? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95297/new/ https://reviews.llvm.org/D95297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes updated this revision to Diff 320257. nathawes marked an inline comment as done. nathawes edited the summary of this revision. nathawes set the repository for this revision to rG LLVM Github Monorepo. nathawes added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-c

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib updated this revision to Diff 320250. mib added a comment. Fix typo in swig wrapper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95712/new/ https://reviews.llvm.org/D95712 Files: lldb/bindings/python/python-scripted-process.swig lldb/bin

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 320249. mib added a comment. Fix typo in copyright header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/source/Plugins/Process/CMakeLists.txt lldb/source

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib updated this revision to Diff 320248. mib added a comment. Remove dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95713/new/ https://reviews.llvm.org/D95713 Files: lldb/source/Plugins/Process/CMakeLists.txt lldb/source/Plugins/Pro

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib created this revision. mib added reviewers: jasonmolenda, jingham, JDevlieghere, labath, LLDB. mib added a project: LLDB. Herald added a subscriber: mgorny. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces Scripted Processes to lldb. The go

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib created this revision. mib added reviewers: jasonmolenda, jingham, JDevlieghere, labath, LLDB. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. In order to facilitate the writting of Scripted Processes, this patch introduces a `Scripted

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib created this revision. mib added reviewers: jingham, JDevlieghere, jasonmolenda, labath, LLDB. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a ScriptedProcess interface to the ScriptInterpreter and more specifically,

[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

mib created this revision. mib added reviewers: JDevlieghere, jingham, jasonmolenda, labath, LLDB. mib added a project: LLDB. Herald added a subscriber: dang. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a new command options to the CommandObjectP

[Lldb-commits] [PATCH] D94857: [VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single implementation (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG719f77844175: [VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single… (authored by nathawes). Repository: rG LLVM Github Mono

[Lldb-commits] [lldb] 719f778 - [VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single implementation (NFC)

Author: Nathan Hawes Date: 2021-01-30T11:10:10+10:00 New Revision: 719f778441750dcadcf7c7c411d1cfb39029d59a URL: https://github.com/llvm/llvm-project/commit/719f778441750dcadcf7c7c411d1cfb39029d59a DIFF: https://github.com/llvm/llvm-project/commit/719f778441750dcadcf7c7c411d1cfb39029d59a.diff

[Lldb-commits] [PATCH] D95709: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

mib abandoned this revision. mib added a comment. It seems `arc` grouped all commits into a single differential. I'll split them in separate diffs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95709/new/ https://reviews.llvm.org/D95709 _

[Lldb-commits] [PATCH] D95709: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

mib created this revision. mib added reviewers: LLDB, JDevlieghere, jasonmolenda, jingham, labath. Herald added subscribers: dang, mgorny. mib requested review of this revision. Herald added a project: LLDB. This patch adds a new command options to the CommandObjectProecessLaunch for scripted proc

[Lldb-commits] [PATCH] D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support

krytarowski added a comment. @clayborg please have a look! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95297/new/ https://reviews.llvm.org/D95297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D95696: [lldb] [Process/FreeBSDRemote] Introduce arm (32-bit) support

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, clayborg. Herald added subscribers: omjavaid, kristof.beyls, arichardson. mgorny requested review of this revision. Introduce a NativeRegisterContextFreeBSD for 32-bit ARM platform. This includes support for GPR + V

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

mib updated this revision to Diff 320202. mib edited the summary of this revision. mib added a comment. Addressing @teemperor comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95686/new/ https://reviews.llvm.org/D95686 Files: lldb/bindings

[Lldb-commits] [PATCH] D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

mgorny added a comment. Gentoo uses plain `/usr/lib/clang/X.Y.Z` which doesn't really match any of the tested paths. Do you think there's a point in adding yet another case there or should I just override it locally? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Wouldn't it make more sense to give `SBTarget` a `IsLoaded` function? The function reads more like "please check if this target is loaded" which doesn't make sense. I get that

[Lldb-commits] [PATCH] D95686: [lldb/API] Expose Module::IsLoadedInTarget() to SB API (NFC)

mib created this revision. mib added reviewers: teemperor, jingham. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds an `SBModule::IsLoaded(const SBTarget&) const` endpoint to lldb's

Re: [Lldb-commits] Performing ManualDWARFIndex::Index() async during ManualDWARFIndex::Preload()

Thanks Raphael for the pointers, I will take a look. I just noticed I forgot to attach the actual patch I prepared ;) Here it is. On Fri, Jan 29, 2021, 5:02 PM Raphael “Teemperor” Isemann < teempe...@gmail.com> wrote: > I can't help with any of the requested feedback, but the last time I > looke

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. In D89156#2530839 , @tstellar wrote: > In D89156#2530703 , @Abpostelnicu > wrote: > >> In D89156#2530701 , >> @JosephTremoulet wrote: >> >>> O

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

tstellar added a comment. In D89156#2530703 , @Abpostelnicu wrote: > In D89156#2530701 , @JosephTremoulet > wrote: > >> Oh, I see. I made this change in the master branch and then ported it to >> the release/11.

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu marked an inline comment as done. Abpostelnicu added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h:58 const lldb_private::FileSpecList *module_search_paths_ptr, - lldb::ModuleSP *old_mo

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu updated this revision to Diff 320137. Abpostelnicu added a comment. Update for plularization of variables name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 Files: lldb/source/Plugins/Plat

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

JosephTremoulet added a comment. LGTM (and thanks for the fix and apologies for the break) )but I think @tstellar should have a look given it's fixing a build break in the release/11.x branch caused by my porting of changes from master for https://bugs.llvm.org/show_bug.cgi?id=48053

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu updated this revision to Diff 320134. Abpostelnicu added a comment. Update with format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 Files: lldb/source/Plugins/Platform/MacOSX/PlatformApple

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu created this revision. Abpostelnicu added a reviewer: JosephTremoulet. Abpostelnicu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix fallout caused by D89156 on 11.0.1 for MacOS Repositor

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. And there are more issues like: https://github.com/llvm/llvm-project/blob/llvmorg-11.0.1/lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp#L733. `old_module_sp_ptr` is nowhere declared. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. In D89156#2530701 , @JosephTremoulet wrote: > Oh, I see. I made this change in the master branch and then ported it to the > release/11.x branch. It changed the signature of a virtual method, which had > a couple more ove

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

JosephTremoulet added a subscriber: tstellar. JosephTremoulet added a comment. Oh, I see. I made this change in the master branch and then ported it to the release/11.x branch. It changed the signature of a virtual method, which had a couple more overrides in the release/11.x branch, and when

[Lldb-commits] Performing ManualDWARFIndex::Index() async during ManualDWARFIndex::Preload()

Hi lldb devs, We experienced some issues when debugging large binaries. The startup time of lldb for large binaries is long (tens of seconds). One of the reasons is that the *ManualDWARFIndex::Index()* function is executed synchronously and thus blocks during startup. We would like to change this

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie updated this revision to Diff 319871. haampie added a comment. Herald added a subscriber: arphaman. I dropped the awk bits, since there's no portable way to do it there, and replaced all `perl -w` with `perl` and `use warnings`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9511

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, unless @MaskRay has any other concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. In D89156#2530656 , @JosephTremoulet wrote: > In D89156#2530353 , @Abpostelnicu > wrote: > >> Shouldn't this also update PlatformiOSSimulator.h? > > There is no PlatformOSSimulator.h

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

JosephTremoulet added a comment. In D89156#2530353 , @Abpostelnicu wrote: > Shouldn't this also update PlatformiOSSimulator.h? There is no PlatformOSSimulator.h file (or I can't find it). There is a type `PlatformiOSSumulator`, but it doesn't have its

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. Shouldn't this also update PlatformiOSSimulator.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89156/new/ https://reviews.llvm.org/D89156 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] 27f2fe9 - Adapt lldb-instr to d47ee525f9e92898 APi change

Author: serge-sans-paille Date: 2021-01-29T10:58:40+01:00 New Revision: 27f2fe9163ec9e96f240fa57b5e2d7c55f54e266 URL: https://github.com/llvm/llvm-project/commit/27f2fe9163ec9e96f240fa57b5e2d7c55f54e266 DIFF: https://github.com/llvm/llvm-project/commit/27f2fe9163ec9e96f240fa57b5e2d7c55f54e266.d