JosephTremoulet added a comment.
LGTM (and thanks for the fix and apologies for the break) )but I think
@tstellar should have a look given it's fixing a build break in the
release/11.x branch caused by my porting of changes from master for
https://bugs.llvm.org/show_bug.cgi?id=48053
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h:58
const lldb_private::FileSpecList *module_search_paths_ptr,
- lldb::ModuleSP *old_module_sp_ptr,
+ llvm::SmallVectorImpl<lldb::ModuleSP> *old_module,
bool *did_create_ptr) override;
----------------
D89156 pluralized the name (`old_modules` with an s) in all the places it made
this change, since it's now a collection. IMO it would make sense to do the
same in this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95683/new/
https://reviews.llvm.org/D95683
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
