JDevlieghere added a comment.
Thanks Jim, I addressed both issues in the commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93479/new/
https://reviews.llvm.org/D93479
___
lldb-commits mailing list
lld
shafik added inline comments.
Comment at: lldb/include/lldb/Target/Process.h:2837
+ /// from looking up or creating things during or after a finalize call.
+ std::atomic m_finalizing;
+
```
std::atomic m_finalizing{false};
```
honestly the whole thing should b
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa913a583f00a: [lldb] Simplify the is_finalized logic in
process and make it thread safe. (authored by JDevlieghere).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D9347
Author: Jonas Devlieghere
Date: 2020-12-18T18:41:33-08:00
New Revision: a913a583f00a31c37a1572089fe8898a6c19536c
URL:
https://github.com/llvm/llvm-project/commit/a913a583f00a31c37a1572089fe8898a6c19536c
DIFF:
https://github.com/llvm/llvm-project/commit/a913a583f00a31c37a1572089fe8898a6c19536c.d
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
LGTM. It looks like we never made use of the distinction between "started to
finalize" and "done finalizing", so just marking it at the start of
finalization seems fine.
I quibble a bit w
shafik updated this revision to Diff 312904.
shafik marked 2 inline comments as done.
shafik added a comment.
- Fixed formatters::ObjCBOOLSummaryProvider to use int8_t and fixed the Printf
- Updated tests
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93421/new/
https://reviews.llvm.org/
shafik marked 4 inline comments as done.
shafik added inline comments.
Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:1038
}
- uint8_t value = (real_guy_sp->GetValueAsUnsigned(0) & 0xFF);
+ uint8_t value = (real_guy_sp->GetValueAsSigned(0) & 0xFF);
switch (value)
labath added a comment.
With this version of the patch, I am unable to reproduce the issue using the
approach I described in the previous comment. However, it still reproduces when
issuing the equivalent commands via the "gui" (either "by hand" or by running
TestGuiBasicDebug.py).
CHANGES SIN
JDevlieghere added a comment.
Thanks Pedro, it's really great to see the Lua interpreter getting all these
improvements!
Comment at:
lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:62
+case eIOHandlerWatchpoint:
+ break;
+case eIOHandlerBreakpo
mgorny created this revision.
mgorny added reviewers: labath, krytarowski.
Herald added a subscriber: pengfei.
mgorny requested review of this revision.
Copy changes, including:
- NativeProcessNetBSD::GetLoadedModuleFileSpec() and
NativeProcessNetBSD::GetFileLoadAddress() methods
- split x86 re
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Some comments about that this still prints 255, but otherwise this is looking
good.
(For the others: We agreed offline that adding the missing type checking for
BOOL is out of
tatyana-krasnukha updated this revision to Diff 312770.
tatyana-krasnukha added a comment.
Fixed CommandInterpreter::GetProcessOutput to avoid deadlock in Windows process
plugin. This should also fix the problem @labath described above.
Pavel, could you please check whether it works for you?
C
Author: David Zarzycki
Date: 2020-12-18T07:54:36-05:00
New Revision: 430d5d8429473c2b10b109991d7577a3cea41140
URL:
https://github.com/llvm/llvm-project/commit/430d5d8429473c2b10b109991d7577a3cea41140
DIFF:
https://github.com/llvm/llvm-project/commit/430d5d8429473c2b10b109991d7577a3cea41140.diff
Author: Pavel Labath
Date: 2020-12-18T13:01:42+01:00
New Revision: c15c29652118292c389d5f9fde1b11b55c248cd9
URL:
https://github.com/llvm/llvm-project/commit/c15c29652118292c389d5f9fde1b11b55c248cd9
DIFF:
https://github.com/llvm/llvm-project/commit/c15c29652118292c389d5f9fde1b11b55c248cd9.diff
DavidSpickett added a comment.
I assume that the signal displays without tag bits just like any other SEGV?
I was thinking about testing but I don't see any tests for specific signals so
it would only be needed if your change to add the tag bits to siginfo has gone
in.
(I have been following it
DavidSpickett planned changes to this revision.
DavidSpickett added a comment.
> Have you looked at the how llvm YAML and JSON libraries handle
> (de)serialization? I was hoping that we could implement something similar to
> that...
Good point, I was only looking at half the issue. I'll see how
16 matches
Mail list logo
