JDevlieghere added a comment.
Thanks Pedro, it's really great to see the Lua interpreter getting all these
improvements!
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:62
+ case eIOHandlerWatchpoint:
+ break;
+ case eIOHandlerBreakpoint:
----------------
Shouldn't this be the same for break- and watchpoints?
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:81
+ llvm::StringRef last_str = lines.GetStringAtIndex(last);
+ if (last_str.rtrim() == "quit") {
+ if (m_active_io_handler == eIOHandlerBreakpoint)
----------------
The "quit" is something lldb-specific. Even though the logic is very simple,
can you move it into a little helper function so that it doesn't get duplicated
across `IOHandlerIsInputComplete` and `IOHandlerInputComplete`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93481/new/
https://reviews.llvm.org/D93481
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
