[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

2020-11-08 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D90857#2379761 , @teemperor wrote: > Just to clarify: This only a dependency in the downstream Swift branch? Judging by the error message, this dependency is not correct even in the swift fork. lldbSymbol does not have a direct

[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

2020-11-08 Thread António Afonso via Phabricator via lldb-commits
aadsm updated this revision to Diff 303746. aadsm added a comment. Merged the 2 run/checks into one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87173/new/ https://reviews.llvm.org/D87173 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTPars

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

2020-11-08 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Alternatively, we could relist threads on every stop. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91032/new/ https://reviews.llvm.org/D91032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D91032: [lldb] [Process/FreeBSDRemote] Explicitly copy dbregs to new threads

2020-11-08 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: emaste, labath, krytarowski. mgorny requested review of this revision. Explicitly copy dbregs to new threads to ensure that watchpoints are propagated properly. Fixes the test failure due to apparent kernel race between reporting a new thread

[Lldb-commits] [PATCH] D91030: [lldb] [test] Extend watchpoint test to wait for thread to start

2020-11-08 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. NB: I'm going to address the FreeBSD problem separately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91030/new/ https://reviews.llvm.org/D91030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D91030: [lldb] [test] Extend watchpoint test to wait for thread to start

2020-11-08 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. mgorny requested review of this revision. TestWatchpointMultipleThreads currently accounts for two scenarios: setting the watchpoint before a new thread starts (presumably, ve

[Lldb-commits] [PATCH] D91026: [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'

2020-11-08 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Same fix as in NetBSD (a6712889f5f1702dfa535718abe400d1a83174c5). https://reviews.llvm.org/D91026 Files: lldb/source/Host/freebsd/Host.cpp lldb/test/API/commands/plat