labath added a comment.

In D90857#2379761 <https://reviews.llvm.org/D90857#2379761>, @teemperor wrote:

> Just to clarify: This only a dependency in the downstream Swift branch?

Judging by the error message, this dependency is not correct even in the swift 
fork. lldbSymbol does not have a direct dependency on llvmIR. It has a 
dependency on swift (through SwiftASTContext), and swift (through 
AST/Builtins.h) has a dependency on the generated headers.

So, the right fix should be to add a lldbSymbol->Swift dependency (if one isn't 
there already), and then a swift->LLVMIR dep.

Unless there are other, direct dependencies (include paths) from lldbSymbol to 
LLVMIR. However, I don't see any in the llvm repo, so it still sounds like 
something swifty...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90857/new/

https://reviews.llvm.org/D90857

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to