[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 303614. wallace marked 14 inline comments as done. wallace added a comment. address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90729/new/ https://reviews.llvm.org/D90729 Files: lldb/include/l

[Lldb-commits] [PATCH] D90840: [lldb/DWARF] Fix sizes of DW_OP_const[1248][us] and DW_OP_litN results

dblaikie added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:944 Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS)); + auto to_generic = [addr_size = opcodes.GetAddressByteSize()](auto v) { +bool is_signed = std::is_signed:

[Lldb-commits] [PATCH] D90987: [lldb] Avoid confusing crashes during reproducer replay when initialization failed

JDevlieghere updated this revision to Diff 303581. JDevlieghere added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90987/new/ https://reviews.llvm.org/D90987 Files: lldb/source/API/SystemInitializerFull.cpp Index: lldb/source/API/SystemInitializerFull.cpp =

[Lldb-commits] [PATCH] D90987: [lldb] Avoid confusing crashes during reproducer replay when initialization failed

JDevlieghere created this revision. JDevlieghere added a reviewer: vsk. JDevlieghere requested review of this revision. During active replay, the `::Initialize` call is replayed like any other SB API call and the return value is ignored. Since we can't intercept this, we terminate here before the

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

teemperor added a comment. Just to clarify: This only a dependency in the downstream Swift branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90857/new/ https://reviews.llvm.org/D90857 ___ lldb-commit

[Lldb-commits] [lldb] 137ff73 - [lldb] add a missing dependency on intrinsics_gen

Author: Richard Howell Date: 2020-11-06T13:15:08-05:00 New Revision: 137ff7331705179c83533a074d800c481b7df1ac URL: https://github.com/llvm/llvm-project/commit/137ff7331705179c83533a074d800c481b7df1ac DIFF: https://github.com/llvm/llvm-project/commit/137ff7331705179c83533a074d800c481b7df1ac.diff

[Lldb-commits] [PATCH] D90857: [lldb] add a missing dependency on intrinsics_gen

This revision was automatically updated to reflect the committed changes. Closed by commit rG137ff7331705: [lldb] add a missing dependency on intrinsics_gen (authored by rmaz, committed by lanza). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

sgraenitz added a comment. That's right, but I don't see how even the static ones could be resolved. Wouldn't it hard-wire the objects together? In the next session we want to load some object files from cache while others have changed.. Maybe one day I should check how ccache and the likes han

[Lldb-commits] [PATCH] D90938: [lldb] [Process/FreeBSDRemote] Handle exec() from inferior

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. I wonder why NetBSD fails having the same event handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90938/new/ https://reviews.llvm.org/D90938 _

[Lldb-commits] [PATCH] D90938: [lldb] [Process/FreeBSDRemote] Handle exec() from inferior

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. https://reviews.llvm.org/D90938 Files: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp lldb/test/API/functionalities/exec/TestExec.py Index: lldb/t

[Lldb-commits] [lldb] 1a8d528 - [lldb] [test] Avoid double negation in llgs/debugserver logic

Author: Michał Górny Date: 2020-11-06T14:34:12+01:00 New Revision: 1a8d52820f8e55f66567011e0ed852794b7f687d URL: https://github.com/llvm/llvm-project/commit/1a8d52820f8e55f66567011e0ed852794b7f687d DIFF: https://github.com/llvm/llvm-project/commit/1a8d52820f8e55f66567011e0ed852794b7f687d.diff

[Lldb-commits] [PATCH] D90875: [lldb] [test] Avoid double negations in llgs/debugserver logic

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a8d52820f8e: [lldb] [test] Avoid double negation in llgs/debugserver logic (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

krytarowski added a comment. In D90757#2378404 , @theraven wrote: > Does the new plugin work with processes that are created with `pdfork`? The > last time I tried this, it caused the old plugin to lock up the debugger > entirely. Please can you ensure

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

labath added inline comments. Comment at: lldb/include/lldb/Target/MemoryRegionInfo.h:43-45 +if (m_dirty_pages.hasValue()) { + m_dirty_pages.getValue().clear(); +} This bit is unnecessary. In fact, I'd implement the entire function as `*this = Memor

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

theraven added a comment. Does the new plugin work with processes that are created with `pdfork`? The last time I tried this, it caused the old plugin to lock up the debugger entirely. Please can you ensure that there are tests that cover `pdfork` and `cap_enter` in the child? These are curr

[Lldb-commits] [PATCH] D90875: [lldb] [test] Avoid double negations in llgs/debugserver logic

mgorny updated this revision to Diff 303374. mgorny added a comment. Used `lldbplatformutil.getPlatform()` as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90875/new/ https://reviews.llvm.org/D90875 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/packages/P

[Lldb-commits] [PATCH] D90875: [lldb] [test] Avoid double negations in llgs/debugserver logic

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:950 +configuration.llgs_platform = ( +target_platform in ["linux", "freebsd", "netbsd", "windows"]) + mgorny wrote: > labath wrote: > > This is not entirely equiva

[Lldb-commits] [PATCH] D90875: [lldb] [test] Avoid double negations in llgs/debugserver logic

mgorny updated this revision to Diff 303349. mgorny marked 2 inline comments as done. mgorny retitled this revision from "[lldb] [test] Avoid double negatives in llgs/debugserver logic" to "[lldb] [test] Avoid double negations in llgs/debugserver logic". mgorny added a comment. Removed the part

[Lldb-commits] [PATCH] D90875: [lldb] [test] Avoid double negatives in llgs/debugserver logic

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:950 +configuration.llgs_platform = ( +target_platform in ["linux", "freebsd", "netbsd", "windows"]) + labath wrote: > This

[Lldb-commits] [PATCH] D90769: [lldb][ObjectFile] Relocate sections for in-memory objects (e.g. received via JITLoaderGDB)

labath added a comment. In D90769#2376557 , @sgraenitz wrote: > Thanks for having a look! > > The JIT implementations in LLVM operate on relocatable object files, so > someone needs to resolve them. MCJIT has a flag `ProcessAllSections` to > control whic