[Lldb-commits] [lldb] 84ce6b9 - [lldb] Fix building with GCC 7. NFC.

Author: Martin Storsjö Date: 2020-10-24T09:33:01+03:00 New Revision: 84ce6b9991bb6db1c37897aca55978a377ce931a URL: https://github.com/llvm/llvm-project/commit/84ce6b9991bb6db1c37897aca55978a377ce931a DIFF: https://github.com/llvm/llvm-project/commit/84ce6b9991bb6db1c37897aca55978a377ce931a.diff

[Lldb-commits] [PATCH] D89999: [lldb] Implement ObjCGetClassNameRaw using a UtilityFunction

JDevlieghere planned changes to this revision. JDevlieghere added a comment. I need rebase this on my new UtilityFunction API CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8/new/ https://reviews.llvm.org/D8 ___ lldb-commits mailing li

[Lldb-commits] [lldb] 0b05732 - fix lldb for recent libDebugInfoDWARF API change

Author: David Blaikie Date: 2020-10-23T19:20:38-07:00 New Revision: 0b057320453b90bb409f55f74386b6841546d48a URL: https://github.com/llvm/llvm-project/commit/0b057320453b90bb409f55f74386b6841546d48a DIFF: https://github.com/llvm/llvm-project/commit/0b057320453b90bb409f55f74386b6841546d48a.diff

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

amccarth added a comment. This looks pretty good, both the patch and Pavel's insights. I don't see much to comment on that Pavel didn't already catch. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:168 + + ArchSpec &spec = module_spec.GetArchitecture(); +

[Lldb-commits] [PATCH] D85241: [intel-pt] Disable/Enable tracing to guarantee the trace is correct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48d8af982516: [intel-pt] Disable/Enable tracing to guarantee the trace is correct (authored by wallace). Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [lldb] 48d8af9 - [intel-pt] Disable/Enable tracing to guarantee the trace is correct

Author: Walter Erquinigo Date: 2020-10-23T16:36:42-07:00 New Revision: 48d8af98251613261805891a3476e9fb01932f43 URL: https://github.com/llvm/llvm-project/commit/48d8af98251613261805891a3476e9fb01932f43 DIFF: https://github.com/llvm/llvm-project/commit/48d8af98251613261805891a3476e9fb01932f43.di

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

jingham added a comment. In D78972#2041680 , @labath wrote: > I don't think we need to have different behavior for repl and --top-level. > I'm mainly just confused about what is the right behavior to aim for. > > So, assuming we want these to behave as if

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:176-197 + switch (dbi_stream->getMachineType()) { + case PDB_Machine::Amd64: +spec.SetTriple("x86_64-pc-windows"); +specs.Append(module_spec); +break; + case PDB_Machin

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 300388. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89812/new/ https://reviews.llvm.org/D89812 Files: lldb/source/Plu

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG73811d32c72d: [lldb] Move copying of files into reproducer out of process (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 73811d3 - [lldb] Move copying of files into reproducer out of process

Author: Jonas Devlieghere Date: 2020-10-23T12:33:54-07:00 New Revision: 73811d32c72d0760c8c2066e4675dd6f1a7bbef7 URL: https://github.com/llvm/llvm-project/commit/73811d32c72d0760c8c2066e4675dd6f1a7bbef7 DIFF: https://github.com/llvm/llvm-project/commit/73811d32c72d0760c8c2066e4675dd6f1a7bbef7.d

[Lldb-commits] [PATCH] D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743)

fpichet added a comment. What is the status of this patch? Can it be committed? It helps for our out of tree fork of lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89236/new/ https://reviews.llvm.org/D89236 ___

[Lldb-commits] [lldb] a4459fe - [lldb] Fix use of undefined type 'lldb_private::UtilityFunction'

Author: Jonas Devlieghere Date: 2020-10-23T11:48:11-07:00 New Revision: a4459feca415a757fa0ca3ab4731a17240931a81 URL: https://github.com/llvm/llvm-project/commit/a4459feca415a757fa0ca3ab4731a17240931a81 DIFF: https://github.com/llvm/llvm-project/commit/a4459feca415a757fa0ca3ab4731a17240931a81.d

[Lldb-commits] [PATCH] D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743)

mamai accepted this revision. mamai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89236/new/ https://reviews.llvm.org/D89236 ___ lld

[Lldb-commits] [PATCH] D90011: [lldb] Redesign Target::GetUtilityFunctionForLanguage API

jingham added a comment. LGTM. Thanks for making this easier to use. Inside lldb, if you are ever implementing something that requires a call into the inferior and you're going to do it more than once over the course of a process's life, you really should use one of these guys rather than disp

[Lldb-commits] [PATCH] D90011: [lldb] Redesign Target::GetUtilityFunctionForLanguage API

This revision was automatically updated to reflect the committed changes. Closed by commit rGde346cf2ac85: [lldb] Redesign Target::GetUtilityFunctionForLanguage API (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D90011?vs=300165&id=30

[Lldb-commits] [lldb] de346cf - [lldb] Redesign Target::GetUtilityFunctionForLanguage API

Author: Jonas Devlieghere Date: 2020-10-23T10:00:23-07:00 New Revision: de346cf2ac850be793ee7fc31f99a7671331c289 URL: https://github.com/llvm/llvm-project/commit/de346cf2ac850be793ee7fc31f99a7671331c289 DIFF: https://github.com/llvm/llvm-project/commit/de346cf2ac850be793ee7fc31f99a7671331c289.d

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Utility/Reproducer.cpp:389 + + if (auto files = llvm::MemoryBuffer::getFile(files_path)) { +SmallVector paths; labath wrote: > Is this deliberately ign

[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:994-995 !(m_xstate.xs_rfbm & XCR0_YMM_Hi128)) { - error.SetErrorStringWithFormat("register \"%s\" not supported by CPU/kernel", -

[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

mgorny updated this revision to Diff 300277. mgorny marked an inline comment as done. mgorny added a comment. Removed anonymous namespace and obsolete `#define`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90034/new/ https://reviews.llvm.org/D90034 Files: lldb/source/Plugins/Proces

[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

labath added a comment. I don't know much about netbd, but it definitely seems cleaner... Comment at: lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:150 +// x86 32-bit registers available via XState. +static const uint32_t g_xstate_regnums_i386[] = {

[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

mgorny created this revision. mgorny added reviewers: krytarowski, labath. Herald added a subscriber: pengfei. mgorny requested review of this revision. Unify the x86 regset API to use XStateRegSet for all FPU registers, therefore eliminating the legacy API based on FPRegSet. This makes the code

[Lldb-commits] [lldb] dae7b10 - [lldb] Split out NetBSD/x86 watchpoint impl for unification

Author: Michał Górny Date: 2020-10-23T12:20:15+02:00 New Revision: dae7b10034a515a34aca593fee24d5b73dc0785f URL: https://github.com/llvm/llvm-project/commit/dae7b10034a515a34aca593fee24d5b73dc0785f DIFF: https://github.com/llvm/llvm-project/commit/dae7b10034a515a34aca593fee24d5b73dc0785f.diff

[Lldb-commits] [PATCH] D89874: [lldb] Split out NetBSD/x86 watchpoint impl for unification

This revision was automatically updated to reflect the committed changes. Closed by commit rGdae7b10034a5: [lldb] Split out NetBSD/x86 watchpoint impl for unification (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D89874: [lldb] Split out NetBSD/x86 watchpoint impl for unification

mgorny updated this revision to Diff 300199. mgorny added a comment. Reformatted version, uploaded for completeness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89874/new/ https://reviews.llvm.org/D89874 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h lldb/source/Hos

[Lldb-commits] [PATCH] D89874: [lldb] Split out NetBSD/x86 watchpoint impl for unification

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Just don't forget to reformat the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89874/new/ https://reviews.llvm.org/D89874

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lldb/source/Utility/Reproducer.cpp:371 + + SmallVector paths; + (*buffer)->getBuffer().split(paths, '\0'); I'd expect this to conta

[Lldb-commits] [PATCH] D90011: [lldb] Redesign Target::GetUtilityFunctionForLanguage API

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds like a good idea. Comment at: lldb/include/lldb/Symbol/TypeSystem.h:469 + virtual std::unique_ptr + GetUtilityFunction(std::string text, std::string name) { +ret

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:176-197 + switch (dbi_stream->getMachineType()) { + case PDB_Machine::Amd64: +spec.SetTriple("x86_64-pc-windows"); +specs.Append(module_spec); +break; + case PDB_Machine: