amccarth added a comment.
This looks pretty good, both the patch and Pavel's insights. I don't see much
to comment on that Pavel didn't already catch.
================
Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:168
+
+ ArchSpec &spec = module_spec.GetArchitecture();
+ switch (dbi_stream->getMachineType()) {
----------------
For me, the name `spec` is confusing, because this code is mostly dealing with
ModuleSpecs but `spec` is a reference to the ArchSpec of the module_spec.
Perhaps `module_arch` would make this clearer. Then the code below would
follow a pattern like:
module_arch.SetTriple("blah");
specs.Append(module_spec);
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89812/new/
https://reviews.llvm.org/D89812
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
