[Lldb-commits] [PATCH] D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin

mgorny added a comment. No problem. If you could send me logs for other tests xfailing on Darwin (particularly mm-related), I'd also be happy to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88795/new/ https://reviews.llvm.org/D88795

[Lldb-commits] [PATCH] D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin

JDevlieghere added a comment. In D88795#2311096 , @mgorny wrote: > Thanks. I won't be at a computer for the next 8 hours, so feel free to push > it for me. Done. Thanks a lot for following up on this so quickly! Repository: rG LLVM Github Monorepo C

[Lldb-commits] [lldb] e8beb69 - [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin

Author: Michał Górny Date: 2020-10-04T23:04:40-07:00 New Revision: e8beb6988bab71ee4917288f07674b4982736109 URL: https://github.com/llvm/llvm-project/commit/e8beb6988bab71ee4917288f07674b4982736109 DIFF: https://github.com/llvm/llvm-project/commit/e8beb6988bab71ee4917288f07674b4982736109.diff

[Lldb-commits] [PATCH] D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8beb6988bab: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin (authored by mgorny, committed by JDevlieghere). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repos

[Lldb-commits] [lldb] 8036cf7 - llvm-dwarfdump: Skip tombstoned address ranges

Author: David Blaikie Date: 2020-10-04T13:43:29-07:00 New Revision: 8036cf7f5402ea7fc8564a9a2beae512c324bf3d URL: https://github.com/llvm/llvm-project/commit/8036cf7f5402ea7fc8564a9a2beae512c324bf3d DIFF: https://github.com/llvm/llvm-project/commit/8036cf7f5402ea7fc8564a9a2beae512c324bf3d.diff

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny marked 5 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:492 + } + for (i = 0; i < count; i++) { +MemoryRegionInfo info; arichardson wrote: > This code is C++ so u

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny updated this revision to Diff 296059. mgorny added a comment. Inlined memory map getting via sysctl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 Files: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp lldb/source/Plugins/P

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

arichardson added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:492 + } + for (i = 0; i < count; i++) { +MemoryRegionInfo info; This code is C++ so using for-loop initializers is fine. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:22 + +//#include "Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD.h" +#include "Plugins/Process/POSIX/ProcessPOSIXLog.h" mgorny wrote: >

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:22 + +//#include "Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD.h" +#include "Plugins/Process/POSIX/ProcessPOSIXLog.h" krytarowski wrote: >

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny updated this revision to Diff 296051. mgorny added a comment. Cleaned up unused includes + clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88796/new/ https://reviews.llvm.org/D88796 Files: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp lldb/source/Plugi

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:22 + +//#include "Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD.h" +#include "Plugins/Process/POSIX/ProcessPOSIXLog.h" Why this line?

[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

mgorny created this revision. mgorny added reviewers: emaste, krytarowski, labath. Herald added a subscriber: arichardson. mgorny requested review of this revision. Add a new FreeBSD Process plugin using client/server model. This plugin is based on the one used by NetBSD. It currently supports a