mgorny added inline comments.
================
Comment at:
lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:22
+
+//#include "Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD.h"
+#include "Plugins/Process/POSIX/ProcessPOSIXLog.h"
----------------
krytarowski wrote:
> Why this line?
Because otherwise it fails to compile? ;-)
================
Comment at:
lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:487
+ int count, i;
+ vm = kinfo_getvmmap(GetID(), &count);
+ if (vm == NULL) {
----------------
krytarowski wrote:
> Maybe here and in other places: `struct kinfo_vmentry *vm =
> kinfo_getvmmap(GetID(), &count);`
You've mentioned previously that you'd prefer for us not to use `-lutil`.
Should I inline the sysctls instead?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88796/new/
https://reviews.llvm.org/D88796
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
