n1tram1 marked 3 inline comments as done.
n1tram1 added a comment.
Fixed in latest patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78421/new/
https://reviews.llvm.org/D78421
___
lldb-commits mailin
n1tram1 updated this revision to Diff 258527.
n1tram1 added a comment.
Check the modification time against the current selected module.
(Previous patch was only checking against the current target's executable/main
module)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
jankratochvil added inline comments.
Comment at: lldb/source/Core/SourceManager.cpp:547
+ DebuggerSP debugger_sp(m_debugger_wp.lock());
+ if (debugger_sp) {
+lldb::TargetSP target_sp(debugger_sp->GetSelectedTarget());
```
if (!debugger_sp)
return false;
`
n1tram1 updated this revision to Diff 258509.
n1tram1 added a comment.
Apply clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78421/new/
https://reviews.llvm.org/D78421
Files:
lldb/include/lldb/Core/SourceManager.h
lldb/source/Core/S
n1tram1 created this revision.
n1tram1 added reviewers: k8stone, JDevlieghere, clayborg.
n1tram1 added a project: LLDB.
Herald added a subscriber: lldb-commits.
n1tram1 added a reviewer: jasonmolenda.
Currently lldb's SourceManager will check a source file for any updates each
time it accesses it
Author: Jan Kratochvil
Date: 2020-04-18T10:46:32+02:00
New Revision: 239093f30c342bc8a3feec1536a3154e394e55ca
URL:
https://github.com/llvm/llvm-project/commit/239093f30c342bc8a3feec1536a3154e394e55ca
DIFF:
https://github.com/llvm/llvm-project/commit/239093f30c342bc8a3feec1536a3154e394e55ca.diff
