jankratochvil added inline comments.
================
Comment at: lldb/source/Core/SourceManager.cpp:547
+ DebuggerSP debugger_sp(m_debugger_wp.lock());
+ if (debugger_sp) {
+ lldb::TargetSP target_sp(debugger_sp->GetSelectedTarget());
----------------
```
if (!debugger_sp)
return false;
```
================
Comment at: lldb/source/Core/SourceManager.cpp:549
+ lldb::TargetSP target_sp(debugger_sp->GetSelectedTarget());
+ if (target_sp) {
+ lldb::ModuleSP exec_module_sp(target_sp->GetExecutableModule());
----------------
```
if (!target_sp)
return false;
```
================
Comment at: lldb/source/Core/SourceManager.cpp:550
+ if (target_sp) {
+ lldb::ModuleSP exec_module_sp(target_sp->GetExecutableModule());
+ if (exec_module_sp) {
----------------
One should find the `Module` matching current frame. As this will not work for
debugging shared libraries.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78421/new/
https://reviews.llvm.org/D78421
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits