[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

xiaobai added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98 + bool IsMangledName(llvm::StringRef name) const override { +return false; + } friss wrote: > The original code was calling `IsPossibleObjCMethodName` and it l

[Lldb-commits] [lldb] f60de4c - Except, get the TARGET_OS_OSX check correct.

Author: Jason Molenda Date: 2020-02-06T20:28:40-08:00 New Revision: f60de4cdf7b8ca1b22700a6325a61a9b0da6a54b URL: https://github.com/llvm/llvm-project/commit/f60de4cdf7b8ca1b22700a6325a61a9b0da6a54b DIFF: https://github.com/llvm/llvm-project/commit/f60de4cdf7b8ca1b22700a6325a61a9b0da6a54b.diff

[Lldb-commits] [lldb] e2fa760 - Fix my use of the TARGET_OS_OSX TargetConditional.

Author: Jason Molenda Date: 2020-02-06T20:28:28-08:00 New Revision: e2fa760cdde2ebaa93cf1e959189dece3e949a68 URL: https://github.com/llvm/llvm-project/commit/e2fa760cdde2ebaa93cf1e959189dece3e949a68 DIFF: https://github.com/llvm/llvm-project/commit/e2fa760cdde2ebaa93cf1e959189dece3e949a68.diff

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

friss added a comment. In D74157#1863069 , @jingham wrote: > In D74157#1862537 , @labath wrote: > > > Looks better. TBH, I'm not sure why/if we really need the case handling the > > situation where the thread does

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

jingham added a comment. In D74157#1862537 , @labath wrote: > Looks better. TBH, I'm not sure why/if we really need the case handling the > situation where the thread does not have a stop description. Ideally I'd just > move this code there (or delete it

[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

friss added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:96-98 + bool IsMangledName(llvm::StringRef name) const override { +return false; + } The original code was calling `IsPossibleObjCMethodName` and it looks like you co

[Lldb-commits] [lldb] 8eb9b67 - Add final description of why attach failed with poss error string.

Author: Jason Molenda Date: 2020-02-06T17:28:49-08:00 New Revision: 8eb9b67bdacdaefc82a61921e52d2908f6f06931 URL: https://github.com/llvm/llvm-project/commit/8eb9b67bdacdaefc82a61921e52d2908f6f06931 DIFF: https://github.com/llvm/llvm-project/commit/8eb9b67bdacdaefc82a61921e52d2908f6f06931.diff

[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

xiaobai marked an inline comment as done. xiaobai added a comment. I uploaded this patch primarily to get some feedback on possible alternatives because I'm not happy creating a dependency from `Core` to `Target` here. Suggestions welcome! Comment at: lldb/source/Core/Mangled

[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

xiaobai created this revision. xiaobai added a reviewer: LLDB. Herald added a project: LLDB. Instead of asking each of the language plugins directly if a symbol is a possible manghled name for that language, we can generalize this pattern. By adding a method `IsMangledName` and iterating over each

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

jingham added a comment. In D74153#1862554 , @labath wrote: > Actually, it looks like we were getting away with that because the whole > ValueObjectRegisterContext (*not* RegisterSet) class is unused. In fact the > whole concept of having the entire regi

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev reopened this revision. paolosev added a comment. This revision is now accepted and ready to land. In D72751#1862140 , @labath wrote: > As promised, here are the comments on the new tests. I think that most of the > py3 incompatibilities will go

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev updated this revision to Diff 243045. paolosev added a comment. Modified tests to be compatible with Python3. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/ https://reviews.llvm.org/D72751 Files: lldb/packages/Python/lldbsuit

[Lldb-commits] [lldb] f5cdfb3 - Detect attach fail in debugserver due to non-interactive

Author: Jason Molenda Date: 2020-02-06T16:16:01-08:00 New Revision: f5cdfb34cd4b92bc6475f6c61f2996ada3a2ad1f URL: https://github.com/llvm/llvm-project/commit/f5cdfb34cd4b92bc6475f6c61f2996ada3a2ad1f DIFF: https://github.com/llvm/llvm-project/commit/f5cdfb34cd4b92bc6475f6c61f2996ada3a2ad1f.diff

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Thanks for doing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74168/new/ https://reviews.llvm.org/D74168 ___

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

JDevlieghere updated this revision to Diff 243030. JDevlieghere added a comment. Rename the argument from `EXCLUDE_FROM_ALL` to `EXCLUDE_FROM_CHECK_ALL` as per Stella's suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74168/new/ https://reviews.llvm.org/D74168 Files: clang/

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

JDevlieghere updated this revision to Diff 243031. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74168/new/ https://reviews.llvm.org/D74168 Files: clang/utils/perf-training/CMakeLists.txt compiler-rt/test/asan/CMakeLists.txt compiler-rt/test/fuzzer/CMakeLists.txt compiler-rt/test

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

JDevlieghere updated this revision to Diff 243018. JDevlieghere added a comment. Herald added a reviewer: jdoerfert. Update all uses of `add_lit_testsuite` to pass `EXCLUDE_FROM_ALL` as an argument rather than a scoped variable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74168/new/

[Lldb-commits] [PATCH] D74168: [CMake] Make EXCLUDE_FROM_ALL an argument to add_lit_testsuite

JDevlieghere updated this revision to Diff 243021. JDevlieghere added a comment. Simplify logic in `asan/CMakeLists.txt` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74168/new/ https://reviews.llvm.org/D74168 Files: clang/utils/perf-training/CMakeLists.txt compiler-rt/test/asan/CM

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

JDevlieghere accepted this revision. JDevlieghere added a comment. In D74157#1862537 , @labath wrote: > Looks better. TBH, I'm not sure why/if we really need the case handling the > situation where the thread does not have a stop description. Ideally I'd

[Lldb-commits] [PATCH] D74168: [lldb\CMake] Exclude the reproducer test suites from check-all

stella.stamenova added inline comments. Comment at: lldb/test/Shell/CMakeLists.txt:24 PARAMS "lldb-run-with-repro=capture" + EXCLUDE_FROM_ALL DEPENDS lldb-test-deps) After the change you made to add_lit_testsuite, this can be anywhere in the function call

[Lldb-commits] [PATCH] D74168: [lldb\CMake] Exclude the reproducer test suites from check-all

JDevlieghere updated this revision to Diff 243010. JDevlieghere added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Make EXCLUDE_FROM_ALL an argument to `add_lit_testsuite` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74168/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D74168: [lldb\CMake] Exclude the reproducer test suites from check-all

JDevlieghere created this revision. JDevlieghere added a reviewer: stella.stamenova. Herald added a subscriber: mgorny. Herald added a project: LLDB. JDevlieghere updated this revision to Diff 243003. The capture & replay test suites should be optional and not part of `check-all`. https://review

[Lldb-commits] [PATCH] D74168: [lldb\CMake] Exclude the reproducer test suites from check-all

JDevlieghere updated this revision to Diff 243003. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74168/new/ https://reviews.llvm.org/D74168 Files: lldb/test/Shell/CMakeLists.txt Index: lldb/test/Shell/CMakeLists.txt ===

[Lldb-commits] [lldb] 5e3fe22 - [lldb/Reproducers] Refactor GetStopReasonExtendedBacktraces (NFC)

Author: Jonas Devlieghere Date: 2020-02-06T14:00:09-08:00 New Revision: 5e3fe22c636274d4308400b0c2c9bc533ed0c49b URL: https://github.com/llvm/llvm-project/commit/5e3fe22c636274d4308400b0c2c9bc533ed0c49b DIFF: https://github.com/llvm/llvm-project/commit/5e3fe22c636274d4308400b0c2c9bc533ed0c49b.d

[Lldb-commits] [lldb] 2d59178 - [lldb/Reproducers] Add missing strings for redirect macro

Author: Jonas Devlieghere Date: 2020-02-06T14:01:03-08:00 New Revision: 2d591786343288828d00b9601693bb9d1663c2a9 URL: https://github.com/llvm/llvm-project/commit/2d591786343288828d00b9601693bb9d1663c2a9 DIFF: https://github.com/llvm/llvm-project/commit/2d591786343288828d00b9601693bb9d1663c2a9.d

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

labath added a comment. Actually, it looks like we were getting away with that because the whole ValueObjectRegisterContext (*not* RegisterSet) class is unused. In fact the whole concept of having the entire register context as a "value" seems fairly odd to me. Can we just delete it? Reposito

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks better. TBH, I'm not sure why/if we really need the case handling the situation where the thread does not have a stop description. Ideally I'd just move this code there (or delete it).

[Lldb-commits] [PATCH] D74160: [lldb] removed no longer needed CMakeDependentOption

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74160/new/ https://reviews.llvm.org/D74160

[Lldb-commits] [PATCH] D74160: [lldb] removed no longer needed CMakeDependentOption

kwk created this revision. kwk added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. kwk updated this revision to Diff 242991. kwk added a comment. kwk edited the summary of this revision. kwk edited the summary of this revision. Removed typo

[Lldb-commits] [PATCH] D74160: [lldb] removed no longer needed CMakeDependentOption

kwk updated this revision to Diff 242991. kwk added a comment. Removed typo in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74160/new/ https://reviews.llvm.org/D74160 Files: lldb/cmake/modules/LLDBConfig.cmake Index: lldb/cmake

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

jankratochvil added a comment. Even with the latest variant (commit `7ebe9cc4fc2d97ec0ed2a6038be25b2a7ed1aac2`) I am getting on Fedora 30 x86_64: /home/jkratoch/redhat/llvm-monorepo/lldb/test/Shell/Recognizer/assert.test:5:10: error: CHECK: expected string not found in input # CHECK: threa

[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()

friss created this revision. friss added reviewers: JDevlieghere, labath, mib. Herald added a project: LLDB. This gets rid of some nesting and of the raw char* variable that caused the memory management bug Ismail hit yesterday. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

jingham added a comment. We were probably getting away with this because ValueObjectRegisterSet's children don't really need their parent to construct their values? But still, this is not how ValueObject children should work... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

jingham added a comment. I think the ValueObjectRegisterSet::CreateChildAtIndex was wrong originally. It doesn't make it's children by passing itself in as the parent of the child, but just makes an independent ValueObject. You can fix that in your version by passing the ValueObjectRegisterSe

[Lldb-commits] [PATCH] D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

This revision was automatically updated to reflect the committed changes. Closed by commit rG733923a97dff: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi… (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Very nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74153/new/ https://reviews.llvm.org/D74153 _

[Lldb-commits] [lldb] 733923a - [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

Author: Stella Stamenova Date: 2020-02-06T12:31:57-08:00 New Revision: 733923a97dff2d2c6096d6b17c3987421be69ab6 URL: https://github.com/llvm/llvm-project/commit/733923a97dff2d2c6096d6b17c3987421be69ab6 DIFF: https://github.com/llvm/llvm-project/commit/733923a97dff2d2c6096d6b17c3987421be69ab6.di

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

labath updated this revision to Diff 242974. labath added a comment. Remove the leftover mutex unlock in the ClusterManager destructor. Doing any operation on the object while it is being destroyed is not safe, and the mutex will not help there. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D74153: [lldb] Delete the SharingPtr class

labath created this revision. labath added reviewers: teemperor, JDevlieghere, jingham. Herald added subscribers: jfb, mgorny. Herald added a project: LLDB. The only use of this class was to implement the SharedCluster of ValueObjects. However, the same functionality can be implemented using a reg

[Lldb-commits] [PATCH] D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/utils/lldb-repro/CMakeLists.txt:6 +# Generate lldb-repro Python script for each build mode. +if(LLDB_BUILT_STANDALONE) + set(config_types ".

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. In D74136#1862246 , @labath wrote: > In D74136#1862200 , @jingham wrote: > > > Is there ever a reason other than performance why you would want NOT to > > consult both the Compile Unit name

[Lldb-commits] [PATCH] D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

stella.stamenova marked an inline comment as done. stella.stamenova added inline comments. Comment at: lldb/utils/lldb-repro/CMakeLists.txt:6 +# Generate lldb-repro Python script for each build mode. +if(LLDB_BUILT_STANDALONE) + set(config_types ".") JDevliegher

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

labath added a comment. In D74136#1862200 , @jingham wrote: > Is there ever a reason other than performance why you would want NOT to > consult both the Compile Unit name and also look for DW_AT_decl_file? That > doesn't seem clear to me. > > If the onl

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

jingham added a comment. The one use I had for these clean targets was when you are making a new test and getting the test source to compile it is really tempting to run make in the test directory. It's a lot slower to go run the test, see the compile fail, fix something, etc... than just run

[Lldb-commits] [PATCH] D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

JDevlieghere added inline comments. Comment at: lldb/utils/lldb-repro/CMakeLists.txt:6 +# Generate lldb-repro Python script for each build mode. +if(LLDB_BUILT_STANDALONE) + set(config_types ".") Do you think it's possible/worthwhile to factor out this code in a

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

jingham added a comment. Is there ever a reason other than performance why you would want NOT to consult both the Compile Unit name and also look for DW_AT_decl_file is performance? That doesn't seem clear to me. If the only worry is performance, and except for that you would really always wa

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d11d5f62422: [lldb] [NFC] Refactor GetDWARFDeclContext to return DWARFDeclContext (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D74148: [lldb\utils] Place lldb-repro in a per-configuration directory to support multi-configuration generators

stella.stamenova created this revision. stella.stamenova added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Currently, lldb-repro is placed in the wrong location for multi-configuration generators. For example, in the case of VS, it is pl

[Lldb-commits] [lldb] 1d11d5f - [lldb] [NFC] Refactor GetDWARFDeclContext to return DWARFDeclContext

Author: Jan Kratochvil Date: 2020-02-06T20:06:28+01:00 New Revision: 1d11d5f6242206f4d0dbc11623f73cdf2173a087 URL: https://github.com/llvm/llvm-project/commit/1d11d5f6242206f4d0dbc11623f73cdf2173a087 DIFF: https://github.com/llvm/llvm-project/commit/1d11d5f6242206f4d0dbc11623f73cdf2173a087.diff

[Lldb-commits] [lldb] 31cf581 - [lldb] Explicitly qualify calls to std::static_pointer_cast

Author: Pavel Labath Date: 2020-02-06T10:55:16-08:00 New Revision: 31cf5819987a0b052338d7a6f41cbad5ba224b36 URL: https://github.com/llvm/llvm-project/commit/31cf5819987a0b052338d7a6f41cbad5ba224b36 DIFF: https://github.com/llvm/llvm-project/commit/31cf5819987a0b052338d7a6f41cbad5ba224b36.diff

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. As promised, here are the comments on the new tests. I think that most of the py3 incompatibilities will go away once we get rid of the yaml preprocessing step, but it would be good to verify this with python 3 nonetheless... Comment at: lldb/packages

[Lldb-commits] [lldb] 17d0091 - [lldb/Target] Remove extra semicolon in AssertFrameRecognizer (NFC)

Author: Med Ismail Bennani Date: 2020-02-06T19:46:32+01:00 New Revision: 17d0091d662b414600f0a31dcb3fe6cc353879a7 URL: https://github.com/llvm/llvm-project/commit/17d0091d662b414600f0a31dcb3fe6cc353879a7 DIFF: https://github.com/llvm/llvm-project/commit/17d0091d662b414600f0a31dcb3fe6cc353879a7.

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

labath added a comment. This looks good too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73787/new/ https://reviews.llvm.org/D73787 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [PATCH] D74093: [lldb/tests] Correctly configure the lldb dotest arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGd53c8c6af522: [lldb/tests] Correctly configure the lldb dotest arguments (authored by stella.stamenova). Changed prior to commit: https://reviews.llvm.org/D74093?vs=242753&id=242941#toc Repository: r

[Lldb-commits] [lldb] d53c8c6 - [lldb/tests] Correctly configure the lldb dotest arguments

Author: Stella Stamenova Date: 2020-02-06T10:27:10-08:00 New Revision: d53c8c6af5223e4098b395175f0bfaf75721fb79 URL: https://github.com/llvm/llvm-project/commit/d53c8c6af5223e4098b395175f0bfaf75721fb79 DIFF: https://github.com/llvm/llvm-project/commit/d53c8c6af5223e4098b395175f0bfaf75721fb79.di

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

jankratochvil updated this revision to Diff 242936. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73787/new/ https://reviews.llvm.org/D73787 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParse

[Lldb-commits] [PATCH] D73787: [NFC] Refactor `GetDWARFDeclContext` to return `DWARFDeclContext`

jankratochvil added a comment. In D73787#1859754 , @labath wrote: > One way to this could be improved further is to change the recursion in > `GetDWARFDeclContext` into a loop (then you wouldn't need the extra wrapper). True, I am stupid. But then I fin

[Lldb-commits] [lldb] b8f4e0a - [lldb] Remove reset(nullptr_t) overload from SharingPtr

Author: Pavel Labath Date: 2020-02-06T10:07:06-08:00 New Revision: b8f4e0a8234377cdac8740addfdabee339b12d2a URL: https://github.com/llvm/llvm-project/commit/b8f4e0a8234377cdac8740addfdabee339b12d2a DIFF: https://github.com/llvm/llvm-project/commit/b8f4e0a8234377cdac8740addfdabee339b12d2a.diff

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

labath added a comment. I think that having this behavior key off of a flag is really confusing. I think the most sensible behavior here would be to introduce a new option like `--compile-unit` and have that behave like the current --file+--function mode. This would free up the --file argument

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ebe9cc4fc2d: [lldb/Target] Add Assert StackFrame Recognizer (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73303/new/ https://reviews.llv

[Lldb-commits] [lldb] 7ebe9cc - [lldb/Target] Add Assert StackFrame Recognizer

Author: Med Ismail Bennani Date: 2020-02-06T18:27:48+01:00 New Revision: 7ebe9cc4fc2d97ec0ed2a6038be25b2a7ed1aac2 URL: https://github.com/llvm/llvm-project/commit/7ebe9cc4fc2d97ec0ed2a6038be25b2a7ed1aac2 DIFF: https://github.com/llvm/llvm-project/commit/7ebe9cc4fc2d97ec0ed2a6038be25b2a7ed1aac2.

[Lldb-commits] [PATCH] D73303: [lldb/Target] Add Assert StackFrame Recognizer

mib updated this revision to Diff 242926. mib added a comment. This revision is now accepted and ready to land. Fixing the memory management bug should hopefully solve the Linux and Windows Issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7330

[Lldb-commits] [PATCH] D74138: [lldb] Group ABI plugins

labath added a comment. If there's a need for single entry point for each of the new meta-plugins, this can go into a new file like ABIAArch64.cpp (and then the common code can go there too). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74138/new

[Lldb-commits] [PATCH] D74138: [lldb] Group ABI plugins

labath created this revision. labath added reviewers: JDevlieghere, jasonmolenda. Herald added subscribers: jsji, atanasyan, jrtc27, kbarton, fedor.sergeev, kristof.beyls, mgorny, nemanjai, sdardis. Herald added a reviewer: jfb. Herald added a project: LLDB. There's a fair amount of code duplicat

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk created this revision. Herald added subscribers: lldb-commits, dexonsmith, aprantl, mehdi_amini, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. kwk planned changes to this revision. kwk added a comment. I plan to refactor some of this patch. To set a breakpoint on

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk planned changes to this revision. kwk added a comment. I plan to refactor some of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 ___ lldb-commi

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

labath added a comment. In D73969#1861494 , @aykevl wrote: > >> Right now there are asserts both when constructing/copying(?) the object > >> (5 asserts) and at the place where `m_addr_size` is used (3 asserts). I > >> would propose picking one place, su

[Lldb-commits] [PATCH] D73782: [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit

labath updated this revision to Diff 242915. labath marked 2 inline comments as done. labath added a comment. - clang-format - add some doxygen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73782/new/ https://reviews.llvm.org/D73782 Files: lldb/

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, I don't think we need to maintain this. Now that the tests our built out of tree, we can clean them by just nuking the build folder. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D73782: [lldb/DWARF] Don't hold a unique SymbolFileDWARFDwo in a DWARFUnit

labath marked 4 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:56 +return nullptr; + if (hash != cu->GetUnitDIEOnly().GetAttributeValueAsUnsigned(DW_AT_GNU_dwo_id, 0)) +return nullptr; -

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

teemperor updated this revision to Diff 242899. teemperor added a comment. - Reverted some removal for bundle tests that somehow use this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74126/new/ https://reviews.llvm.org/D74126 Files: lldb/packages/Python/lldbsuite/test/api/multithre

[Lldb-commits] [PATCH] D74096: [lldb/API] Fix the dangling pointer issue in SBThread::GetStopDescription

mib abandoned this revision. mib added a comment. I'll merge this with D73303 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74096/new/ https://reviews.llvm.org/D74096

[Lldb-commits] [PATCH] D74126: [lldb] Remove all 'clean' targets from test Makefiles

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To my knowledge we don't actually use or need these rules. And if we need them then there is probably a better way to implement this than having

[Lldb-commits] [lldb] 7603778 - [lldb][NFC] Move call-overidden-method test to lang/cpp/ folder

Author: Raphael Isemann Date: 2020-02-06T14:36:09+01:00 New Revision: 7603778922ab1e93ec3d9da451fcd89c3bad9ec2 URL: https://github.com/llvm/llvm-project/commit/7603778922ab1e93ec3d9da451fcd89c3bad9ec2 DIFF: https://github.com/llvm/llvm-project/commit/7603778922ab1e93ec3d9da451fcd89c3bad9ec2.dif

[Lldb-commits] [lldb] 0ea20eb - [lldb] Add test for calling const functions

Author: Raphael Isemann Date: 2020-02-06T14:28:06+01:00 New Revision: 0ea20ebf2d46072c36a0be49fdf4061480a42206 URL: https://github.com/llvm/llvm-project/commit/0ea20ebf2d46072c36a0be49fdf4061480a42206 DIFF: https://github.com/llvm/llvm-project/commit/0ea20ebf2d46072c36a0be49fdf4061480a42206.dif

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl added a comment. >> Right now there are asserts both when constructing/copying(?) the object (5 >> asserts) and at the place where `m_addr_size` is used (3 asserts). I would >> propose picking one place, such as where it is used. That would reduce the >> number of asserts to 3 and keep t

[Lldb-commits] [PATCH] D74084: [LLDB] Fix compilation with GCC 5

hans added a comment. In D74084#1861269 , @mstorsjo wrote: > @hans - this could be applied on 10.x (it seems to apply cleanly), to fix > PR44791. Thanks! Cherry-picked as 22633f85bb7d317ff97c86b6ae7817b678777d93

[Lldb-commits] [PATCH] D74084: [LLDB] Fix compilation with GCC 5

mstorsjo added a subscriber: hans. mstorsjo added a comment. @hans - this could be applied on 10.x (it seems to apply cleanly), to fix PR44791. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74084/new/ https://reviews.llvm.org/D74084 ___

[Lldb-commits] [PATCH] D74084: [LLDB] Fix compilation with GCC 5

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bbaf543585c: [LLDB] Fix compilation with GCC 5 (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74084/new/ https://reviews.llvm.org/D7