JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/utils/lldb-repro/CMakeLists.txt:6 +# Generate lldb-repro Python script for each build mode. +if(LLDB_BUILT_STANDALONE) + set(config_types ".") ---------------- stella.stamenova wrote: > JDevlieghere wrote: > > Do you think it's possible/worthwhile to factor out this code in a CMake > > macro/function? We have a few places where we have to do something similar, > > but it's never exactly the same. > I think it's possible, but because it is not exactly the same, I am not sure > if it's worth doing. For example, we would have to make it possible to > specify a list of properties that all have to be "configured" together along > with a file to configure sometimes and the action on the file. It is > definitely doable, but it will still be complicated code that one has to > remember to call. > > If anything, it may be worth placing any tools that fall under this category > in the same tree structure with a top-level CMake file that correctly handles > all of them, but that would require some more work and still wouldn't be > ideal because we'd need to handle any exceptions separately. Fair enough, unfortunately that's what I expected. Thanks for entertaining the idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74148/new/ https://reviews.llvm.org/D74148 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
