[Lldb-commits] [lldb] 0683250 - [lldb][NFC] Remove unnecessary includes in source/Commands

2019-12-15 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2019-12-16T08:59:08+01:00 New Revision: 068325012796bf2da527612ea6fdc61531c8beb3 URL: https://github.com/llvm/llvm-project/commit/068325012796bf2da527612ea6fdc61531c8beb3 DIFF: https://github.com/llvm/llvm-project/commit/068325012796bf2da527612ea6fdc61531c8beb3.dif

[Lldb-commits] [lldb] e2d4761 - [lldb][NFC] Replace ClangASTImporter's use of map/set with SmallPtrSet and DenseMap

2019-12-15 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2019-12-16T08:29:14+01:00 New Revision: e2d47614a81d0805a869e6141512e0136da9 URL: https://github.com/llvm/llvm-project/commit/e2d47614a81d0805a869e6141512e0136da9 DIFF: https://github.com/llvm/llvm-project/commit/e2d47614a81d0805a869e6141512e0136da9.dif

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for member function linked with lld

2019-12-15 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Can you attach a paste of the DWARF that is emitted by lld and the symbol table and annotate which one should be picked. I am having trouble understanding what the right solution for this fix would be. It makes me nervous to require a symbol in the symbol table since s

[Lldb-commits] [PATCH] D71398: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

2019-12-15 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8280896bd1b0: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 8280896 - [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

2019-12-15 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2019-12-15T22:39:50+01:00 New Revision: 8280896bd1b055a192d9e7d482b0ffa14ee88e3a URL: https://github.com/llvm/llvm-project/commit/8280896bd1b055a192d9e7d482b0ffa14ee88e3a DIFF: https://github.com/llvm/llvm-project/commit/8280896bd1b055a192d9e7d482b0ffa14ee88e3a.dif

[Lldb-commits] [PATCH] D71398: [lldb] Remove RTTI in ClangExternalASTSourceCommon based on a global map of known instances

2019-12-15 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor updated this revision to Diff 233984. teemperor added a comment. - Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71398/new/ https://reviews.llvm.org/D71398 Files: lldb/include/lldb/Symbol/ClangExternalASTSourceCommon.h lldb/source/Symbol/ClangASTContext.cpp lld

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

2019-12-15 Thread Mark Mossberg via Phabricator via lldb-commits
mossberg added a comment. I wanted to also mention that this patch won't address buggy behavior if, for example, the stub takes a function pointer on the stack (vs a normal data pointer). In this case, the executable check will succeed, and the breakpoint will be written, but to a potentially a