clayborg added a comment.

Can you attach a paste of the DWARF that is emitted by lld and the symbol table 
and annotate which one should be picked. I am having trouble understanding what 
the right solution for this fix would be. It makes me nervous to require a 
symbol in the symbol table since symbol tables can be stripped from binaries.



================
Comment at: lldb/source/Expression/IRExecutionUnit.cpp:833-835
+            // Keep looking for a function entry with a symbol.
+            if (candidate_sc.function && !candidate_sc.symbol)
+                continue;
----------------
Debug info can be in an executable and the symbol can be stripped. Not sure 
this is safe to require a symbol? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71487/new/

https://reviews.llvm.org/D71487



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to