[Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

mgorny added a comment. Unless I'm mistaken, this is fixed by replacing `std::call_once` with `llvm::call_once`. I'll complete testing and commit it later today. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66566/new/ https://reviews.llvm.org/D66566

[Lldb-commits] [PATCH] D66566: [lldb] Replace std::once_flag with llvm::once_flag.

mgorny added a comment. This broke NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/21974 FAILED: tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Process.cpp.o /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLIBXML2_DEFINED -DLLDB_CONFIGURATION_RELEASE -D__STDC_CON

[Lldb-commits] [PATCH] D67082: Port TestBatchMode to PExpectTest class

labath created this revision. labath added reviewers: teemperor, JDevlieghere. I'm doing this mainly for consistency, but there are also other cleanups that will be enabled by this (e.g., the automatic setting of clang-modules-cache-path setting). https://reviews.llvm.org/D67082 Files: packag

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1901 + ArchSpec spec = m_gnuDebugDataObjectFile->GetArchitecture(); + if (spec && m_gnuDebugDataObjectFile->SetModulesArchitecture(spec)) { +return m_gnuDebugDataObjectFile; -

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk added a comment. @labath I did go over a lot of your comments. Thank you for helping me in becoming in a better contributor. I'm still not done with the python/make -> lit test transition but the rest is mostly covered. Comment at: lldb/cmake/modules/LLDBConfig.cmake:337

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218374. kwk marked 24 inline comments as done. kwk added a comment. - Remove left-over variable in CMake - Move LLDB_ENABLE_LZMA into Config.h.cmake - Remove unused code - Change signature of lldb_private::lzma::uncompress - Fixup - Fixup - When using the ObjectFi

[Lldb-commits] [PATCH] D67022: Skip getting declarations for repeated DIEs (WIP)

labath added a comment. I am not very familiar with this code, but I don't see a reason why what you're doing could not work. However, it looks like the implementation of it could be done in a better way. For instance, this function seems to be the only caller of `GetDIEForDeclContext`. So, we

[Lldb-commits] [PATCH] D66654: 2/2: Process formatters in reverse-chronological order

jankratochvil added a comment. In D66654#1654713 , @labath wrote: > The most common operations are lookup (which are linear in any case), There are also lookups by name (`GetExact`) which

[Lldb-commits] [PATCH] D66654: 2/2: Process formatters in reverse-chronological order

labath added a comment. Hm... "summarizing" might not have been the best word here. I have "summarized" what *I* said over IRC, but I did not mean to imply that Jan agreed with my position (and he didn't, not yet anyway..) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D66654: 2/2: Process formatters in reverse-chronological order

labath added a comment. Summarizing our discussion on IRC: While I think that this version of the patch is definitely better than the previous ones, I still feel that the two container solution is unnecessarily complicated. I think using llvm::MapVector or even std::vector would be sufficient.

[Lldb-commits] [PATCH] D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test

This revision was automatically updated to reflect the committed changes. Closed by commit rL370658: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r370658 - [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test

Author: labath Date: Mon Sep 2 06:33:12 2019 New Revision: 370658 URL: http://llvm.org/viewvc/llvm-project?rev=370658&view=rev Log: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test Summary: The gui command requires curses support, which can be disabled at compile time. This

[Lldb-commits] [PATCH] D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test

labath updated this revision to Diff 218345. labath added a comment. Rename the function to _get_bool_config_skip_if_decorator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67073/new/ https://reviews.llvm.org/D67073 Files: packages/Python/lldbsuite/test/commands/gui/basic/TestGuiBasi

[Lldb-commits] [PATCH] D66744: NativeProcessLinux: Remove some register context boilerplate

This revision was automatically updated to reflect the committed changes. Closed by commit rL370653: NativeProcessLinux: Remove some register context boilerplate (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHAN

[Lldb-commits] [lldb] r370653 - NativeProcessLinux: Remove some register context boilerplate

Author: labath Date: Mon Sep 2 05:50:18 2019 New Revision: 370653 URL: http://llvm.org/viewvc/llvm-project?rev=370653&view=rev Log: NativeProcessLinux: Remove some register context boilerplate Summary: This patch follows the spirit of D63594, and removes some null checks for things which should

[Lldb-commits] [PATCH] D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test

labath marked an inline comment as done. labath added inline comments. Comment at: packages/Python/lldbsuite/test/decorators.py:786 -def skipIfXmlSupportMissing(func): +def _get_bool_config_decorator(key): config = lldb.SBDebugger.GetBuildConfiguration() j

[Lldb-commits] [PATCH] D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test

jankratochvil accepted this revision. jankratochvil added inline comments. Comment at: packages/Python/lldbsuite/test/decorators.py:786 -def skipIfXmlSupportMissing(func): +def _get_bool_config_decorator(key): config = lldb.SBDebugger.GetBuildConfiguration() --

[Lldb-commits] [PATCH] D67075: Pass -DLLDB_DISABLE_CURSES to the lldb-x86_64-debian bot

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for getting the bots running again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67075/new/ https://reviews.llvm.org/D67075

[Lldb-commits] [PATCH] D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67073/new/ https://reviews.llvm.org/D67073 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D67075: Pass -DLLDB_DISABLE_CURSES to the lldb-x86_64-debian bot

labath created this revision. labath added reviewers: teemperor, jankratochvil. Tests which require curses functionality are mysteriously failing on this bot, even though the bot does have curses installed, and the tests pass everywhere else. This patch hard-disables curses functionality on this

[Lldb-commits] [PATCH] D67073: [dotest] Add @skipIfCursesSupportMissing and annotate the new gui test

labath created this revision. labath added reviewers: teemperor, jankratochvil. The gui command requires curses support, which can be disabled at compile time. This patch adds the ability to detect this situation in the test suite and skip the test accordingly. https://reviews.llvm.org/D67073 F

[Lldb-commits] [lldb] r370647 - [lldb][NFC] Add test for invalid gui command

Author: teemperor Date: Mon Sep 2 05:10:16 2019 New Revision: 370647 URL: http://llvm.org/viewvc/llvm-project?rev=370647&view=rev Log: [lldb][NFC] Add test for invalid gui command Added: lldb/trunk/packages/Python/lldbsuite/test/commands/gui/invalid-args/ lldb/trunk/packages/Python/lldb

[Lldb-commits] [lldb] r370645 - [lldb][NFC] Remove unused imports from TestIntegerTypesExpr.py

Author: teemperor Date: Mon Sep 2 04:58:03 2019 New Revision: 370645 URL: http://llvm.org/viewvc/llvm-project?rev=370645&view=rev Log: [lldb][NFC] Remove unused imports from TestIntegerTypesExpr.py Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypesExpr.py Modified:

[Lldb-commits] [PATCH] D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array

This revision was automatically updated to reflect the committed changes. Closed by commit rL370644: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array (authored by omjavaid, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [lldb] r370644 - [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array

Author: omjavaid Date: Mon Sep 2 04:53:29 2019 New Revision: 370644 URL: http://llvm.org/viewvc/llvm-project?rev=370644&view=rev Log: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array This patches paves way for upcoming SVE RegisterInfo definitions. This is cosmetic cha

[Lldb-commits] [lldb] r370641 - [lldb][NFC] Remove unused imports from TestIntegerTypes.py

Author: teemperor Date: Mon Sep 2 04:30:00 2019 New Revision: 370641 URL: http://llvm.org/viewvc/llvm-project?rev=370641&view=rev Log: [lldb][NFC] Remove unused imports from TestIntegerTypes.py Modified: lldb/trunk/packages/Python/lldbsuite/test/types/TestIntegerTypes.py Modified: lldb/trun

[Lldb-commits] [PATCH] D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array

omjavaid marked 3 inline comments as done. omjavaid added a comment. Thanks @clayborg suggestions noted and will be fixed in committed patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66934/new/ https://reviews.llvm.org/D66934 ___ lldb-

[Lldb-commits] [lldb] r370638 - [lldb][NFC] Add test for source info

Author: teemperor Date: Mon Sep 2 03:55:52 2019 New Revision: 370638 URL: http://llvm.org/viewvc/llvm-project?rev=370638&view=rev Log: [lldb][NFC] Add test for source info Added: lldb/trunk/packages/Python/lldbsuite/test/commands/source/ lldb/trunk/packages/Python/lldbsuite/test/commands

[Lldb-commits] [PATCH] D66994: [lldb][CMake] Fix windows-x86-debug compilation with python enabled using multi-target generator

leonid.mashinskiy added a comment. Since this patch appeared to be arguable from your point of view I will write some comments before making any further changes. In D66994#1652868 , @amccarth wrote: > - I use the VS project only for code browsing and deb

[Lldb-commits] [PATCH] D67067: Breakpad: Basic support for STACK WIN unwinding

labath created this revision. labath added reviewers: amccarth, rnk, markmentovai. This patch makes it possible to unwind via breakpad STACK WIN records. It is "basic" because two important features are missing: - support for the .raSearch keyword - support for multiple STACK WIN records within a

[Lldb-commits] [PATCH] D67064: [LLDB][NFC] Remove lldbcurses.py

teemperor created this revision. teemperor added a reviewer: clayborg. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This doesn't seem to be used anymore (at least I can't find any reference to this in the LLDB repo and it doesn't seem to be a standalone scri

[Lldb-commits] [PATCH] D67063: [lldb] Add description to option completions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370628: [lldb] Add description to option completions. (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [lldb] r370628 - [lldb] Add description to option completions.

Author: teemperor Date: Mon Sep 2 01:34:57 2019 New Revision: 370628 URL: http://llvm.org/viewvc/llvm-project?rev=370628&view=rev Log: [lldb] Add description to option completions. Summary: Right now our argument completions are rather cryptic for command options as they only list the letters:

[Lldb-commits] [PATCH] D67063: [lldb] Add description to option completions.

teemperor added a comment. Good catch, extended the test to also test the ambiguous options. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67063/new/ https://reviews.llvm.org/D67063 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:341 + if (LIBLZMA_FOUND) + add_definitions(-DLLDB_ENABLE_LZMA) +include_directories(${LIBLZMA_INCLUDE_DIRS}) labath wrote: > Please put this into `Config.h.cmake`. I know a l

[Lldb-commits] [PATCH] D67063: [lldb] Add description to option completions.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds like a good idea. I noticed that you have three tests, but are changing four places in the code. Looks like you're probably missing one of them. By the looks of things, it's probably t

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

teemperor planned changes to this revision. teemperor added a comment. (mark as WIP) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65386/new/ https://reviews.llvm.org/D65386 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:337 +find_package(LibLZMA) +cmake_dependent_option(LLDB_ENABLE_LZMA "Support LZMA compression" ON "LIBLZMA_FOUND" OFF) +set(LLDB_LIBLZMA_LIBRARIES) This looks like a really useful macr

[Lldb-commits] [PATCH] D67063: [lldb] Add description to option completions.

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Right now our argument completions are rather cryptic for command options as they only list the letters: (lldb) breakpoint set - Available co

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

teemperor added a comment. Yeah, the directory was pre-restructure. Moved to the right path before committing (and removed the other stuff you pointed out). Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67018/new/ https://reviews.llvm.org/D67018 __

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

This revision was automatically updated to reflect the committed changes. Closed by commit rL370625: [lldb][NFC] Add basic test for GUI command (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [lldb] r370625 - [lldb][NFC] Add basic test for GUI command

Author: teemperor Date: Mon Sep 2 01:00:59 2019 New Revision: 370625 URL: http://llvm.org/viewvc/llvm-project?rev=370625&view=rev Log: [lldb][NFC] Add basic test for GUI command Summary: This adds a basic test for the GUI command. Just tests that it starts up, that we can quit the gui and help

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h:395 + + std::shared_ptr m_gnuDebugDataObjectFile; }; labath wrote: > move this next to other instance variables. Fixed in 0427898acf4

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218300. kwk marked an inline comment as done. kwk added a comment. - Moved and renamed m_gnu_debug_data_object_file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files:

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk marked 5 inline comments as done. kwk added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1849-1851 + if (m_gnuDebugDataObjectFile != nullptr) { +return m_gnuDebugDataObjectFile; + } labath wrote: > Not a big deal, bu

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218299. kwk added a comment. - Move find LZMA section in CMake from LLVM to LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/cmake/modules/LLDBConfig.cmak

[Lldb-commits] [lldb] r370623 - [lldb][NFC] Remove unnecessary lldb_enable_attach in TestMultilineCompletion

Author: teemperor Date: Mon Sep 2 00:40:06 2019 New Revision: 370623 URL: http://llvm.org/viewvc/llvm-project?rev=370623&view=rev Log: [lldb][NFC] Remove unnecessary lldb_enable_attach in TestMultilineCompletion We don't actually need to call this for this test. Modified: lldb/trunk/packag

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218297. kwk marked 3 inline comments as done. kwk added a comment. - Moved .symtab add/replace to OBjectFileELF::CreateSections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D667

[Lldb-commits] [PATCH] D67018: [lldb][NFC] Add basic test for GUI command

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D67018#1653138 , @teemperor wrote: > Given how much fun Pavel had fixing my previous pexpect tests, I thought: > "Why stop the fun after just two te

[Lldb-commits] [PATCH] D65469: Remove `bugreport` command

teemperor added a comment. What's the state of this? Because thi is in my review queue and it has no associated test, so either this moves forward and we remove bugreport or we keep bugreport and I'll put it on my list of things that need tests :) Repository: rLLDB LLDB CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218289. kwk marked 3 inline comments as done. kwk added a comment. - Fix DataExtractor data. llvm does not "always use auto". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218288. kwk added a comment. - add @skipIfLzmaSupportMissing and cleanup - Don't put braces around one statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: ll