labath marked an inline comment as done.
labath added inline comments.
================
Comment at: packages/Python/lldbsuite/test/decorators.py:786
-def skipIfXmlSupportMissing(func):
+def _get_bool_config_decorator(key):
config = lldb.SBDebugger.GetBuildConfiguration()
----------------
jankratochvil wrote:
> I find a bit confusing the function returns opposite of `key` existence but
> its name does not indicate that. The `skipIf` could stay in its name.
>
good point, lemme rename that
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67073/new/
https://reviews.llvm.org/D67073
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
