[Lldb-commits] [PATCH] D65949: unittests: Use yaml2obj as a library instead of an external process

aadsm added a comment. I can see the appeal of having the contents next to the logic that is testing it, but I'm somewhat concerned for the cases where it includes +1000 lines of YAML in the test file. I think for those cases it might make sense to consider these fixtures and be in their own fi

[Lldb-commits] [lldb] r368359 - [lldb][NFC] Modernize IRForTarget::CreateResultVariable

Author: teemperor Date: Thu Aug 8 15:19:16 2019 New Revision: 368359 URL: http://llvm.org/viewvc/llvm-project?rev=368359&view=rev Log: [lldb][NFC] Modernize IRForTarget::CreateResultVariable Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Modified: lldb/trunk/sour

[Lldb-commits] [PATCH] D65965: [lldb] Fix HAVE_LIBCOMPRESSION

This revision was automatically updated to reflect the committed changes. Closed by commit rL368352: [lldb] Fix HAVE_LIBCOMPRESSION (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D65965?v

[Lldb-commits] [lldb] r368353 - [lldb][NFC] Move to StringRef in some places in IRForTarget

Author: teemperor Date: Thu Aug 8 14:43:21 2019 New Revision: 368353 URL: http://llvm.org/viewvc/llvm-project?rev=368353&view=rev Log: [lldb][NFC] Move to StringRef in some places in IRForTarget Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Modified: lldb/trunk/

[Lldb-commits] [lldb] r368346 - [lldb][NFC] Directly use StringRef instead of temporary std::string

Author: teemperor Date: Thu Aug 8 14:22:21 2019 New Revision: 368346 URL: http://llvm.org/viewvc/llvm-project?rev=368346&view=rev Log: [lldb][NFC] Directly use StringRef instead of temporary std::string Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Modified: lld

[Lldb-commits] [lldb] r368345 - SymbolFileDWARF: Unconditionally scan through clang modules. NFCish

Author: adrian Date: Thu Aug 8 14:16:01 2019 New Revision: 368345 URL: http://llvm.org/viewvc/llvm-project?rev=368345&view=rev Log: SymbolFileDWARF: Unconditionally scan through clang modules. NFCish When looking up a type by name, also scan through any referenced Clang modules regardsless of wh

[Lldb-commits] [lldb] r368340 - Fix a comment which was incorrect.

Author: jingham Date: Thu Aug 8 13:47:40 2019 New Revision: 368340 URL: http://llvm.org/viewvc/llvm-project?rev=368340&view=rev Log: Fix a comment which was incorrect. Modified: lldb/trunk/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp Modified: lldb/trunk/source/Plugins/O

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

dblaikie added a comment. Yeah, might be worth changing toStringRef to only accept bools: template typename std::enable_if::value, StringRef>::type toStringRef(T B) { ... } Or something like that? That'd avoid accidental "toStringRef(5)" or the like... CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D65965: [lldb] Fix HAVE_LIBCOMPRESSION

hhb updated this revision to Diff 214212. hhb added a comment. And we should really include Config.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65965/new/ https://reviews.llvm.org/D65965 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemote

[Lldb-commits] [PATCH] D65965: [lldb] Fix HAVE_LIBCOMPRESSION

hhb created this revision. hhb added a reviewer: labath. hhb added a project: LLDB. Herald added a subscriber: lldb-commits. This test doesn't make sense. Change to be consistent with what we did in GDBRemoteCommunication.cpp. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D6596

[Lldb-commits] [PATCH] D65910: Remove unused and undocumented data_offset parameter

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368330: Remove unused and undocumented data_offset parameter (NFC) (authored by adrian, committed by ). Herald added a pro

[Lldb-commits] [lldb] r368330 - Remove unused and undocumented data_offset parameter (NFC)

Author: adrian Date: Thu Aug 8 12:22:32 2019 New Revision: 368330 URL: http://llvm.org/viewvc/llvm-project?rev=368330&view=rev Log: Remove unused and undocumented data_offset parameter (NFC) Value::GetValueAsData() takes an undocumented parameter called data_offset that is always 0. Differentia

[Lldb-commits] [PATCH] D65955: Minidump/Windows: Fix module lookup

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. This looks fine, and thanks for the tests for a one-line fix. I'm curious, though, where is the matching code? Should "unknown" be treated as a wildcard when trying to find the matching m

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

stella.stamenova added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:318 + if(MSVC) +set(flag_werror "/WX") + endif() sgraenitz wrote: > I copied the flag from LLVM. Is it the right one for MSVC? Yes: https://docs.microsoft.com/en-us/cpp/

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

davide added a comment. Did you manage to file a rdar for this issue? If so, can you put the link here for future archeology? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65874/new/ https://reviews.llvm.org/D65874 _

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

davide added a comment. I think this is definitely a good idea but Chandler or DBlaikie might want to take a look at this one too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65942/new/ https://reviews.llvm.org/D65942 ___ lldb-commits ma

[Lldb-commits] [lldb] r368309 - [lldb][NFC] Simplify return in MaybeHandleVariable

Author: teemperor Date: Thu Aug 8 09:41:32 2019 New Revision: 368309 URL: http://llvm.org/viewvc/llvm-project?rev=368309&view=rev Log: [lldb][NFC] Simplify return in MaybeHandleVariable This function anyway returns true, no need to do this extra work. Modified: lldb/trunk/source/Plugins/Exp

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

friss added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp:1388-1391 if (!global_variable->hasExternalLinkage()) return true; else return true; Unrelated to your patch, but this `if` block i

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

friss added a comment. I only have distant notions of what this code does, so this question might be completely off: Is this the code that decides whether we need to rewrite the accesses to a variable to go through the __lldb_args structure? If yes, I was surprised to learn recently that we rew

[Lldb-commits] [PATCH] D65955: Minidump/Windows: Fix module lookup

labath created this revision. labath added reviewers: clayborg, amccarth. Herald added subscribers: kristof.beyls, javed.absar. When opening a minidump, we were failing to find an executable because we were searching for i386-unknown-windows, whereas we recognize the pe/coff files as i386-pc-windo

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

teemperor updated this revision to Diff 214149. teemperor added a reviewer: labath. teemperor added a comment. - Delete the checks instead of adding a type-info exception. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65932/new/ https://reviews.llvm.org/D65932 Files: lldb/packages/Py

[Lldb-commits] [PATCH] D65952: SymbolVendor: Have plugins return symbol files directly

labath created this revision. labath added reviewers: clayborg, JDevlieghere, jingham. Herald added subscribers: MaskRay, arichardson, emaste. Herald added a reviewer: espindola. This is the last patch in the SymbolVendor series. Now that the symbol vendors don't do anything, we can avoid creating

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

teemperor added a comment. > What are the circumstances under which we don't find metadata for a global > variable and we definitely *do* want to report this as an error? The metadata just maps the variables back to the original Clang decls. So if LLDB or Clang fail to register the metadata for

[Lldb-commits] [PATCH] D65872: [lldb][NFC] Check in test case for testing virtual function calls in pointers and references.

teemperor planned changes to this revision. teemperor added a comment. Seems like the radar was actually for something else (covariant returns), so this needs to be updated (as covariant returns are still broken). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm happy with this, and it looks very nice and idiomatic, but maybe wait for @compnerd a bit, as he had some reservations about the whole thing.. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

teemperor added a comment. I'm fine with extending this to all pointers as it doesn't seem to be used in that way anywhere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65942/new/ https://reviews.llvm.org/D65942 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from pointers to bool in llvm::toStringRef

teemperor updated this revision to Diff 214141. teemperor retitled this revision from "Disallow implicit conversion from const char* to bool in llvm::toStringRef" to "Disallow implicit conversion from pointers to bool in llvm::toStringRef". teemperor edited the summary of this revision. teemperor

[Lldb-commits] [PATCH] D65798: [lldb][CMake] Infer `Clang_DIR` if not passed explicitly

sgraenitz updated this revision to Diff 214139. sgraenitz added a comment. Achieve the same via extra `HINT` to `find_package(Clang ...)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65798/new/ https://reviews.llvm.org/D65798 Files: lldb/cmake/

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

This revision was automatically updated to reflect the committed changes. Closed by commit rL368294: [lldb][CMake] Disable modules in Xcode projects (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [lldb] r368294 - [lldb][CMake] Disable modules in Xcode projects

Author: stefan.graenitz Date: Thu Aug 8 06:39:25 2019 New Revision: 368294 URL: http://llvm.org/viewvc/llvm-project?rev=368294&view=rev Log: [lldb][CMake] Disable modules in Xcode projects Summary: Apparently, module-enabled builds clash with Xcode's analysis. Reviewers: aprantl, jingham, david

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

sgraenitz abandoned this revision. sgraenitz added a comment. In D65939#1620780 , @labath wrote: > So, why doesn't LLVM_ENABLE_WERROR suffice? It looks like that ought to work > even in standalone builds... LLVM_ENABLE_WERROR affects the entire build tr

[Lldb-commits] [PATCH] D65949: unittests: Use yaml2obj as a library instead of an external process

labath created this revision. labath added reviewers: JDevlieghere, aadsm. Herald added subscribers: arichardson, mgorny, emaste. Herald added a reviewer: espindola. Herald added a reviewer: jdoerfert. Recently, yaml2obj has been turned into a library. This means we can use it from our unit tests

[Lldb-commits] [lldb] r368289 - ObjectFileELF: Convert a unit test to a lit test

Author: labath Date: Thu Aug 8 05:57:46 2019 New Revision: 368289 URL: http://llvm.org/viewvc/llvm-project?rev=368289&view=rev Log: ObjectFileELF: Convert a unit test to a lit test It is much easier to test this functionality via lldb-test. Added: lldb/trunk/lit/Modules/ELF/aarch64-relocati

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from const char* to bool in llvm::toStringRef

labath added a reviewer: dblaikie. labath added a subscriber: dblaikie. labath added a comment. +@dblaikie. I know who would the llvm owner here be, but he's probably close enough. I think this is definitely a good idea, but I'm wondering if we shouldn't take this one step further, and disallow

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from const char* to bool in llvm::toStringRef

teemperor added a comment. See also https://bugs.llvm.org/show_bug.cgi?id=42895#c11 where we have some of the produced logs that contain 'true' instead of the actual content. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65942/new/ https://reviews.llvm.org/D65

[Lldb-commits] [PATCH] D65942: Disallow implicit conversion from const char* to bool in llvm::toStringRef

teemperor created this revision. teemperor added reviewers: davide, labath. Herald added subscribers: llvm-commits, lldb-commits, dexonsmith. Herald added projects: LLDB, LLVM. We use toStringRef in LLDB in a few places to convert const char* variables to llvm::StringRef. toStringRef however has

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

labath added a comment. I'm not very familiar with this code, so I don't really understand what kind of rewriting it does, or what is this metadata thing, but.. what if we turn this around somehow? What are the circumstances under which we don't find metadata for a global variable and we de

[Lldb-commits] [lldb] r368279 - Fix LLDB_CONFIGURATION_DEBUG builds for the GetSymbolVendor removal

Author: labath Date: Thu Aug 8 04:49:55 2019 New Revision: 368279 URL: http://llvm.org/viewvc/llvm-project?rev=368279&view=rev Log: Fix LLDB_CONFIGURATION_DEBUG builds for the GetSymbolVendor removal fix one usage that is ifdefed-out in non-debug builds. Modified: lldb/trunk/source/Symbol/S

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

labath added a comment. So, why doesn't LLVM_ENABLE_WERROR suffice? It looks like that ought to work even in standalone builds... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65939/new/ https://reviews.llvm.org/D65939 _

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

sgraenitz added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:318 + if(MSVC) +set(flag_werror "/WX") + endif() I copied the flag from LLVM. Is it the right one for MSVC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65939: [lldb][CMake] Add LLDB_ENABLE_WERROR option

sgraenitz created this revision. sgraenitz added reviewers: teemperor, JDevlieghere, davide, labath, stella.stamenova. Herald added a subscriber: mgorny. Herald added a project: LLDB. Treat warnings as errors all over LLDB when enabled. Defaults to `OFF`. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

teemperor added a comment. Maybe to clarify the situation a bit: LLDB thinks the type info variable is a global variable and throws an error because it has no metadata for that variable. This makes sense in most cases, but type info pointers are not global variables that are declared anywhere i

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

teemperor updated this revision to Diff 214102. teemperor added a comment. - Fixed MS mangling detection. - Moved include to top. - Extracted check into own function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65932/new/ https://reviews.llvm.org/D65932 Files: lldb/packages/Python/

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

teemperor added a comment. The whole information we have "@_ZTI4Base = external constant i8*", that there is no metadata and that we call dynamic_cast on it. I don't see a better way for detecting this than actually checking if we are trying to retrieve RTTI info as a global variable. But I agr

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

labath added a comment. (and it won't work on windows, because the msvc demangler will demangle this as "struct Base `RTTI Type Descriptor'") Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65932/new/ https://reviews.llvm.org/D65932 __

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

labath added a comment. This looks like a very hacky way to achieve something. Isn't there some better way to detect this situation? Maybe something to do with the linkage type of these variables? Comment at: lldb/packages/Python/lldbsuite/test/lang/cpp/dynamic_cast/main.cpp

[Lldb-commits] [PATCH] D65874: [lldb][CMake] Disable modules in Xcode projects

teemperor added a comment. Do we have a radar tracking the SourceKit issue? This *should* work and I'm curious if this is actually SourceKit or if this is just a broken LLVM+modules build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65874/new/

[Lldb-commits] [lldb] r368271 - Add a missing include to SymbolFilePDBTests.cpp

Author: labath Date: Thu Aug 8 02:43:20 2019 New Revision: 368271 URL: http://llvm.org/viewvc/llvm-project?rev=368271&view=rev Log: Add a missing include to SymbolFilePDBTests.cpp This should _really_ fix the pdb unit tests. Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.c

[Lldb-commits] [PATCH] D65932: [lldb] Fix dynamic_cast by not treating type info pointers as variables.

teemperor created this revision. teemperor added a reviewer: davide. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. Our IR rewriting infrastructure currently treats type info pointers ('@_ZTI...') as variables it needs to rewrite. This isn't necessary as we don't nee

[Lldb-commits] [PATCH] D65862: Remove xcode-specific Config.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL368266: Remove xcode-specific Config.h (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https:

[Lldb-commits] [lldb] r368266 - Remove xcode-specific Config.h

Author: labath Date: Thu Aug 8 01:27:25 2019 New Revision: 368266 URL: http://llvm.org/viewvc/llvm-project?rev=368266&view=rev Log: Remove xcode-specific Config.h Summary: Now that the xcode project is removed, we no longer need/use the hand-maintained Config.h file, as everything is configured

[Lldb-commits] [lldb] r368265 - Fix PDB unit tests for the GetSymbolVendor deletion

Author: labath Date: Thu Aug 8 01:22:26 2019 New Revision: 368265 URL: http://llvm.org/viewvc/llvm-project?rev=368265&view=rev Log: Fix PDB unit tests for the GetSymbolVendor deletion Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Modified: lldb/trunk/unittests/SymbolF

[Lldb-commits] [PATCH] D65864: Remove Module::GetSymbolVendor

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rL368263: Remove Module::GetSymbolVendor (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [lldb] r368263 - Remove Module::GetSymbolVendor

Author: labath Date: Thu Aug 8 00:34:07 2019 New Revision: 368263 URL: http://llvm.org/viewvc/llvm-project?rev=368263&view=rev Log: Remove Module::GetSymbolVendor Summary: This patch removes the GetSymbolVendor function, and the various mentions of the SymbolVendor in the Module class. The imple

[Lldb-commits] [PATCH] D65864: Remove Module::GetSymbolVendor

labath marked 2 inline comments as done. labath added inline comments. Comment at: include/lldb/Core/Module.h:1006 std::atomic m_did_load_objfile{false}; - std::atomic m_did_load_symbol_vendor{false}; + std::atomic m_did_load_symbol_file{false}; std::atomic m_did_set_uuid