[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm updated this revision to Diff 202654. aadsm added a comment. Missing clang-format-diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm updated this revision to Diff 202652. aadsm added a comment. Address comments and add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62502/new/ https://reviews.llvm.org/D62502 Files: lldb/include/lldb/Host/common/NativeProcessProtocol

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm updated this revision to Diff 202651. aadsm added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62501/new/ https://reviews.llvm.org/D62501 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/source/Plugins

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm updated this revision to Diff 202649. aadsm added a comment. Fix patch snafu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/sourc

[Lldb-commits] [PATCH] D62500: Add support to read aux vector values

aadsm updated this revision to Diff 202642. aadsm added a comment. Address commentds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/sou

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

aadsm marked an inline comment as done. aadsm added inline comments. Comment at: lldb/unittests/tools/lldb-server/tests/CommunicationServerTest.cpp:40-42 +for (size_t i = 0; i < dst_len; i++) { + packet.append(1, *(static_cast(dst) + i)); +} Is ther

[Lldb-commits] [PATCH] D62499: Create a generic handler for Xfer packets

aadsm updated this revision to Diff 202640. aadsm marked an inline comment as done. aadsm added a comment. Herald added a subscriber: mgorny. Address comments and add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62499/new/ https://reviews.ll

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan added a comment. In D62772#1526824 , @compnerd wrote: > This should get the build working again, so lets get this fixed, we can > improve it later Thanks, committed the fix to unblock build. For WoA(ARM32) which is not supported, I meant LLVM Co

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

This revision was automatically updated to reflect the committed changes. Closed by commit rL362349: [COFF, ARM64] Fix CodeView API change for getRegisterNames (authored by TomTan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::SetCompilerTypeFromPersistentDecl

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Commands/CommandObjectMemory.cpp:479 +if (persistent_vars->SetCompilerTypeFromPersistentDecl( +lookup_type_name, clang_ast_type)) + break;

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This should get the build working again, so lets get this fixed, we can improve it later Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::SetCompilerTypeFromPersistentDecl

compnerd added inline comments. Comment at: source/Commands/CommandObjectMemory.cpp:479 +if (persistent_vars->SetCompilerTypeFromPersistentDecl( +lookup_type_name, clang_ast_type)) + break; Why is the parameter `clang_

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::SetCompilerTypeFromPersistentDecl

xiaobai created this revision. xiaobai added reviewers: compnerd, davide, labath, JDevlieghere, aprantl, jingham. Herald added a subscriber: mgorny. PersistentStateExpressions (e.g. ClangPersistentVariables) have the ability to define types using expressions that persist throughout the debugging

[Lldb-commits] [lldb] r362339 - [Commands] Remove unused header

Author: xiaobai Date: Sun Jun 2 14:11:21 2019 New Revision: 362339 URL: http://llvm.org/viewvc/llvm-project?rev=362339&view=rev Log: [Commands] Remove unused header Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp Modified: lldb/trunk/source/Commands/CommandObjectExpression.

[Lldb-commits] [PATCH] D62796: [Target] Generalize some behavior in Target::SymbolsDidLoad

xiaobai created this revision. xiaobai added reviewers: compnerd, JDevlieghere, davide, labath. SymbolsDidLoad is currently only implemented for ObjCLanguageRuntime, but that doesn't mean that it couldn't be useful for other Langauges. Although this change seems like it's generalizing for the sake

[Lldb-commits] [PATCH] D62785: Fix compilation following r362280

aganea abandoned this revision. aganea added a comment. Will be fixed by D62772 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62785/new/ https://reviews.llvm.org/D62785 ___ lldb-co

[Lldb-commits] [PATCH] D62795: [Target] Move ObjCLanguageRuntime::LookupRuntimeSymbol into LanguageRuntime

xiaobai created this revision. xiaobai added reviewers: compnerd, labath, JDevlieghere, davide. LookupRuntimeSymbol seems like a general LanguageRuntime method. Although no other language runtime currently implements this, there's no reason another language runtime couldn't use this. Additionally

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan marked an inline comment as done. TomTan added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29 + llvm::codeview::CPUType cpu_type; + if (arch_type == llvm::Triple::ArchType::aarch64) { +cpu_type = llvm::codeview

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan updated this revision to Diff 202614. TomTan added a comment. Change to switch/case based on comment. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62772/new/ https://reviews.llvm.org/D62772 Files: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDW

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

TomTan marked an inline comment as done. TomTan added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29 + llvm::codeview::CPUType cpu_type; + if (arch_type == llvm::Triple::ArchType::aarch64) { +cpu_type = llvm::codeview

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29 + llvm::codeview::CPUType cpu_type; + if (arch_type == llvm::Triple

[Lldb-commits] [PATCH] D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

compnerd accepted this revision. compnerd added a comment. Generally, `clang-format` the changes, it will catch the formatting things. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:28 + llvm::codeview::CPUType cpu; + switch(arch_type

[Lldb-commits] [PATCH] D62771: [LLDBRegisterNum] Update function call llvm::codeview::getRegisterNames(CPUType) in lldb

mgorny added a comment. As I said on the other patch, I don't believe this belongs in LLDB. Otherwise, you require every user of codeview to maintain and update an accurate mapping of targets currently supported by llvm::codeview. Instead, this should be part of codeview API. Repository: rL

[Lldb-commits] [PATCH] D62772: [COFF, ARM64] Fix CodeView API change for getRegisterNames

aganea added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29 + llvm::codeview::CPUType cpu_type; + if (arch_type == llvm::Triple::ArchType::aarch64) { +cpu_type = llvm::codeview::CPUType::ARM64; Should