compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.
================
Comment at:
source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:29
+ llvm::codeview::CPUType cpu_type;
+ if (arch_type == llvm::Triple::ArchType::aarch64) {
+ cpu_type = llvm::codeview::CPUType::ARM64;
----------------
aganea wrote:
> Shouldn’t ArchType::aarch64_be and ArchType::aarch64_32 enums be handled here
> as well?
I think that we should use a `switch` to cover the targets. `/Oy` will allow
FPO on x86 as well. There is also WoA (ARM32).
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62772/new/
https://reviews.llvm.org/D62772
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
