[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

jingham added a comment. Yeah, I must have not been paying attention at some point in the past. OTOH, I don't know if you can change the access to the ScriptInterpreter in the SB API's, since that seems likely to break people's scripts. Maybe it's better for this patch to add the GetScriptModu

[Lldb-commits] [PATCH] D61101: Hide stderr output from lldb-argdumper

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359156: Hide stderr output from lldb-argdumper (authored by adrian, committed by ). Herald added a subscriber: abidh.

[Lldb-commits] [lldb] r359156 - Hide stderr output from lldb-argdumper

Author: adrian Date: Wed Apr 24 16:52:27 2019 New Revision: 359156 URL: http://llvm.org/viewvc/llvm-project?rev=359156&view=rev Log: Hide stderr output from lldb-argdumper Under very specific circumstances the default shell /bin/sh might print stuff to stderr before launching lldb-argdumper, whic

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

JDevlieghere added a comment. In D61090#1477912 , @jingham wrote: > It seems weird to be getting the ScriptInterpreter's ScriptModuleDirectory > from the CommandInterpreter. I would have expected: > > m_debugger.GetScriptInterpreter().GetScriptModuleDire

[Lldb-commits] [PATCH] D61056: PostfixExpression: move DWARF generator out of NativePDB internals

amccarth added a comment. Can the test deletions be a separate patch, or will they fail because of the other changes in this patch? They feel like a good but separable step. Comment at: include/lldb/Symbol/PostfixExpression.h:210 + + bool Visit(UnaryOpNode &unary, Node *&ref

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

jingham added a comment. It seems weird to be getting the ScriptInterpreter's ScriptModuleDirectory from the CommandInterpreter. I would have expected: m_debugger.GetScriptInterpreter().GetScriptModuleDirectory() I don't think there's any reason to have the Command Interpreter know which Scri

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

JDevlieghere added a comment. (I didn't yet, but I'll cleanup the references to Python in the driver if people like this approach.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61090/new/ https://reviews.llvm.org/D61090 ___ lldb-commits m

[Lldb-commits] [PATCH] D61101: Hide stderr output from lldb-argdumper

clayborg added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61101/new/ https://reviews.llvm.org/D61101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

JDevlieghere updated this revision to Diff 196545. JDevlieghere added a comment. Deprecate the current method in `SBHostOS` and provide an alternative through `SBCommandInterpreter::GetModuleDirectory` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61090/new/ https://reviews.llvm.org/D6

[Lldb-commits] [PATCH] D61101: Hide stderr output from lldb-argdumper

aprantl created this revision. aprantl added reviewers: jasonmolenda, jingham. Herald added a project: LLDB. Under very specific circumstances the default shell `/bin/sh` might print stuff to stderr before launching lldb-argdumper, which then confuses the JSON parser. This patch suppresses stder

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

clayborg added a comment. In D61090#1477709 , @davide wrote: > @clayborg I would also like to point out that some of us fair amount of time > cleaning `LLDB_DISABLE_PYTHON` leaking all over the codebase, and this is > basically the last occurrence, so we

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

jingham added a comment. BTW, congrats on getting rid of all the LLDB_DISABLE_PYTHON uses. That was a goodly chunk of work and removed an obvious wart. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61090/new/ https://reviews.llvm.org/D61090 ___

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

jingham requested changes to this revision. jingham added a comment. I agree with Greg, I really don't want to lose the "lldb -P" functionality. That's quite handy. Seems to me that if lldb wants to provide a scripting module for some scripting language, that language would need to know where

[Lldb-commits] [lldb] r359145 - Skip test introduced in r359140 on windows

Author: friss Date: Wed Apr 24 15:00:01 2019 New Revision: 359145 URL: http://llvm.org/viewvc/llvm-project?rev=359145&view=rev Log: Skip test introduced in r359140 on windows Not sure what is or is not supposed to work on Windows and I have no way to investigate this. Modified: lldb/trunk/p

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

davide added a comment. @clayborg I would also like to point out that some of us fair amount of time cleaning `LLDB_DISABLE_PYTHON` leaking all over the codebase, and this is basically the last occurrence, so we're motivated to have this going away/fixed in some way. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

davide added a comment. While the intentions of exposing this are good, the implementation leaks too many details. In fact, there shouldn't be anything outside of ScriptInterpreter guarded by `LLDB_DISABLE_PYTHON`. You might want also to realize that having `ePathTypePythonDir` goes against the

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

clayborg added a comment. People use this to populate the extra system path in python scripts when "import lldb" fails and throws an exception as you can run "lldb -P" to get the python path for the lldb module for the current lldb in your path. Repository: rLLDB LLDB CHANGES SINCE LAST ACT

[Lldb-commits] [lldb] r359141 - [SystemInitializerFull] Fix header sorting (NFC)

Author: jdevlieghere Date: Wed Apr 24 14:23:08 2019 New Revision: 359141 URL: http://llvm.org/viewvc/llvm-project?rev=359141&view=rev Log: [SystemInitializerFull] Fix header sorting (NFC) Made some changes downstream that touched the header sorting. Modified: lldb/trunk/source/API/SystemInit

[Lldb-commits] [PATCH] D61044: Fix infinite recursion when calling C++ template functions

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB359140: Fix infinite recursion when calling C++ template functions (authored by friss, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to commit: htt

[Lldb-commits] [lldb] r359140 - Fix infinite recursion when calling C++ template functions

Author: friss Date: Wed Apr 24 14:04:23 2019 New Revision: 359140 URL: http://llvm.org/viewvc/llvm-project?rev=359140&view=rev Log: Fix infinite recursion when calling C++ template functions Summary: When we encounter a templated function in the debug information, we were creating an AST that loo

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

JDevlieghere created this revision. JDevlieghere added a reviewer: davide. JDevlieghere added a project: LLDB. Herald added a subscriber: abidh. This is clearly a layering violation and there's no good way to fix this. The value it adds is limited, people can use the `$PYTHONPATH` or call the co

[Lldb-commits] [lldb] r359138 - [ScriptInterpreterPython] find_first_of -> find (NFC)

Author: jdevlieghere Date: Wed Apr 24 13:40:24 2019 New Revision: 359138 URL: http://llvm.org/viewvc/llvm-project?rev=359138&view=rev Log: [ScriptInterpreterPython] find_first_of -> find (NFC) Follow up to r357198. Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpret

[Lldb-commits] [PATCH] D61072: [lldb] [lit] Add tests for reading new x86_64 registers

mgorny updated this revision to Diff 196502. mgorny added a comment. Fixed unnecessary array in xmm_t decls. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61072/new/ https://reviews.llvm.org/D61072 Files: lldb/lit/Register/Inputs/x86-64-read.cpp lldb/lit/Register/x86-64-read.test

[Lldb-commits] [PATCH] D61074: [lldb] [lit] Add register read tests for YMM registers (AVX)

mgorny updated this revision to Diff 196503. mgorny added a comment. Fixed unnecessary array in ymm_t decls. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61074/new/ https://reviews.llvm.org/D61074 Files: lldb/lit/Register/Inputs/x86-ymm-read.cpp lldb/lit/Register/x86-ymm-read.test

[Lldb-commits] [PATCH] D61085: [lldb] [lit] Remove unnecessary array use in XMM reading test

mgorny created this revision. mgorny added reviewers: labath, zturner, krytarowski. Remove the use of 2-element array for XMM data. It is an accidental leftover from previous implementation attempt, and it is unnecessary with xmm_t. https://reviews.llvm.org/D61085 Files: lldb/lit/Register/In

[Lldb-commits] [lldb] r359130 - add postfixexpression.cpp.

Author: jmolenda Date: Wed Apr 24 12:50:53 2019 New Revision: 359130 URL: http://llvm.org/viewvc/llvm-project?rev=359130&view=rev Log: add postfixexpression.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://llvm.org/view

[Lldb-commits] [PATCH] D61044: Fix infinite recursion when calling C++ template functions

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This seems like an okay workaround. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61044/new/ https://reviews.llvm.org/D61044 ___ lldb-

[Lldb-commits] [lldb] r359124 - [EditLineTests] Call setenv() before editline is initialized.

Author: davide Date: Wed Apr 24 11:39:39 2019 New Revision: 359124 URL: http://llvm.org/viewvc/llvm-project?rev=359124&view=rev Log: [EditLineTests] Call setenv() before editline is initialized. Modified: lldb/trunk/unittests/Editline/EditlineTest.cpp Modified: lldb/trunk/unittests/Editline/

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

This revision was automatically updated to reflect the committed changes. Closed by commit rL359120: [lldb] Use local definition of get_cpuid_count (authored by josepht, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[Lldb-commits] [PATCH] D61044: Fix infinite recursion when calling C++ template functions

clayborg added a comment. Love having the AST output available so we can compare real to DWARF converted stuff! LGTM. Jim should ok too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61044/new/ https://reviews.llvm.org/D61044 ___ lldb-com

[Lldb-commits] [PATCH] D60588: Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix

This revision was automatically updated to reflect the committed changes. Closed by commit rL359118: [DataFormatters] Adjusting libc++ std::list formatter to act better with… (authored by shafik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [lldb] r359118 - [DataFormatters] Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix

Author: shafik Date: Wed Apr 24 10:38:40 2019 New Revision: 359118 URL: http://llvm.org/viewvc/llvm-project?rev=359118&view=rev Log: [DataFormatters] Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix Summary: This pr

[Lldb-commits] [PATCH] D61064: Object/Minidump: Add support for the ThreadList stream

clayborg added a comment. LGTM, but since in llvm someone else should ok too. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61064/new/ https://reviews.llvm.org/D61064 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

amccarth added a comment. Thanks Pavel! Please address Pavel's inline comments, and I'll accept this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 ___ lldb-commits maili

[Lldb-commits] [PATCH] D61074: [lldb] [lit] Add register read tests for YMM registers (AVX)

mgorny created this revision. mgorny added reviewers: labath, zturner, krytarowski. Herald added a subscriber: delcypher. mgorny added a parent revision: D61073: [lldb] [lit] Add feature flags for native CPU features. https://reviews.llvm.org/D61074 Files: lldb/lit/Register/Inputs/x86-ymm-read

[Lldb-commits] [PATCH] D61073: [lldb] [lit] Add feature flags for native CPU features

mgorny created this revision. mgorny added reviewers: labath, zturner, krytarowski. Herald added a subscriber: delcypher. Add a new lit-cpuid tool that detects CPU features used by some of the tests, and use it to populate available_features in lit. For now, this means that the test for MM/XMM re

[Lldb-commits] [PATCH] D61072: [lldb] [lit] Add tests for reading new x86_64 registers

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a subscriber: teemperor. Herald added a project: LLDB. Add tests covering read operations for the general-purpose and XMM registers added in x86_64 (r8-r15 and xmm8-xmm15). Repository: rLLDB LLDB https://r

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

JosephTremoulet added a comment. Switched to static function, and yes I do have commit access. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61036/new/ https://reviews.llvm.org/D61036

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

JosephTremoulet updated this revision to Diff 196459. JosephTremoulet added a comment. - Use static function rather than anonymous namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61036/new/ https://reviews.llvm.org/D61036 Files: lldb/sou

[Lldb-commits] [PATCH] D61000: Kill modify-python-lldb.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL359092: Kill modify-python-lldb.py (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D61000?vs

[Lldb-commits] [lldb] r359092 - Kill modify-python-lldb.py

Author: labath Date: Wed Apr 24 06:23:19 2019 New Revision: 359092 URL: http://llvm.org/viewvc/llvm-project?rev=359092&view=rev Log: Kill modify-python-lldb.py Summary: After the last round of cleanups, this script was almost a no-op. The only piece of functionality that remained was the one whic

[Lldb-commits] [PATCH] D61064: Object/Minidump: Add support for the ThreadList stream

labath created this revision. labath added reviewers: amccarth, jhenderson, clayborg. Herald added a project: LLVM. The stream contains the list of threads belonging to the process described by the minidump. Its structure is the same as the ModuleList stream, and in fact, I have generalized the Mo

[Lldb-commits] [lldb] r359089 - Minor code style fix in ClangUserExpression.cpp [NFC]

Author: teemperor Date: Wed Apr 24 05:55:00 2019 New Revision: 359089 URL: http://llvm.org/viewvc/llvm-project?rev=359089&view=rev Log: Minor code style fix in ClangUserExpression.cpp [NFC] Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified: lldb/tru

[Lldb-commits] [lldb] r359087 - Shorten comment line to be below 80 characters [NFC]

Author: teemperor Date: Wed Apr 24 05:21:03 2019 New Revision: 359087 URL: http://llvm.org/viewvc/llvm-project?rev=359087&view=rev Log: Shorten comment line to be below 80 characters [NFC] Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified: lldb/trun

[Lldb-commits] [lldb] r359074 - yamlify lit/Minidump tests

Author: labath Date: Wed Apr 24 01:09:36 2019 New Revision: 359074 URL: http://llvm.org/viewvc/llvm-project?rev=359074&view=rev Log: yamlify lit/Minidump tests Replace checked-in binaries by their yaml equivalents. Added: lldb/trunk/lit/Minidump/Inputs/linux-x86_64.yaml Removed: lldb/tru

[Lldb-commits] [PATCH] D61056: PostfixExpression: move DWARF generator out of NativePDB internals

labath created this revision. labath added reviewers: amccarth, clayborg, aleksandr.urakov. Herald added a subscriber: aprantl. The new dwarf generator is pretty much a verbatim copy of the one in PDB. In order to write a pdb-independent test for it, I needed to write a dummy "symbol resolver", w

[Lldb-commits] [PATCH] D61003: PostfixExpression: move parser out of NativePDB internals

This revision was automatically updated to reflect the committed changes. Closed by commit rL359073: PostfixExpression: move parser out of NativePDB internals (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[Lldb-commits] [lldb] r359073 - PostfixExpression: move parser out of NativePDB internals

Author: labath Date: Wed Apr 24 00:27:05 2019 New Revision: 359073 URL: http://llvm.org/viewvc/llvm-project?rev=359073&view=rev Log: PostfixExpression: move parser out of NativePDB internals Summary: The postfix expressions in PDB and breakpad symbol files are similar enough that they can be pars

[Lldb-commits] [PATCH] D61036: [lldb] Use local definition of get_cpuid_count

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The chosen approach looks fine to me. The only nit I have is that llvm style prefers `static` functions over ones in anonymous namespaces (though this file is not very consistent in that aspec

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

labath added a comment. The problem I have is that PDB is not following the lldb convention of doing the symbol file search inside a SymbolVendor class (which should really be called a SymbolFinder), but instead they implement their own little symbol vendor privately. There are reasons which ma