labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
The chosen approach looks fine to me. The only nit I have is that llvm style prefers `static` functions over ones in anonymous namespaces (though this file is not very consistent in that aspect already). Do you have commit access or shall I commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61036/new/ https://reviews.llvm.org/D61036 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
