[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

aleksandr.urakov accepted this revision. aleksandr.urakov added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60068/new/ https://reviews.llvm.org/D60068 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea marked an inline comment as done. aganea added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility. templ

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

aganea added inline comments. Comment at: llvm/include/llvm/DebugInfo/CodeView/CVRecord.h:29 +/// Carrying the size separately instead of trusting the size stored in the +/// record prefix provides some extra safety and flexibility. template class CVRecord { To

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

clayborg updated this revision to Diff 193198. clayborg marked 2 inline comments as done. clayborg added a comment. Fix comments and address review issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60001/new/ https://reviews.llvm.org/D60001 Files: packages/Python/lldbsuite/test/

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

clayborg marked 3 inline comments as done. clayborg added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:391 +// add the module to the target if it finds one, so we might need to remove +// it if there is an error. lldb::ModuleSP mod

[Lldb-commits] [PATCH] D60018: [codeview] Remove Type member from CVRecord

rnk updated this revision to Diff 193191. rnk marked 2 inline comments as done. rnk added a comment. Herald added subscribers: lldb-commits, cfe-commits, kadircet, arphaman, jkorous. Herald added projects: clang, LLDB. - fix one lldb usage Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [lldb] r357431 - [CMake] Only the Python scirpt interpreter should link against Python.

Author: jdevlieghere Date: Mon Apr 1 15:03:04 2019 New Revision: 357431 URL: http://llvm.org/viewvc/llvm-project?rev=357431&view=rev Log: [CMake] Only the Python scirpt interpreter should link against Python. This patch removes spurious links against Python. Modified: lldb/trunk/unittests/I

[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

amccarth accepted this revision. amccarth added inline comments. Comment at: source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:287 + + // lookup register reference as lvalue in preceding assignments + auto it = m_dependent_programs.find(symbol->GetName());

[Lldb-commits] [PATCH] D60092: [Process] Use early returns in Process::WriteMemory (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL357428: [Process] Use early returns in Process::WriteMemory (NFC) (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r357428 - [Process] Use early returns in Process::WriteMemory (NFC)

Author: jdevlieghere Date: Mon Apr 1 13:39:03 2019 New Revision: 357428 URL: http://llvm.org/viewvc/llvm-project?rev=357428&view=rev Log: [Process] Use early returns in Process::WriteMemory (NFC) I found the code of Process::WriteMemory particularly hard to follow when reviewing Ismail's change

[Lldb-commits] [PATCH] D59849: [lldb-vscode] Add logic to handle EOF when reading from lldb-vscode stdout.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357426: [lldb-vscode] Add logic to handle EOF when reading from lldb-vscode stdout. (authored by jgorbe, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[Lldb-commits] [lldb] r357426 - [lldb-vscode] Add logic to handle EOF when reading from lldb-vscode stdout.

Author: jgorbe Date: Mon Apr 1 13:37:22 2019 New Revision: 357426 URL: http://llvm.org/viewvc/llvm-project?rev=357426&view=rev Log: [lldb-vscode] Add logic to handle EOF when reading from lldb-vscode stdout. Summary: This change prevents the lldb-vscode test harness from hanging up waiting for n

[Lldb-commits] [PATCH] D60092: [Process] Use early returns in Process::WriteMemory (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60092/new/ https://reviews.llvm.org/D60092 ___ lldb-commits mail

[Lldb-commits] [PATCH] D60092: [Process] Use early returns in Process::WriteMemory (NFC)

mib added a comment. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60092/new/ https://reviews.llvm.org/D60092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D60092: [Process] Use early returns in Process::WriteMemory (NFC)

davide added a comment. LGTM. Med, what do you think? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60092/new/ https://reviews.llvm.org/D60092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D60092: [Process] Use early returns in Process::WriteMemory (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: mib, davide. Herald added a subscriber: abidh. Herald added a project: LLDB. I found the code of Process::WriteMemory particularly hard to follow when reviewing Ismail's change in D60022 . This sim

[Lldb-commits] [lldb] r357424 - [API] Add SBReproducer to LLDB.h

Author: jdevlieghere Date: Mon Apr 1 12:56:15 2019 New Revision: 357424 URL: http://llvm.org/viewvc/llvm-project?rev=357424&view=rev Log: [API] Add SBReproducer to LLDB.h Modified: lldb/trunk/include/lldb/API/LLDB.h Modified: lldb/trunk/include/lldb/API/LLDB.h URL: http://llvm.org/viewvc/l

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

labath added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:390-391 +// Try and find a module with a full UUID that matches. This function will +// add the module to the target if it finds one, so we might need to remove +// it if the

[Lldb-commits] [PATCH] D53412: [lldb] Fixed deadlock when SBProcess is Kill()ed and inspected

cameron314 added a comment. In D53412#1450182 , @clayborg wrote: > All of these are in SBProcess. No need to change everywhere else, I just see > a ton of duplicated code here in the SBProcess.cpp. If we contain those in a > small struct/class, then we c

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

This revision was automatically updated to reflect the committed changes. Closed by commit rL357420: [Process] Fix WriteMemory return value (authored by mib, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60022/new/ https://reviews.llvm.org/D60022 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

jasonmolenda marked an inline comment as done. jasonmolenda added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py:19-20 +target = self.dbg.CreateTarget('') +if self.TraceOn(): +self.runC

[Lldb-commits] [PATCH] D53412: [lldb] Fixed deadlock when SBProcess is Kill()ed and inspected

clayborg added a comment. In general any call that is doing anything through the public API needs to take the target API mutex. It is ok for quick accessors or other things to not do so, but anything that would need to keep the process in its current state, like asking a frame for a register va

[Lldb-commits] [PATCH] D53412: [lldb] Fixed deadlock when SBProcess is Kill()ed and inspected

clayborg added a comment. Added Jim Ingham in case he wants to chime in here. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53412/new/ https://reviews.llvm.org/D53412 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D53412: [lldb] Fixed deadlock when SBProcess is Kill()ed and inspected

clayborg added a comment. All of these are in SBProcess. No need to change everywhere else, I just see a ton of duplicated code here in the SBProcess.cpp. If we contain those in a small struct/class, then we can easily make changes as needed without 50 diffs in this file each time. So no need t

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

clayborg updated this revision to Diff 193125. clayborg added a comment. Fixed the requested issues. This patch is small and self contained and fixes the issue with partial UUID matching so I would like to start with this and iterate on the other features you mentioned with subsequent patches if

[Lldb-commits] [PATCH] D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357399: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D60034?vs=193020&id=193092#toc Repository:

[Lldb-commits] [lldb] r357399 - [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps

Author: mgorny Date: Mon Apr 1 08:08:24 2019 New Revision: 357399 URL: http://llvm.org/viewvc/llvm-project?rev=357399&view=rev Log: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps Include support for NetBSD core dumps from evbarm/aarch64 system, and matching test cases for them. Bas

[Lldb-commits] [PATCH] D60068: PDBFPO: Refactor register reference resolution

labath created this revision. labath added reviewers: aleksandr.urakov, zturner, amccarth. Herald added a subscriber: jdoerfert. This refactors moves the register name->number resolution out of the FPOProgramNodeRegisterRef class. Instead I create a special FPOProgramNodeSymbol class, which holds

[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

labath added a comment. James, do you have any thoughts on this? I think the minidump-specific changes are all pretty straight-forward here, so the thing I'm most interested in is whether this is ok from a obj2yaml perspective. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D60001: Allow partial UUID matching in Minidump core file plug-in

labath added inline comments. Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:394 +if (error.Fail()) { + GetTarget().GetImages().Remove(module_sp); + module_sp.reset(); clayborg wrote: > labath wrote: > > Under what circumstances can

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

labath added a comment. Thank you for the quick review. In D59991#1448852 , @davezarzycki wrote: > Can we cherry-pick this into a release branch? Skylake (and newer) CPUs are > far from rare these days, especially on cloud hosting providers. I think c

[Lldb-commits] [PATCH] D59991: [Linux/x86] Fix writing of non-gpr registers on newer processors

This revision was automatically updated to reflect the committed changes. Closed by commit rL357376: [Linux/x86] Fix writing of non-gpr registers on newer processors (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [lldb] r357376 - [Linux/x86] Fix writing of non-gpr registers on newer processors

Author: labath Date: Mon Apr 1 01:11:46 2019 New Revision: 357376 URL: http://llvm.org/viewvc/llvm-project?rev=357376&view=rev Log: [Linux/x86] Fix writing of non-gpr registers on newer processors Summary: We're using ptrace(PTRACE_SETREGSET, NT_X86_XSTATE) to write all non-gpt registers on x86