[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

mgorny added a comment. Is there a reason you can't reuse/extend `DynamicLibrary` from `LLVMSupport`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59854/new/ https://reviews.llvm.org/D59854 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere updated this revision to Diff 192392. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. `data()` -> `str().c_str()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59854/new/ https://reviews.llvm.org/D59854 Files: lldb/include/lldb/Host/LibraryLo

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

jingham added a comment. In D59854#1443915 , @zturner wrote: > In D59854#1443906 , @jingham wrote: > > > In D59854#1443904 , @JDevlieghere > > wrote: > > > > > In D59854#144

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

zturner added a comment. In D59854#1443906 , @jingham wrote: > In D59854#1443904 , @JDevlieghere > wrote: > > > In D59854#1443891 , @jingham wrote: > > > > > It isn't safe t

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

jingham added a comment. In D59854#1443904 , @JDevlieghere wrote: > In D59854#1443891 , @jingham wrote: > > > It isn't safe to pass "data()" of a StringRef to dlsym. > > > Why? StringRef's aren't guaranteed to be

[Lldb-commits] [PATCH] D59847: Regression test to ensure that we handling importing of std::vector of enums correctly

friss added a comment. As we're just adding test coverage, could we add a little more? - Anonymous enum - Enum through a typedef - class enum - enum declared inside of the function rather than at the top-level - nested enum in a record type - enum nested in a templated class - anything else I hav

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere added a comment. Thanks for the review, Adrian! Comment at: lldb/include/lldb/Host/LibraryLoader.h:17 +public: + LibraryLoader(const char *library, bool close = true); + ~LibraryLoader(); amccarth wrote: > amccarth wrote: > > I'm curious why anyo

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere added a comment. In D59854#1443891 , @jingham wrote: > It isn't safe to pass "data()" of a StringRef to dlsym. Why? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59854/new/ https://reviews.llvm.org/D59854 __

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere updated this revision to Diff 192388. JDevlieghere marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59854/new/ https://reviews.llvm.org/D59854 Files: lldb/include/lldb/Host/LibraryLoader.h lldb/source/Host/CMakeLists.txt lldb/source/Host/

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

jingham added a comment. It isn't safe to pass "data()" of a StringRef to dlsym. Also, it's a little weird that the library name is a "const char *" but the symbol name is a StringRef? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59854/new/ https://reviews.l

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

amccarth added a comment. The Windows code looks correct to me, but I've added a couple inline questions/comments. I can patch it in and test it for you tomorrow morning if nobody else has done it by then. I think zturner's still on vacation for another day or two. Comment

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

JDevlieghere created this revision. JDevlieghere added reviewers: zturner, stella.stamenova, davide. Herald added a subscriber: mgorny. Herald added a project: LLDB. JDevlieghere added a reviewer: labath. Since there's no dlopen on Windows, we need a cross platform abstraction. The LibraryLoader

Re: [Lldb-commits] [lldb] r357034 - [Python] Remove dynamic indirection

This is great! On Tue, Mar 26, 2019 at 2:55 PM Jonas Devlieghere via lldb-commits wrote: > > Author: jdevlieghere > Date: Tue Mar 26 14:57:02 2019 > New Revision: 357034 > > URL: http://llvm.org/viewvc/llvm-project?rev=357034&view=rev > Log: > [Python] Remove dynamic indirection > > Now that the

[Lldb-commits] [lldb] r357037 - Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

Author: dexonsmith Date: Tue Mar 26 15:18:52 2019 New Revision: 357037 URL: http://llvm.org/viewvc/llvm-project?rev=357037&view=rev Log: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC Remove CompilerInstance::VirtualFileSystem and CompilerInstance::setVirtualFileSystem, instead relying

[Lldb-commits] [PATCH] D59850: [Platform] Remove Kalimba Platform

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: jdoerfert, MaskRay, arichardson, mgorny, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. Yesterday I stumbled upon the initialization code for the "Kalimba" platform. It lo

[Lldb-commits] [lldb] r357034 - [Python] Remove dynamic indirection

Author: jdevlieghere Date: Tue Mar 26 14:57:02 2019 New Revision: 357034 URL: http://llvm.org/viewvc/llvm-project?rev=357034&view=rev Log: [Python] Remove dynamic indirection Now that the Python plugin relies on the SWIG symbols, we no longer need to dynamically resolve these functions. Modified

[Lldb-commits] [PATCH] D59849: [lldb-vscode] Add logic to handle EOF when reading from lldb-vscode stdout.

jgorbe created this revision. jgorbe added reviewers: clayborg, zturner. Herald added a project: LLDB. This change prevents the lldb-vscode test harness from hanging up waiting for new messages when the lldb-vscode subprocess crashes. Now, when an EOF from the subprocess pipe is detected we enque

[Lldb-commits] [PATCH] D59847: Regression test to ensure that we handling importing of std::vector of enums correctly

shafik created this revision. shafik added reviewers: aprantl, friss, teemperor. Herald added a subscriber: jdoerfert. https://reviews.llvm.org/D59845 added a fix for the `IsStructuralMatch(...)` specialization for `EnumDecl` this test should pass once this fix is committed. https://reviews.llv

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357030: [ExpressionParser] Add swift-lldb case for finding clang resource dir (authored by xiaobai, committed by ). Herald added a subscriber: teemperor. Herald added a project: LLDB. Changed prior to

[Lldb-commits] [lldb] r357030 - [ExpressionParser] Add swift-lldb case for finding clang resource dir

Author: xiaobai Date: Tue Mar 26 14:00:42 2019 New Revision: 357030 URL: http://llvm.org/viewvc/llvm-project?rev=357030&view=rev Log: [ExpressionParser] Add swift-lldb case for finding clang resource dir Summary: I'm adding this to reduce the difference between swift-lldb and llvm.org's lldb. Re

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

labath added a comment. In D55718#1443487 , @clayborg wrote: > As long as the numbers _can_ still come from the GDB server, I am all for > that. If they are not supplied, then we use arch defaults. That allows new > system/arch bringups where the info mi

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

jasonmolenda added a comment. In D55718#1443487 , @clayborg wrote: > As long as the numbers _can_ still come from the GDB server, I am all for > that. If they are not supplied, then we use arch defaults. That allows new > system/arch bringups where the i

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added a comment. As long as the numbers _can_ still come from the GDB server, I am all for that. If they are not supplied, then we use arch defaults. That allows new system/arch bringups where the info might be changing often, and also allows the info to be locked down. The architectur

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

labath added a comment. In D55718#1443415 , @jasonmolenda wrote: > In D55718#1442965 , @clayborg wrote: > > > It would be really nice to get the GDB remote server for ARC so that it > > vends the correct regs to b

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

jasonmolenda added a comment. In D55718#1442965 , @clayborg wrote: > It would be really nice to get the GDB remote server for ARC so that it vends > the correct regs to begin with, but if that isn't possible I guess we need to > do what we are doing here

[Lldb-commits] [PATCH] D59831: [CMake] macOS: Find DebugSymbols.framework inside the SDK

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59831/new/ https://reviews.llvm.org/D59831 ___ lldb-commits

[Lldb-commits] [PATCH] D59495: Fix an out-of-bounds error in RegisterContextDarwin_arm64

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for not weighing in earlier, yes this is good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59495/new/ https://reviews.llvm.org/D59495 __

[Lldb-commits] [PATCH] D59708: [ExpressionParser] Add swift-lldb case for finding clang resource dir

xiaobai added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangHost.cpp:42 /// This will compute the clang resource directory assuming that clang was -/// installed with the same prefix as lldb. +/// installed with the same prefix as lldb. Note: the verify

[Lldb-commits] [PATCH] D59831: [CMake] macOS: Find DebugSymbols.framework inside the SDK

jordan_rose created this revision. jordan_rose added reviewers: jingham, davide, sgraenitz. jordan_rose added a project: LLDB. Herald added a subscriber: mgorny. It's always going to be at / on disk, but that's not what we should be linking against! This won't actually change anything in practice

[Lldb-commits] [PATCH] D59828: Add lldb-vscode as a dependency of lldb tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357016: Add lldb-vscode as a dependency of lldb tests. (authored by jgorbe, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[Lldb-commits] [lldb] r357016 - Add lldb-vscode as a dependency of lldb tests.

Author: jgorbe Date: Tue Mar 26 11:36:44 2019 New Revision: 357016 URL: http://llvm.org/viewvc/llvm-project?rev=357016&view=rev Log: Add lldb-vscode as a dependency of lldb tests. Summary: In the current state, 'ninja check-lldb' runs the lldb-vscode tests, but it won't rebuild lldb-vscode if any

[Lldb-commits] [PATCH] D59828: Add lldb-vscode as a dependency of lldb tests.

jgorbe created this revision. jgorbe added a reviewer: clayborg. Herald added a subscriber: mgorny. Herald added a project: LLDB. In the current state, 'ninja check-lldb' runs the lldb-vscode tests, but it won't rebuild lldb-vscode if any of its sources has changed. This is very confusing when you

[Lldb-commits] [lldb] r357006 - [ScriptInterpreterPython] Try to make the sanitizer bot green again.

Author: davide Date: Tue Mar 26 09:43:58 2019 New Revision: 357006 URL: http://llvm.org/viewvc/llvm-project?rev=357006&view=rev Log: [ScriptInterpreterPython] Try to make the sanitizer bot green again. Removing a use-after-free error. Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Py

[Lldb-commits] [PATCH] D59826: [expression] Explicitly build the lookup table of any TagDecl's context

clayborg added a comment. Might be good for Jim Ingham to look at this as well? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59826/new/ https://reviews.llvm.org/D59826 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D59826: [expression] Explicitly build the lookup table of any TagDecl's context

martong added a comment. There is a lookup failure within the ASTImporter during the expression evaluation. The clang::ASTImporter cannot lookup previously created declarations thus it creates duplicated and redundant declarations. These duplicated declarations then later can cause different asser

[Lldb-commits] [PATCH] D59584: python 2/3 compat: commands vs subprocess

This revision was automatically updated to reflect the committed changes. Closed by commit rL356995: python 2/3 compat: commands vs subprocess (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[Lldb-commits] [PATCH] D59775: Minidump: Add support for reading/writing strings

clayborg added a comment. Looks fine to me, but probably need a LLVM specific person for the final ok Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59775/new/ https://reviews.llvm.org/D59775 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D59819: Make operator==s consistent between c++ and python APIs

labath marked 2 inline comments as done. labath added inline comments. Comment at: include/lldb/API/SBAddress.h:34-37 + // operator== is a free function + + bool operator!=(const SBAddress &rhs) const; + A different solution to this could be to still keep the f

[Lldb-commits] [PATCH] D59819: Make operator==s consistent between c++ and python APIs

labath created this revision. labath added reviewers: jingham, clayborg, zturner. Herald added a subscriber: jdoerfert. modify-python-lldb.py had code to insert python equality operators to some classes. Some of those classes already had c++ equality operators, and some didn't. This makes the sit

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added a comment. It would be really nice to get the GDB remote server for ARC so that it vends the correct regs to begin with, but if that isn't possible I guess we need to do what we are doing here. I would really like to not see more architectures have to add code to ProcessGDBRemote

[Lldb-commits] [PATCH] D59495: Fix an out-of-bounds error in RegisterContextDarwin_arm64

clayborg added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59495/new/ https://reviews.llvm.org/D59495 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D59414: Remove the TypePair class

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356993: Remove the TypePair class (authored by labath, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59414?vs=190823&id=192266#toc Repository: rL

[Lldb-commits] [lldb] r356993 - Remove the TypePair class

Author: labath Date: Tue Mar 26 06:35:54 2019 New Revision: 356993 URL: http://llvm.org/viewvc/llvm-project?rev=356993&view=rev Log: Remove the TypePair class Summary: After D59297, the TypePair class kind of lost its purpose as it was no longer a "pair". This finishes the job started in that pat

[Lldb-commits] [PATCH] D59495: Fix an out-of-bounds error in RegisterContextDarwin_arm64

labath added a comment. Jason, what do you make of this? I believe the fix is pretty straight-forward, but since this does actually change behaviour, I think it would be good if you had a quick look at it first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59495/new/ https://reviews.

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. Herald added a subscriber: jdoerfert. Kind reminder. I believe all discussions have been resolved. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 ___

[Lldb-commits] [lldb] r356992 - Minidump: Use minidump types defined in llvm

Author: labath Date: Tue Mar 26 06:23:01 2019 New Revision: 356992 URL: http://llvm.org/viewvc/llvm-project?rev=356992&view=rev Log: Minidump: Use minidump types defined in llvm This is the next step in moving the minidump parsing into llvm. I remove the minidump structures already defined in the

[Lldb-commits] [PATCH] D59719: [ScriptInterpreter] Make sure that PYTHONHOME is right.

labath added a comment. In D59719#1442563 , @davide wrote: > In D59719#1441254 , @labath wrote: > > > It sounds to me like you could achieve the same thing by generalizing the > > LLDB_PYTHON_HOME logic in LLDBConf