jordan_rose created this revision.
jordan_rose added reviewers: jingham, davide, sgraenitz.
jordan_rose added a project: LLDB.
Herald added a subscriber: mgorny.
It's always going to be at / on disk, but that's not what we should be linking
against! This won't actually change anything in practice, but it's "more
correct", and may be necessary if Apple ever decides to move the implementation
of DebugSymbols.framework to another library.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D59831
Files:
lldb/cmake/modules/LLDBConfig.cmake
Index: lldb/cmake/modules/LLDBConfig.cmake
===================================================================
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -379,7 +379,7 @@
if(NOT IOS)
find_library(CARBON_LIBRARY Carbon)
find_library(CORE_SERVICES_LIBRARY CoreServices)
- find_library(DEBUG_SYMBOLS_LIBRARY DebugSymbols PATHS
"/System/Library/PrivateFrameworks")
+ find_library(DEBUG_SYMBOLS_LIBRARY DebugSymbols PATHS
"${CMAKE_OSX_SYSROOT}/System/Library/PrivateFrameworks")
endif()
find_library(FOUNDATION_LIBRARY Foundation)
find_library(CORE_FOUNDATION_LIBRARY CoreFoundation)
Index: lldb/cmake/modules/LLDBConfig.cmake
===================================================================
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -379,7 +379,7 @@
if(NOT IOS)
find_library(CARBON_LIBRARY Carbon)
find_library(CORE_SERVICES_LIBRARY CoreServices)
- find_library(DEBUG_SYMBOLS_LIBRARY DebugSymbols PATHS "/System/Library/PrivateFrameworks")
+ find_library(DEBUG_SYMBOLS_LIBRARY DebugSymbols PATHS "${CMAKE_OSX_SYSROOT}/System/Library/PrivateFrameworks")
endif()
find_library(FOUNDATION_LIBRARY Foundation)
find_library(CORE_FOUNDATION_LIBRARY CoreFoundation)
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
