[Lldb-commits] [PATCH] D59524: Improve error handling for Clang module imports

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59524/new/ https://reviews.llvm.org/D59524 ___

[Lldb-commits] [PATCH] D59524: Improve error handling for Clang module imports

aprantl created this revision. aprantl added a reviewer: JDevlieghere. Herald added a reviewer: serge-sans-paille. Herald added a project: LLDB. aprantl edited the summary of this revision. Most notably this avoids nullptr dereferences when the import fails. rdar://problem/48883558 Repository:

[Lldb-commits] [lldb] r356416 - A target definition file that may work for

Author: jmolenda Date: Mon Mar 18 14:39:54 2019 New Revision: 356416 URL: http://llvm.org/viewvc/llvm-project?rev=356416&view=rev Log: A target definition file that may work for Aarch32 Cortex-M target processor debugging. Added: lldb/trunk/examples/python/armv7_cortex_m_target_defintion.

[Lldb-commits] [lldb] r356412 - [CMake] Set LLVM_DEFAULT_EXTERNAL_LIT in standalone build correctly on windows

Author: xiaobai Date: Mon Mar 18 14:32:31 2019 New Revision: 356412 URL: http://llvm.org/viewvc/llvm-project?rev=356412&view=rev Log: [CMake] Set LLVM_DEFAULT_EXTERNAL_LIT in standalone build correctly on windows LLVM installed llvm-lit with a .py suffix on windows. Let's match that behavior here

[Lldb-commits] [PATCH] D59427: [WIP] [lldb] [API] Split SBRegistry into smaller files

JDevlieghere added a comment. This looks what I had in mind, thanks Michał! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59427/new/ https://reviews.llvm.org/D59427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

clayborg accepted this revision. clayborg added a comment. I haven't used it in a long time. I can add it back temporarily if I ever need to. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59498/new/ https://reviews.llvm.org/D59498 ___ lldb

[Lldb-commits] [PATCH] D59276: Delete dead code

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Given that this is not tested (I don't see any tests being removed) this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59276/new/ https://reviews.llvm.org/D59276

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

JDevlieghere accepted this revision. JDevlieghere added a subscriber: davide. JDevlieghere added a comment. This revision is now accepted and ready to land. In D59498#1433421 , @zturner wrote: > In all cases, I think the question worth asking is not "could

[Lldb-commits] [lldb] r356401 - [API] Remove unneded LLDB_DISABLE_PYTHON markers.

Author: davide Date: Mon Mar 18 13:02:27 2019 New Revision: 356401 URL: http://llvm.org/viewvc/llvm-project?rev=356401&view=rev Log: [API] Remove unneded LLDB_DISABLE_PYTHON markers. Modified: lldb/trunk/include/lldb/API/SBDebugger.h lldb/trunk/include/lldb/API/SBTypeCategory.h lldb/t

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

zturner marked 4 inline comments as done. zturner added a comment. In all cases, I think the question worth asking is not "could it be used for X", but rather "how often is it actually used for X". Otherwise, it's just technical debt IMO. There's a lot of things that are possible in theory, bu

[Lldb-commits] [PATCH] D59427: [WIP] [lldb] [API] Split SBRegistry into smaller files

mgorny updated this revision to Diff 191125. mgorny added a comment. Hmm, actually with that local `R` declaration I don't have to have an additional set of macros ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59427/new/ https://reviews.llvm.org/D59427 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D59427: [WIP] [lldb] [API] Split SBRegistry into smaller files

mgorny updated this revision to Diff 191124. mgorny added a comment. Does this look right? I've added temporary `*2` versions of the macros to make it build without having to port everything. If it looks fine, I'll go with other files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5942

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

clayborg added a comment. Most of these logs seem useful. See inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp:121-144 - Log *log(LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_ARANGES)); - size_t orig_arange_size = 0; - if (log) { -o

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

zturner created this revision. zturner added reviewers: JDevlieghere, aprantl. Herald added a subscriber: jdoerfert. I don't find these specific log statements particularly high value, as they appear more just like simple function tracing calls (i.e. they log low level implementation details, no

[Lldb-commits] [PATCH] D59430: Update DwarfDebugInfoEntry to use llvm::Error and llvm::Expected

zturner added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59430/new/ https://reviews.llvm.org/D59430 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D59276: Delete dead code

zturner added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59276/new/ https://reviews.llvm.org/D59276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r356379 - Skip TestVSCode_setFunctionBreakpoints on linux

Author: labath Date: Mon Mar 18 09:04:53 2019 New Revision: 356379 URL: http://llvm.org/viewvc/llvm-project?rev=356379&view=rev Log: Skip TestVSCode_setFunctionBreakpoints on linux Test hangs under heavy load. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/

[Lldb-commits] [lldb] r356378 - Fix some "variable 'foo' set but not used" warnings

Author: labath Date: Mon Mar 18 09:04:46 2019 New Revision: 356378 URL: http://llvm.org/viewvc/llvm-project?rev=356378&view=rev Log: Fix some "variable 'foo' set but not used" warnings gcc-8 diagnoses these. Modified: lldb/trunk/source/API/SBFrame.cpp lldb/trunk/source/API/SBTarget.cpp

[Lldb-commits] [PATCH] D59495: Fix an out-of-bounds error in RegisterContextDarwin_arm64

labath created this revision. labath added a reviewer: jasonmolenda. Herald added subscribers: kristof.beyls, javed.absar. gcc diagnoses this as "array subscript 63 is above array bounds of 'RegisterContextDarwin_arm64::VReg [32]'". The correct fix seems to be subtracting the fpu register base in

[Lldb-commits] [lldb] r356377 - Fix libstdc++ data formatters for python3

Author: labath Date: Mon Mar 18 08:42:08 2019 New Revision: 356377 URL: http://llvm.org/viewvc/llvm-project?rev=356377&view=rev Log: Fix libstdc++ data formatters for python3 Use floor-division for consistentcy across python versions. This fixes a couple of libstdc++ data formatter tests. Modifi

[Lldb-commits] [lldb] r356370 - Fix TestCommandScriptImmediateOutput for python3

Author: labath Date: Mon Mar 18 07:13:12 2019 New Revision: 356370 URL: http://llvm.org/viewvc/llvm-project?rev=356370&view=rev Log: Fix TestCommandScriptImmediateOutput for python3 s/iteritems/items Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/command_script_immediat

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath updated this revision to Diff 191079. labath marked 11 inline comments as done. labath added a comment. Updating to address review comments (thank you for the super quick turnaround). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59482/new/ https://reviews.

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath marked 11 inline comments as done. labath added inline comments. Comment at: lib/ObjectYAML/MinidumpYAML.cpp:181 + FeaturesRef.writeAsBinary(FeaturesStream); + std::fill(Features.begin(), Features.end(), 0); + std::memcpy(Features.begin(), FeaturesStorage.begin(), -

[Lldb-commits] [PATCH] D59485: [ASTImporter] Allow adding a shim to the ASTImporter

balazske added a comment. The replace of `Import` calls may work if the internal state of the `ASTImporter` is updated correctly from the 'shim' object (especially if not every Decl is handled by the shim). For this to work some of the state of `ASTImporter` that was intended to be internal mus

[Lldb-commits] [PATCH] D59485: [ASTImporter] Allow adding a shim to the ASTImporter

balazske added a comment. I do not know if "Shim" is the correct name for this, maybe "Strategy" is better? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 ___ lldb-commits m

[Lldb-commits] [PATCH] D59485: [ASTImporter] Allow adding a shim to the ASTImporter

teemperor created this revision. teemperor added reviewers: martong, balazske, a.sidorin, shafik. Herald added subscribers: cfe-commits, rnkovacs. Herald added a project: clang. We are currently implementing support in LLDB that reconstructs the STL templates from the target program in the expres

[Lldb-commits] [lldb] r356362 - Fix "type qualifiers ignored on cast result type" warnings

Author: labath Date: Mon Mar 18 03:50:46 2019 New Revision: 356362 URL: http://llvm.org/viewvc/llvm-project?rev=356362&view=rev Log: Fix "type qualifiers ignored on cast result type" warnings These warnings start to get emitted with gcc-8. Modified: lldb/trunk/source/Plugins/Process/minidump

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

jhenderson added a comment. I've not reviewed the unit test yet, but the bulk of the body looks fine, apart from some minor details. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:27 +struct Stream { + enum StreamKind { +HexKind, I think it is worth m

[Lldb-commits] [PATCH] D58347: Reinitialize UnwindTable when the SymbolFile changes

This revision was automatically updated to reflect the committed changes. Closed by commit rL356361: Reinitialize UnwindTable when the SymbolFile changes (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[Lldb-commits] [lldb] r356361 - Reinitialize UnwindTable when the SymbolFile changes

Author: labath Date: Mon Mar 18 03:45:02 2019 New Revision: 356361 URL: http://llvm.org/viewvc/llvm-project?rev=356361&view=rev Log: Reinitialize UnwindTable when the SymbolFile changes Summary: This is a preparatory step to enable adding of unwind plans by symbol file plugins. Although at the s

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath created this revision. labath added reviewers: jhenderson, zturner, clayborg, aprantl. Herald added a subscriber: mgorny. Herald added a project: LLVM. This patch adds the ability to read a yaml form of a minidump file and write it out as binary. Apart from the minidump header and the strea

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me. I have some comments inline and below, but none of them is really substantial. In D59433#1431602 , @clayborg wrote: > In D59433#1431

[Lldb-commits] [PATCH] D59427: [WIP] [lldb] [API] Split SBRegistry into smaller files

labath added a comment. I like the fact that we're moving the register methods into the respective class files. Among other things, this should make it easier for the instrumentation tool to insert register calls as well. However, I am not fond of introducing a public SB API call for something