clayborg added a comment.
Most of these logs seem useful. See inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp:121-144
- Log *log(LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_ARANGES));
- size_t orig_arange_size = 0;
- if (log) {
- orig_arange_size = m_aranges.GetSize();
- log->Printf("DWARFDebugAranges::Sort(minimize = %u) with %" PRIu64
- " entries",
- minimize, (uint64_t)orig_arange_size);
----------------
These two seem useful. They are only when logging .debug_aranges with
DWARF_LOG_DEBUG_ARANGES. What is left if we remove this?
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp:93
- }
}
----------------
All above logs seem useful. Sometimes we don't get a .debug_aranges section
which means we must parse the address ranges manually. When we are logging
.debug_aranges, it is handy to know where the info came from (.debug_aranges,
or manual index).
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:168-176
- Log *log(
- LogChannelDWARF::GetLogIfAny(DWARF_LOG_DEBUG_INFO | DWARF_LOG_LOOKUPS));
- if (log) {
- m_dwarf->GetObjectFile()->GetModule()->LogMessageVerboseBacktrace(
- log,
- "DWARFUnit::ExtractDIEsIfNeeded () for compile unit at "
- ".debug_info[0x%8.8x]",
----------------
It is nice to know when we parse all DIEs for a compile unit. This helps us to
verify that our lazy DWARF parsing is working. When we have good accelerator
tables, like the Apple ones or DWARF 5 ones, then we will only parse the DIEs
in a compile unit when we need to. Seems like we need one when it starts and
one when it ends so we could see timestamp times...
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:837-844
- Log *log(LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_ARANGES));
-
- if (log) {
- m_dwarf->GetObjectFile()->GetModule()->LogMessage(
- log,
- "DWARFUnit::GetFunctionAranges() for compile unit at "
- ".debug_info[0x%8.8x]",
----------------
This seems useful as it tells us when we manually index a compile unit for all
function address ranges which can be expensive.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59498/new/
https://reviews.llvm.org/D59498
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
