[Lldb-commits] [PATCH] D58883: [lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally()

mgorny created this revision. mgorny added reviewers: krytarowski, labath, JDevlieghere. Herald added a subscriber: abidh. Herald added a project: LLDB. Use '127.0.0.1' instead of 'localhost' in ConnectLocally() function as this is the specific address the server is bound to. Using 'localhost' ma

[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

labath added a comment. In D58842#1415542 , @zturner wrote: > In D58842#1415526 , @labath wrote: > > > Hmm.. I think I've thought of (or remembered, because I have been thinking > > about Utility too) a reason why

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

labath added a comment. Greg, I believe I've responded to all your comments. If there is anything else you want me to do here, please let me know. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58167/new/ https://reviews.llvm.org/D58167 ___

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

labath added a comment. In D58792#1415631 , @clayborg wrote: > If this is new API I guess it is ok to have them all be const. I was mostly > worried that you wouldn't be able to call a non const function from a const > function. Do we have any IsValid()

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

labath updated this revision to Diff 189057. labath added a comment. The version which makes "operator bool" const. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58792/new/ https://reviews.llvm.org/D58792 Files: include/lldb/API/SBAddress.h include/lldb/API/SBBlock.h include/lldb

[Lldb-commits] [lldb] r355276 - Reinstate UNSUPPORTED: linux on stop-hook-threads.test

Author: labath Date: Sat Mar 2 11:58:10 2019 New Revision: 355276 URL: http://llvm.org/viewvc/llvm-project?rev=355276&view=rev Log: Reinstate UNSUPPORTED: linux on stop-hook-threads.test This stanza was removed in r355213, but it seems that patch did not fully fix the problem, as the test still

[Lldb-commits] [PATCH] D58871: [lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355273: [lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D58871?vs=189040&id=189051#toc Rep

[Lldb-commits] [lldb] r355274 - [lldb] [lit] Pass -pthread on NetBSD as well

Author: mgorny Date: Sat Mar 2 08:48:44 2019 New Revision: 355274 URL: http://llvm.org/viewvc/llvm-project?rev=355274&view=rev Log: [lldb] [lit] Pass -pthread on NetBSD as well Modified: lldb/trunk/lit/helper/toolchain.py Modified: lldb/trunk/lit/helper/toolchain.py URL: http://llvm.org/vi

[Lldb-commits] [lldb] r355273 - [lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD

Author: mgorny Date: Sat Mar 2 08:46:29 2019 New Revision: 355273 URL: http://llvm.org/viewvc/llvm-project?rev=355273&view=rev Log: [lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD Remove the code forcing -stdlib=libstdc++ on NetBSD in getBuildFlags() method. NetBSD uses lib

[Lldb-commits] [lldb] r355270 - Fix gcc build for r355249

Author: labath Date: Sat Mar 2 08:23:07 2019 New Revision: 355270 URL: http://llvm.org/viewvc/llvm-project?rev=355270&view=rev Log: Fix gcc build for r355249 automatic move should not fire when returning type T in a function with result type Expected. Some compilers seem to allow that nonetheles

[Lldb-commits] [PATCH] D58871: [lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. hmm.. interesting. I had no idea this function even exists. It's existence if unfortunate as it seems to duplicate some of the logic already present in makefiles, but that's not your problem h

[Lldb-commits] [PATCH] D58860: [build.py] Allow clang-cl to build files starting with '/U'

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems straight-forward enough. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58860/new/ https://reviews.llvm.org/D58860 ___ lldb-commits

[Lldb-commits] [PATCH] D58871: [lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, labath. Herald added a subscriber: abidh. Herald added a reviewer: serge-sans-paille. Herald added a project: LLDB. Remove the code forcing -stdlib=libstdc++ on NetBSD in getBuildFlags() method. NetBSD uses libc++ everywhere else,