mgorny created this revision.
mgorny added reviewers: krytarowski, labath.
Herald added a subscriber: abidh.
Herald added a reviewer: serge-sans-paille.
Herald added a project: LLDB.
Remove the code forcing -stdlib=libstdc++ on NetBSD in getBuildFlags()
method. NetBSD uses libc++ everywhere else, and using libstdc++ here
causes lang/cpp/dynamic-value to fail to build.
NB: I have no clue what `getBuildFlags()` is supposed to do, and why it's used
in the few tests it's used in, so the change can be entirely wrong. However,
tests pass for me with it, and it fixes missing symbols I've had when building
with libstdc++.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D58871
Files:
lldb/packages/Python/lldbsuite/test/lldbtest.py
Index: lldb/packages/Python/lldbsuite/test/lldbtest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -1666,7 +1666,8 @@
elif self.getPlatform() == "openbsd":
cflags += " -stdlib=libc++"
elif self.getPlatform() == "netbsd":
- cflags += " -stdlib=libstdc++"
+ # NetBSD defaults to libc++
+ pass
elif "clang" in self.getCompiler():
cflags += " -stdlib=libstdc++"
Index: lldb/packages/Python/lldbsuite/test/lldbtest.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/lldbtest.py
+++ lldb/packages/Python/lldbsuite/test/lldbtest.py
@@ -1666,7 +1666,8 @@
elif self.getPlatform() == "openbsd":
cflags += " -stdlib=libc++"
elif self.getPlatform() == "netbsd":
- cflags += " -stdlib=libstdc++"
+ # NetBSD defaults to libc++
+ pass
elif "clang" in self.getCompiler():
cflags += " -stdlib=libstdc++"
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
