[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

asmith marked an inline comment as done. asmith added a comment. @clayborg Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:858 +Status ProcessWindows::GetFileLoadAddress(const FileSpec &file, bool &is_loaded, + ll

[Lldb-commits] [lldb] r351158 - [LLDB] Remove the unused variable oso_dwarf.

Author: dlj Date: Mon Jan 14 19:27:54 2019 New Revision: 351158 URL: http://llvm.org/viewvc/llvm-project?rev=351158&view=rev Log: [LLDB] Remove the unused variable oso_dwarf. Patch by Ali Tamur! (ta...@google.com) Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.c

[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

jingham added a comment. In D56462#1351394 , @clayborg wrote: > But if everyone else thinks differently, I'll go with the majority. Just my > initial thoughts. IIRC, the original point of this ParseTypes function was to have a way for lldb developers t

[Lldb-commits] [lldb] r351133 - [SymbolFile] Remove SymbolContext parameter from FindTypes.

Author: zturner Date: Mon Jan 14 14:41:21 2019 New Revision: 351133 URL: http://llvm.org/viewvc/llvm-project?rev=351133&view=rev Log: [SymbolFile] Remove SymbolContext parameter from FindTypes. This parameter was only ever used with the Module set, and since a SymbolFile is tied to a module, the

[Lldb-commits] [lldb] r351132 - [SymbolFile] Remove the SymbolContext parameter from FindNamespace.

Author: zturner Date: Mon Jan 14 14:41:00 2019 New Revision: 351132 URL: http://llvm.org/viewvc/llvm-project?rev=351132&view=rev Log: [SymbolFile] Remove the SymbolContext parameter from FindNamespace. Every callsite was passing an empty SymbolContext, so this parameter had no effect. Inside the

[Lldb-commits] [lldb] r351131 - [SymbolFile] Rename ParseFunctionBlocks to ParseBlocksRecursive.

Author: zturner Date: Mon Jan 14 14:40:41 2019 New Revision: 351131 URL: http://llvm.org/viewvc/llvm-project?rev=351131&view=rev Log: [SymbolFile] Rename ParseFunctionBlocks to ParseBlocksRecursive. This method took a SymbolContext but only actually cared about the case where the m_function membe

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha marked an inline comment as done. tatyana-krasnukha added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 +else + // The register info is incorrect, just clear it. + m_register_info.Clear();

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

xiaobai added a comment. Thanks all for the feedback and discussion! I won't commit this until after the branch cut. I'm thinking it should be fine to do early next week, but I'll wait if needed. Does anyone have any objects to this patch in its current form? I will rebase it later this week to

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 +else + // The register info is incorrect, just clear it. + m_register_info.Clear(); Is this a GDB server that you can modify? Or is

[Lldb-commits] [lldb] r351080 - [lldbsuite] Skip two more flaky tests on Windows

Author: stella.stamenova Date: Mon Jan 14 09:55:17 2019 New Revision: 351080 URL: http://llvm.org/viewvc/llvm-project?rev=351080&view=rev Log: [lldbsuite] Skip two more flaky tests on Windows TestNamespaceLookup occasionally passes unexpectedly and TestExitDuringStep occasionally fails unexpecte

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added a comment. Friendly ping. I would like to have this in the nearest release. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D55827: Update current working directory to avoid test crashes

tatyana-krasnukha abandoned this revision. tatyana-krasnukha added a comment. It is fixed. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55827/new/ https://reviews.llvm.org/D55827 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar abandoned this revision. grimar added a comment. Yep, MSVS2017 works fine here for me too. Thanks, Pavel! I am abandoning it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 ___ lldb-commits m

[Lldb-commits] [PATCH] D56126: [NativePDB] Add basic support of methods recostruction in AST

aleksandr.urakov updated this revision to Diff 181541. aleksandr.urakov added a comment. @zturner Sorry for the long delay with this update. I've applied the changes we were talking about. @labath Thanks for sharing this, it's interesting to know! CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

grimar added a comment. I ended up with the following test case: **TestHistoryCrash.py:** """We crashed when navigated through the history. Check we do not now.""" from __future__ import print_function import os import sys import lldb from lldbsuite.test.decorators import * f

[Lldb-commits] [PATCH] D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

This revision was automatically updated to reflect the committed changes. Closed by commit rL351065: [Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r351065 - [Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild

Author: aleksandr.urakov Date: Mon Jan 14 05:08:13 2019 New Revision: 351065 URL: http://llvm.org/viewvc/llvm-project?rev=351065&view=rev Log: [Core] Use the implementation method GetAddressOf in ValueObjectConstResultChild Summary: This patch allows to retrieve an address object for `ValueObject

[Lldb-commits] [PATCH] D56147: [Core] Use the implementation method `GetAddressOf` in `ValueObjectConstResultChild`

aleksandr.urakov added a comment. Herald added a reviewer: serge-sans-paille. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56147/new/ https://reviews.llvm.org/D56147 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D55827: Update current working directory to avoid test crashes

labath added a comment. I think this problem ought to be fixed now (since D56545 ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55827/new/ https://reviews.llvm.org/D55827 ___ lld

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

labath added a comment. In D56531#1355794 , @sgraenitz wrote: > In D56531#inline-500764 , > @labath wrote: > > > it should be possible to build lldb against an already-installed llvm > > > > > In D56531#inlin

lldb-commits@lists.llvm.org

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56614/new/ https://reviews.llvm.org/D56614 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D56609: [CMake] Remove dead code and outdated comments

labath added inline comments. Comment at: lldb/trunk/cmake/modules/LLDBStandalone.cmake:104 include("${LLVM_OBJ_ROOT}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm/LLVMConfig.cmake") - # cmake/clang/ClangConfig.cmake is not created when LLVM and Clang are built together. if (EXIST

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

sgraenitz added a comment. In D56531#inline-500764 , @labath wrote: > it should be possible to build lldb against an already-installed llvm In D56531#inline-501059 , @xiaobai wrote: > When I wrote

[Lldb-commits] [lldb] r351037 - [CMake] LLVM exports utility targets since r350959, so we can use them without standalone-checks now

Author: stefan.graenitz Date: Mon Jan 14 01:24:50 2019 New Revision: 351037 URL: http://llvm.org/viewvc/llvm-project?rev=351037&view=rev Log: [CMake] LLVM exports utility targets since r350959, so we can use them without standalone-checks now Modified: lldb/trunk/lit/CMakeLists.txt Modified