asmith marked an inline comment as done.
asmith added a comment.

@clayborg



================
Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:858
 
+Status ProcessWindows::GetFileLoadAddress(const FileSpec &file, bool 
&is_loaded,
+                                          lldb::addr_t &load_addr) {
----------------
clayborg wrote:
> This entire function is doing the job of the dynamic loader and should be 
> moved into the dynamic loader.
when do you think the changes you mentioned for the loader and lldb-server.exe 
would be available for review? should we abandon this and wait for those?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56237/new/

https://reviews.llvm.org/D56237



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to