[Lldb-commits] [lldb] r349722 - [lldbsuite] Un-xfail TestRedefinitionsInInlines on Windows

Author: stella.stamenova Date: Wed Dec 19 19:04:14 2018 New Revision: 349722 URL: http://llvm.org/viewvc/llvm-project?rev=349722&view=rev Log: [lldbsuite] Un-xfail TestRedefinitionsInInlines on Windows Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/inlines/TestRedefinitionsInInli

[Lldb-commits] [lldb] r349721 - [lldbsuite] Un-xfail TestDataFormatterSynthVal on Windows

Author: stella.stamenova Date: Wed Dec 19 18:22:09 2018 New Revision: 349721 URL: http://llvm.org/viewvc/llvm-project?rev=349721&view=rev Log: [lldbsuite] Un-xfail TestDataFormatterSynthVal on Windows Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-for

[Lldb-commits] [lldb] r349719 - [lldbsuite] Un-xfail tests on Windows that are now passing (pt.5)

Author: stella.stamenova Date: Wed Dec 19 18:04:01 2018 New Revision: 349719 URL: http://llvm.org/viewvc/llvm-project?rev=349719&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.5) This is a set of tests that were all marked as failing becuse of pr24764. The bug is no

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rL349718: [lldb] Retrieve currently handled Obj-C exception via… (authored by kuba.brecka, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44072

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

kubamracek added a comment. Thanks for the review! Switched to self.assertFalse and self.assertTrue and landed in r349718. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44072/new/ https://reviews.llvm.org/D44072 ___

[Lldb-commits] [lldb] r349718 - [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

Author: kuba.brecka Date: Wed Dec 19 18:01:59 2018 New Revision: 349718 URL: http://llvm.org/viewvc/llvm-project?rev=349718&view=rev Log: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI This builds on https://reviews.

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That's great. There are a couple places where you use self.assertEqual(..., False) where you can use self.assertFalse if you want. A very minor point... Comment at: pac

[Lldb-commits] [lldb] r349713 - [lldbsuite] Un-xfail tests on Windows that are now passing (pt.4)

Author: stella.stamenova Date: Wed Dec 19 17:25:35 2018 New Revision: 349713 URL: http://llvm.org/viewvc/llvm-project?rev=349713&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.4) This is a set of tests that were all marked as failing becuse of several different bugs

[Lldb-commits] [lldb] r349711 - [lldbsuite] Un-xfail tests on Windows that are now passing (pt.3)

Author: stella.stamenova Date: Wed Dec 19 16:58:48 2018 New Revision: 349711 URL: http://llvm.org/viewvc/llvm-project?rev=349711&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.3) This is a set of tests that were all marked as failing becuse of several different bugs

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

kubamracek updated this revision to Diff 178991. kubamracek added a comment. Addressed comment 2. Changed the test to use an Obj-C++ source file, and added a case that throws a plain C++ exception. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44072/new/ https://reviews.llvm.org/D44072

[Lldb-commits] [lldb] r349700 - Simplify code for readability. (NFC)

Author: adrian Date: Wed Dec 19 15:48:40 2018 New Revision: 349700 URL: http://llvm.org/viewvc/llvm-project?rev=349700&view=rev Log: Simplify code for readability. (NFC) Modified: lldb/trunk/source/Core/ValueObjectChild.cpp Modified: lldb/trunk/source/Core/ValueObjectChild.cpp URL: http://l

[Lldb-commits] [lldb] r349692 - Fix line endings.

Author: zturner Date: Wed Dec 19 14:50:22 2018 New Revision: 349692 URL: http://llvm.org/viewvc/llvm-project?rev=349692&view=rev Log: Fix line endings. Modified: lldb/trunk/lit/SymbolFile/NativePDB/nested-types.cpp Modified: lldb/trunk/lit/SymbolFile/NativePDB/nested-types.cpp URL: http://l

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

kubamracek updated this revision to Diff 178954. kubamracek added a comment. Addressing comment 1 (checking that GetCurrentException and GetCurrentExceptionBacktrace returns nothing when there's no exception in flights). Will address comment 2 in a bit. CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

tatyana-krasnukha updated this revision to Diff 178941. tatyana-krasnukha added a comment. Rid off of including std::vector at the cost of adding a wrapper class that can be forward declared. Without this, it is not possible to do https://reviews.llvm.org/D55472#inline-491159 Repository: rLL

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55841/new/ https://reviews.llvm.org/D55841 ___ l

[Lldb-commits] [lldb] r349675 - [NativePDB] Enable function-level-linking.test in native mode.

Author: zturner Date: Wed Dec 19 12:00:25 2018 New Revision: 349675 URL: http://llvm.org/viewvc/llvm-project?rev=349675&view=rev Log: [NativePDB] Enable function-level-linking.test in native mode. This test passes with the native reader, so run it in both modes. Modified: lldb/trunk/lit/Symb

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 178933. tatyana-krasnukha added a comment. Clear `m_register_info` if it is incorrect. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55718/new/ https://reviews.llvm.org/D55718 Files: include/lldb/Utility/ArchSp

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

tatyana-krasnukha updated this revision to Diff 178931. tatyana-krasnukha added a comment. Removed dump file from the patch Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55841/new/ https://reviews.llvm.org/D55841 Files: packages/Python/lldbsuite/test/functi

[Lldb-commits] [lldb] r349673 - [NativePDB] Fix a use after free and enable corresponding native test.

Author: zturner Date: Wed Dec 19 11:45:30 2018 New Revision: 349673 URL: http://llvm.org/viewvc/llvm-project?rev=349673&view=rev Log: [NativePDB] Fix a use after free and enable corresponding native test. We had a use after free where we were assigning the result of a function that returned a str

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707 + +arc::AdjustRegisterInfo(m_register_info, arch_to_use); } clayborg wrote: > ok, makes sense. Clearing the register info would be a go

[Lldb-commits] [lldb] r349668 - [lldbsuite] Un-xfail tests on Windows that are now passing (pt.2)

Author: stella.stamenova Date: Wed Dec 19 11:10:25 2018 New Revision: 349668 URL: http://llvm.org/viewvc/llvm-project?rev=349668&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.2) This is a set of tests that were all marked as failing becuse of pr21765. The bug is no

[Lldb-commits] [lldb] r349665 - [lldbsuite] Un-xfail tests on Windows that are now passing

Author: stella.stamenova Date: Wed Dec 19 11:04:01 2018 New Revision: 349665 URL: http://llvm.org/viewvc/llvm-project?rev=349665&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing This is a set of tests that were all marked as failing becuse of pr24489. The bug is not fixed

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just remove the "regions-linux-map.dmp" as I already checked one in with rLLDB349658 and this is good to go Comment at:

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg added a comment. In D55841#1336519 , @clayborg wrote: > In D55841#1336515 , > @tatyana-krasnukha wrote: > > > Add a test > > > There was one added. See code Never mind, I thought this was my patch! Ignor

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

clayborg added a comment. In D55841#1336515 , @tatyana-krasnukha wrote: > Add a test There was one added. See code Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55841/new/ https://reviews.llvm.org/D55841 _

[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump

tatyana-krasnukha updated this revision to Diff 178916. tatyana-krasnukha added a comment. Add a test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55841/new/ https://reviews.llvm.org/D55841 Files: packages/Python/lldbsuite/test/functionalities/postmortem/m

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

clayborg added a comment. In D55718#1336045 , @tatyana-krasnukha wrote: > `ARCflags` are used by ABISysV_arc (related patch D55724 > ). I would be glad to move it to > architecture plugin, but I ought to add SetFlags/Get

[Lldb-commits] [PATCH] D55854: Show the memory region name if there is one in the output of the "memory region" command

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349658: Show the memory region name if there is one in the output of the "memory… (authored by gclayton, committed by ). Herald added a subscriber: abidh. Repository: rLLDB LLDB CHANGES SINCE LAST A

[Lldb-commits] [lldb] r349658 - Show the memory region name if there is one in the output of the "memory region" command

Author: gclayton Date: Wed Dec 19 10:16:52 2018 New Revision: 349658 URL: http://llvm.org/viewvc/llvm-project?rev=349658&view=rev Log: Show the memory region name if there is one in the output of the "memory region" command Prior to this change we would show the name of the section that a memory

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil updated this revision to Diff 178911. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55859/new/ https://reviews.llvm.org/D55859 Files: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py packages/Python/lldbsuite/test/tools/lldb-mi/

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil updated this revision to Diff 178910. jankratochvil marked an inline comment as done. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55859/new/ https://reviews.llvm.org/D55859 Files: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil marked 4 inline comments as done. jankratochvil added a comment. In D55859#1336351 , @friss wrote: > Pretty sure this won't work. It might generate a dSYM, but an empty one. I agree LLDB did not parse such DSYM symbols on Linux. Is the pat

[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

stella.stamenova added a comment. I tracked this down - the failures are not due to this change (or any LLDB change). It's this change to the common CMake files in LLVM: https://reviews.llvm.org/D55056 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55384/new/ htt

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. One quick change required to avoid STL in public headers. Comment at: include/lldb/lldb-forward.h:16 #include "lldb/Utility/SharingPtr.h" +#include

[Lldb-commits] [lldb] r349642 - [lit] Make TestConvenienceVariables a cpp file

Author: jdevlieghere Date: Wed Dec 19 09:10:21 2018 New Revision: 349642 URL: http://llvm.org/viewvc/llvm-project?rev=349642&view=rev Log: [lit] Make TestConvenienceVariables a cpp file The build.py script always runs the compiler in C++ mode, regardless of the file extension. This results in man

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

friss added inline comments. Comment at: source/Host/common/Symbols.cpp:365 + if (!external_lookup) { +Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST); jankratochvil wrote: > labath wrote: > > This doesn't sound right to me. It looks li

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

friss added a comment. > Unfortunately, I don't think llvm has anything like that, though I think it > would be extremely useful (/me looks at apple folks). If you try hard enough, > you should be able to get clang to produce a dsym bundle for you even on > linux. This did the trick for me: >

[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code

tatyana-krasnukha updated this revision to Diff 178883. tatyana-krasnukha added a comment. Minor change: replace `using` with `typedef` since old swig versions don't understand c++11's aliases. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55472/new/ https://r

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha marked an inline comment as not done. tatyana-krasnukha added a comment. `ARCflags` are used by ABISysV_arc (related patch D55724 ). I would be glad to move it to architecture plugin, but I ought to add SetFlags/GetFlags to Architecture interfac

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

labath added a comment. > I have regression tested it only on Fedora 29 x86_64. I see now it may > regress OSX but I have no idea what really dsym is. dsym is a apple-specific format for external storage of debug info. I think the closest standard equivalent would be a DWP bundle, but there som

[Lldb-commits] [PATCH] D55827: Update current working directory to avoid test crashes

labath added a comment. In D55827#1335207 , @JDevlieghere wrote: > In D55827#1334671 , @labath wrote: > > > Hm... this seems like an important issue in the `RealFileSystem` (or our > > usage of it), and I'm not su

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

This revision was automatically updated to reflect the committed changes. Closed by commit rL349607: refactor testsuite spawnLldbMi args->exe+args (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55858?vs=178

[Lldb-commits] [lldb] r349607 - refactor testsuite spawnLldbMi args->exe+args

Author: jankratochvil Date: Wed Dec 19 00:57:10 2018 New Revision: 349607 URL: http://llvm.org/viewvc/llvm-project?rev=349607&view=rev Log: refactor testsuite spawnLldbMi args->exe+args Currently spawnLldbMi accepts both lldb-mi options and executable to debug as a single parameter. Split them.

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

jankratochvil added inline comments. Comment at: source/Host/common/Symbols.cpp:365 + if (!external_lookup) { +Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST); labath wrote: > This doesn't sound right to me. It looks like this will prev

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

labath added reviewers: aprantl, clayborg. labath added a comment. I think this fits well in the spirit in which the `enable-external-lookup` setting was introduced (i.e., to reduce test environment dependencies on mac), but the letter is somewhat questionable. The setting is currently described

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

jankratochvil updated this revision to Diff 178842. jankratochvil marked an inline comment as done. jankratochvil added a comment. I have put there a comment: self.runCmd("-file-exec-and-symbols \"%s\"" % exe) +# Testcases expect to be able to match output of this com

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, if that's how things worked previously, then this lgtm. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55858/new/ https://reviews.llvm.org/D55858 _

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

jankratochvil marked 3 inline comments as done. jankratochvil added a comment. Thanks for the review! Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py:53 +if exe: +self.runCmd("-file-exec-and-symbols \"%s\"" % exe) --

[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

labath added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py:53 +if exe: +self.runCmd("-file-exec-and-symbols \"%s\"" % exe) Shouldn't you also expect the `^done` response here or something simila

[Lldb-commits] [PATCH] D55854: Show the memory region name if there is one in the output of the "memory region" command

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks fine to me. I have one inline suggestion you can consider. Also, I've been wondering whether there is any existing minidump that you could have used for the test purposes. It doesn'