friss added inline comments.
================
Comment at: source/Host/common/Symbols.cpp:365
+ if (!external_lookup) {
+ Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST);
----------------
jankratochvil wrote:
> labath wrote:
> > This doesn't sound right to me. It looks like this will prevent
> > `LocateDSYMInVincinityOfExecutable`, which (I would expect) is necessary to
> > find dsym bundles for all of our dsym tests.
> I have regression tested it only on Fedora 29 x86_64. I see now it may
> regress OSX but I have no idea what really dsym is. I do not have OSX
> available, is it accessible somewhere remotely for LLVM development (such as
> is [[ https://cfarm.tetaneutral.net/ | GCC Compile Farm ]])?
I would just remove that early exit. The rest of the code shouldn't impact the
systems you care about.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55859/new/
https://reviews.llvm.org/D55859
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
