[Lldb-commits] [PATCH] D50681: Remove manual byte counting from internal Stream methods.

teemperor created this revision. This patch removes the manual byte counting in all internal Stream methods. This is now done by the automatic byte counting provided by calling `GetWrittenBytes()` before and after writing the data (which is automatically done for us by the `ByteDelta` utility cl

[Lldb-commits] [PATCH] D50677: Remove manual byte counting from Opcode::Dump

teemperor created this revision. teemperor added a reviewer: clayborg. Stream now has byte-counting functionality, so let's use this instead of manual byte counting. Repository: rLLDB LLDB https://reviews.llvm.org/D50677 Files: source/Core/Opcode.cpp Index: source/Core/Opcode.cpp ==

[Lldb-commits] [PATCH] D50676: Remove manual byte counting from Highlighter code.

teemperor created this revision. This removes the manual byte counting mechanism from the syntax highlighting code. This is no longer necessary as the Stream class now has built-in support for automatically counting the bytes that were written to it so far. The advantage of automatic byte counti

[Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

clayborg updated this revision to Diff 160466. clayborg added a comment. Herald added subscribers: jfb, srhines. - Use the LLVM JSON parser - Split lldb-vscode.cpp into smaller files - Fix function names - ran clang format on everything https://reviews.llvm.org/D50365 Files: lldb.xcodeproj/pr

[Lldb-commits] [PATCH] D50536: Fix: ConstString::GetConstCStringAndSetMangledCounterPart() should update the value if the key exists already

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. https://reviews.llvm.org/D50536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] r339615 - Update TestTargetXMLArch.py test for llvm triple change with unspecified

Author: jmolenda Date: Mon Aug 13 14:20:29 2018 New Revision: 339615 URL: http://llvm.org/viewvc/llvm-project?rev=339615&view=rev Log: Update TestTargetXMLArch.py test for llvm triple change with unspecified components in r339294. Modified: lldb/trunk/packages/Python/lldbsuite/test/functiona

[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL339611: Added test for Core/Range class. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50620?vs=160439&id=160441#toc

[Lldb-commits] [lldb] r339611 - Added test for Core/Range class.

Author: teemperor Date: Mon Aug 13 13:43:06 2018 New Revision: 339611 URL: http://llvm.org/viewvc/llvm-project?rev=339611&view=rev Log: Added test for Core/Range class. Summary: We can optimize and refactor some of the classes in RangeMap.h, but first we should have some tests for all the data st

[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.

teemperor updated this revision to Diff 160439. teemperor added a comment. - Addressed Vedant's comments (thanks!) https://reviews.llvm.org/D50620 Files: unittests/Core/CMakeLists.txt unittests/Core/RangeTest.cpp Index: unittests/Core/RangeTest.cpp =

[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, looks good with nitpicks. Comment at: unittests/Core/RangeTest.cpp:139 + RangeT r; + // FIXME: This is probably not intended. + EXPECT_TRUE(r.ContainsEndInclusive(0)); -

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

This revision was automatically updated to reflect the committed changes. Closed by commit rL339583: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

[Lldb-commits] [lldb] r339583 - Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

Author: stefan.graenitz Date: Mon Aug 13 09:45:06 2018 New Revision: 339583 URL: http://llvm.org/viewvc/llvm-project?rev=339583&view=rev Log: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium Summary: Removing FastDemangle will greatly reduce maintenance efforts. This patch r

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

zturner added a comment. Ok I’ll take a look later today then when i get in https://reviews.llvm.org/D49980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

Ok I’ll take a look later today then when i get in On Mon, Aug 13, 2018 at 2:13 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > Unfortunately, there was no people yet, who can review this :) > > Ping! Can anyone review this, please? >

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D50587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

sgraenitz marked 3 inline comments as done. sgraenitz added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:281 llvm::StringRef replace) { - Log *log = GetLogIfAllCategoriesSet(LIBLLDB_LOG_LANGUAGE

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

sgraenitz updated this revision to Diff 160330. sgraenitz added a comment. Address Jonas' comments, fix logging, fix copying over remaining part from original, polishing https://reviews.llvm.org/D50587 Files: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp unittests/Language/CPlusP

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added a comment. Unfortunately, there was no people yet, who can review this :) Ping! Can anyone review this, please? https://reviews.llvm.org/D49980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D50587: Straight forward FastDemangle replacement in SubsPrimitiveParmItanium

JDevlieghere added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:281 llvm::StringRef replace) { - Log *log = GetLogIfAllCategoriesSet(LIBLLDB_LOG_LANGUAGE); - - const size_t max_len = - man