sgraenitz marked 3 inline comments as done.
sgraenitz added inline comments.
================
Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:281
llvm::StringRef replace) {
- Log *log = GetLogIfAllCategoriesSet(LIBLLDB_LOG_LANGUAGE);
-
- const size_t max_len =
- mangled.size() + mangled.count(search) * replace.size() + 1;
+ struct SwapParms {
+ llvm::StringRef mangled;
----------------
JDevlieghere wrote:
> I had to look at the old code to understand the name of this struct. How
> about DemangleContext or even just Context?
Aligned it with the function name
================
Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:316
+ read_pos = mangled.size();
+ }
+
----------------
This was missing. Also added a test.
https://reviews.llvm.org/D50587
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
